Re: [Intel-wired-lan] [PATCH iwl-next v2 5/5] iavf: Add VIRTCHNL Opcodes Support for Queue bw Setting

From: "Zhang, Xuejun" <xuejun.zhang@intel.com>
To: Simon Horman <horms@kernel.org>, Wenjun Wu <wenjun1.wu@intel.com>
Cc: netdev@vger.kernel.org, anthony.l.nguyen@intel.com,
	intel-wired-lan@lists.osuosl.org, qi.z.zhang@intel.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 5/5] iavf: Add VIRTCHNL Opcodes Support for Queue bw Setting
Date: Wed, 9 Aug 2023 11:44:19 -0700	[thread overview]
Message-ID: <f62fc232-8bbf-253b-5eb2-3131d767d6df@intel.com> (raw)
In-Reply-To: <ZNKrc6xchj8Jkct+@vergenet.net>


On 8/8/2023 1:54 PM, Simon Horman wrote:
> On Tue, Aug 08, 2023 at 09:57:34AM +0800, Wenjun Wu wrote:
>> From: Jun Zhang <xuejun.zhang@intel.com>
> ...
>
>> @@ -2471,6 +2687,16 @@ void iavf_virtchnl_completion(struct iavf_adapter *adapter,
>>   		if (!v_retval)
>>   			iavf_netdev_features_vlan_strip_set(netdev, false);
>>   		break;
>> +	case VIRTCHNL_OP_GET_QOS_CAPS:
>> +		u16 len = struct_size(adapter->qos_caps, cap,
>> +				      IAVF_MAX_QOS_TC_NUM);
> Hi Jun Zhang and Wenju Wu,
>
> clang-16 complains about this quite a lot.
> I think it is because it wants the declaration of len - and thus
> the rest of this case - inside a block ({}).
>
>   .../iavf_virtchnl.c:2691:3: error: expected expression
>                   u16 len = struct_size(adapter->qos_caps, cap,
>                   ^
>   .../iavf_virtchnl.c:2693:46: error: use of undeclared identifier 'len'
>                   memcpy(adapter->qos_caps, msg, min(msglen, len));
>                                                              ^
>   .../iavf_virtchnl.c:2693:46: error: use of undeclared identifier 'len'
Thanks for the solution.
>> +		memcpy(adapter->qos_caps, msg, min(msglen, len));
>> +		break;
>> +	case VIRTCHNL_OP_CONFIG_QUANTA:
>> +		iavf_notify_queue_config_complete(adapter);
>> +		break;
>> +	case VIRTCHNL_OP_CONFIG_QUEUE_BW:
>> +		break;
>>   	default:
>>   		if (adapter->current_op && (v_opcode != adapter->current_op))
>>   			dev_warn(&adapter->pdev->dev, "Expected response %d from PF, received %d\n",
>> -- 
>> 2.34.1
>>
>>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan