Re: [PATCH v3] platform/x86: ideapad-laptop: do not poke keyboard controller

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

Hi Rong,

On Sun, Oct 25, 2026 at 10:25:46AM +0800, Rong Zhang wrote:
> > +static const struct input_device_id ideapad_tpswitch_ids[] = {
> > +	{
> > +		.flags = INPUT_DEVICE_ID_MATCH_EVBIT |
> > +				INPUT_DEVICE_ID_MATCH_KEYBIT |
> > +				INPUT_DEVICE_ID_MATCH_ABSBIT,
> > +		.bustype = BUS_I8042,
> > +		.vendor = 0x0002,
>
> Missing INPUT_DEVICE_ID_MATCH_BUS and INPUT_DEVICE_ID_MATCH_VENDOR?
>
> Other than that and the module parameter's name, the patch looks good to
> me. With them fixed:
>
> Reviewed-by: Rong Zhang <i@rong.moe>
> Tested-by: Rong Zhang <i@rong.moe> # not matching other touchpads

Indeed, well spotted! I have added the missing match flags and your tags
in v4.

Thanks.

-- 
Dmitry