From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Mark Pearson" <mpearson-lenovo@squebb.ca>,
"Derek J. Clark" <derekjohn.clark@gmail.com>,
"Ike Panhc" <ikepanhc@gmail.com>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Maxim Mikityanskiy" <maxtram95@gmail.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] platform/x86: ideapad-laptop: do not poke keyboard controller
Date: Fri, 23 Oct 2026 11:21:48 +0200 [thread overview]
Message-ID: <atsmraNrFH4HW3Qb@monoceros> (raw)
In-Reply-To: <4b2f60a7ceac543bd8b889b9c0772b2c@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]
On Wed, Oct 21, 2026 at 09:50:56PM -0700, Dmitry Torokhov wrote:
> On Ideapad Z570 the driver tries to disable and re-enable data coming
> from the touchpad by poking directly into 8042 keyboard controller.
> This may coincide with the controller resuming and leads to spews in
> dmesg and potentially other instabilities.
>
> Instead of using i8042_command() to control the touchpad state create
> an input handler that serves as a filter and drop events coming from
> the touchpad when it is supposed to be off.
>
> Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>
> v3:
> - add missing header includes (compiler.h, container_of.h, errno.h,
> mod_devicetable.h, slab.h, spinlock.h)
noooooooo, mod_devicetable.h is wrong, I want to get rid of that header
and input_device_id is already provided by <inux/input.h>.
If you want full iwyu, please use <linux/device-id/input.h> instead.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-10-23 9:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 4:50 [PATCH v3] platform/x86: ideapad-laptop: do not poke keyboard controller Dmitry Torokhov
2026-10-23 9:21 ` Uwe Kleine-König [this message]
2026-10-23 16:04 ` Alice Mikityanska
2026-10-23 16:37 ` Alice Mikityanska
2026-10-23 23:05 ` Dmitry Torokhov
2026-10-24 2:15 ` Rong Zhang
2026-10-24 3:20 ` Dmitry Torokhov
2026-10-24 15:30 ` Rong Zhang
2026-10-24 23:13 ` Dmitry Torokhov
2026-10-25 1:52 ` Rong Zhang
2026-10-25 2:38 ` Dmitry Torokhov
2026-10-25 2:25 ` Rong Zhang
2026-10-27 3:06 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atsmraNrFH4HW3Qb@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=derekjohn.clark@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hansg@kernel.org \
--cc=ikepanhc@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxtram95@gmail.com \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.