From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yao Zi <ziyao@disroot.org>
Cc: Drew Fustini <fustini@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Albert Ou <aou@eecs.berkeley.edu>,
Michal Wilczynski <m.wilczynski@samsung.com>,
Alexandre Ghiti <alex@ghiti.fr>, Rob Herring <robh@kernel.org>,
Han Gao <gaohan@iscas.ac.cn>, Han Gao <rabenda.cn@gmail.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
devicetree@vger.kernel.org, Guo Ren <guoren@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-riscv@lists.infradead.org, Fu Wei <wefu@redhat.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: reset: Scope the compatible to VO subsystem explicitly
Date: Fri, 22 Aug 2025 11:45:00 +0200 [thread overview]
Message-ID: <9542da82-af39-43a2-8a83-014e1484d6d5@kernel.org> (raw)
In-Reply-To: <aKgqJWKOssEfgNRO@pie>
On 22/08/2025 10:28, Yao Zi wrote:
> On Thu, Aug 21, 2025 at 09:54:08AM +0200, Krzysztof Kozlowski wrote:
>> On Wed, Aug 20, 2025 at 07:42:43AM +0000, Yao Zi wrote:
>>> The reset controller driver for the TH1520 was using the generic
>>> compatible string "thead,th1520-reset". However, the controller
>>> described by this compatible only manages the resets for the Video
>>> Output (VO) subsystem.
>>
>> Please use subject prefixes matching the subsystem. You can get them for
>> example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory
>> your patch is touching. For bindings, the preferred subjects are
>> explained here:
>> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>
> Thanks for your review, I appreciate it and will stick to
> thead,th1520-reset for the VO reset controller.
>
> But I'm not very clear about the subject prefix: I already have a
> "dt-bindings: reset: " prefix, should I also make the subject more
> precise, including the exact file changed when changing a binding file?
Yes, as you can check in other commits. Your subject claims that you
change " Scope the compatible to VO subsystem explicitly" for all reset
controllers.
>
> I've seen commits either with or without the precise name of the changed
> binding in subjects. For example,
>
> a341bcfbfa7 dt-bindings: reset: add compatible for bcm63xx ephy control
But it says bcm63xx at least. Well, you will find plenty of poor
examples as well. I gave you template response because you made typical
mistake.
Anyway, you ignored rest of my response, so I assume you agree with it
completely.
Best regards,
Krzysztof
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yao Zi <ziyao@disroot.org>
Cc: Drew Fustini <fustini@kernel.org>, Guo Ren <guoren@kernel.org>,
Fu Wei <wefu@redhat.com>, Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Michal Wilczynski <m.wilczynski@samsung.com>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Icenowy Zheng <uwu@icenowy.me>,
Han Gao <rabenda.cn@gmail.com>, Han Gao <gaohan@iscas.ac.cn>,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: reset: Scope the compatible to VO subsystem explicitly
Date: Fri, 22 Aug 2025 11:45:00 +0200 [thread overview]
Message-ID: <9542da82-af39-43a2-8a83-014e1484d6d5@kernel.org> (raw)
In-Reply-To: <aKgqJWKOssEfgNRO@pie>
On 22/08/2025 10:28, Yao Zi wrote:
> On Thu, Aug 21, 2025 at 09:54:08AM +0200, Krzysztof Kozlowski wrote:
>> On Wed, Aug 20, 2025 at 07:42:43AM +0000, Yao Zi wrote:
>>> The reset controller driver for the TH1520 was using the generic
>>> compatible string "thead,th1520-reset". However, the controller
>>> described by this compatible only manages the resets for the Video
>>> Output (VO) subsystem.
>>
>> Please use subject prefixes matching the subsystem. You can get them for
>> example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory
>> your patch is touching. For bindings, the preferred subjects are
>> explained here:
>> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>
> Thanks for your review, I appreciate it and will stick to
> thead,th1520-reset for the VO reset controller.
>
> But I'm not very clear about the subject prefix: I already have a
> "dt-bindings: reset: " prefix, should I also make the subject more
> precise, including the exact file changed when changing a binding file?
Yes, as you can check in other commits. Your subject claims that you
change " Scope the compatible to VO subsystem explicitly" for all reset
controllers.
>
> I've seen commits either with or without the precise name of the changed
> binding in subjects. For example,
>
> a341bcfbfa7 dt-bindings: reset: add compatible for bcm63xx ephy control
But it says bcm63xx at least. Well, you will find plenty of poor
examples as well. I gave you template response because you made typical
mistake.
Anyway, you ignored rest of my response, so I assume you agree with it
completely.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-22 15:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 7:42 [PATCH v2 0/3] Scope TH1520 reset driver to VO subsystem Yao Zi
2025-08-20 7:42 ` Yao Zi
2025-08-20 7:42 ` [PATCH v2 1/3] dt-bindings: reset: Scope the compatible to VO subsystem explicitly Yao Zi
2025-08-20 7:42 ` Yao Zi
2025-08-21 7:54 ` Krzysztof Kozlowski
2025-08-21 7:54 ` Krzysztof Kozlowski
2025-08-22 8:28 ` Yao Zi
2025-08-22 8:28 ` Yao Zi
2025-08-22 9:45 ` Krzysztof Kozlowski [this message]
2025-08-22 9:45 ` Krzysztof Kozlowski
2025-08-20 7:42 ` [PATCH v2 2/3] reset: th1520: Support the new compatible for VO-subsystem controller Yao Zi
2025-08-20 7:42 ` Yao Zi
2025-08-21 7:50 ` Krzysztof Kozlowski
2025-08-21 7:50 ` Krzysztof Kozlowski
2025-08-20 7:42 ` [PATCH v2 3/3] riscv: dts: thead: Scope the reset controller to VO for TH1520 Yao Zi
2025-08-20 7:42 ` Yao Zi
2025-08-21 7:49 ` Krzysztof Kozlowski
2025-08-21 7:49 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9542da82-af39-43a2-8a83-014e1484d6d5@kernel.org \
--to=krzk@kernel.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fustini@kernel.org \
--cc=gaohan@iscas.ac.cn \
--cc=guoren@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=m.wilczynski@samsung.com \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rabenda.cn@gmail.com \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
--cc=wefu@redhat.com \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.