From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [PATCH] stubdom: remove caml-stubdom
Date: Wed, 22 Nov 2023 10:00:09 +0000 [thread overview]
Message-ID: <95872c39-a375-4c0a-b22f-a0798634e86b@citrix.com> (raw)
In-Reply-To: <be27f207-47d5-4795-812b-4af82f734ba8@suse.com>
On 22/11/2023 7:20 am, Juergen Gross wrote:
> On 21.11.23 22:14, Andrew Cooper wrote:
>> On 20/11/2023 10:36 am, Juergen Gross wrote:
>>> On 01.11.23 17:08, Juergen Gross wrote:
>>>> In order to build caml-stubdom, it must be explicitly enabled via
>>>> "configure --enable-caml-stubdom". The build process is failing due to
>>>> stubdom/ocaml.patch failing to apply. Since the patched file has been
>>>> modified in 2014 the last time, it seems nobody cares for caml-stubdom
>>>> since at least then.
>>>>
>>>> Remove caml-stubdom from the build system.
>>>>
>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>
>>> Any comments?
>>
>> I'd say the tumbleweeds from the Ocaml folks says enough.
>>
>> Any chance you can resend with the Changelog adjustment, and with the
>> option stripped out of ./configure ? Might as well clean up everything
>> as we go.
>
> I can do the Changelog adjustment, but I don't see what else could be
> removed
> from configure. The patch already _is_ removing the --enable-caml-stubdom
> option from stubdom/configure.
Oh, so it does. I'd assumed it would be in the root ./configure.
~Andrew
prev parent reply other threads:[~2023-11-22 10:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 16:08 [PATCH] stubdom: remove caml-stubdom Juergen Gross
2023-11-01 16:28 ` Andrew Cooper
2023-11-20 10:36 ` Juergen Gross
2023-11-21 21:14 ` Andrew Cooper
2023-11-22 7:20 ` Juergen Gross
2023-11-22 10:00 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95872c39-a375-4c0a-b22f-a0798634e86b@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=jgross@suse.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.