From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: acme@kernel.org, irogers@google.com, peterz@infradead.org,
mingo@redhat.com, namhyung@kernel.org, jolsa@kernel.org,
adrian.hunter@intel.com, john.g.garry@oracle.com,
will@kernel.org, james.clark@arm.com, mike.leach@linaro.org,
yuhaixin.yhx@linux.alibaba.com, renyu.zj@linux.alibaba.com,
tmricht@linux.ibm.com, ravi.bangoria@amd.com,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 1/5] perf mem: Add mem_events into the supported perf_pmu
Date: Wed, 13 Dec 2023 11:19:42 -0500 [thread overview]
Message-ID: <95fee418-27bc-4a0c-b438-8d6d770dbefc@linux.intel.com> (raw)
In-Reply-To: <20231213142414.GH86143@leoy-huanghe.lan>
On 2023-12-13 9:24 a.m., Leo Yan wrote:
> On Mon, Dec 11, 2023 at 02:01:37PM -0500, Liang, Kan wrote:
>
> [...]
>
>>> I will hold on a bit for the test until this patch set addresses the
>>> concern for the breakage issues on Arm64. Please check my review in
>>> other replies.
>>
>> The reviews in the other replies don't look like break any current usage
>> on Arm64. I think the breakage issue is what you described in this
>> patch, right?
>
> I mentioned the breakage is in the patch 04, but I think the concern
> is dismissed.
>
>> If we move the check of "arm_spe_0" to arch/arm/util/pmu.c, it seems we
>> have to move the perf_mem_events_arm[] into arch/arm/util/mem-events.c
>> as well. Is it OK?
>
> No. For fixing Arm64 building, please refer:
>
> https://termbin.com/0dkn
That's great! Thanks a lot!
>
>> I'm not familiar with ARM and have no idea how those events are
>> organized under arm64 and arm. Could you please send a fix for the
>> building failure on aarch64? I will fold it into the V3.
>
> After apply the change in above link on the top of your patch set,
> it can build successfully at my side. Hope it's helpful.
>
Yes, that's help a lot. I will send the V3 shortly.
Thanks,
Kan
WARNING: multiple messages have this Message-ID (diff)
From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: acme@kernel.org, irogers@google.com, peterz@infradead.org,
mingo@redhat.com, namhyung@kernel.org, jolsa@kernel.org,
adrian.hunter@intel.com, john.g.garry@oracle.com,
will@kernel.org, james.clark@arm.com, mike.leach@linaro.org,
yuhaixin.yhx@linux.alibaba.com, renyu.zj@linux.alibaba.com,
tmricht@linux.ibm.com, ravi.bangoria@amd.com,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 1/5] perf mem: Add mem_events into the supported perf_pmu
Date: Wed, 13 Dec 2023 11:19:42 -0500 [thread overview]
Message-ID: <95fee418-27bc-4a0c-b438-8d6d770dbefc@linux.intel.com> (raw)
In-Reply-To: <20231213142414.GH86143@leoy-huanghe.lan>
On 2023-12-13 9:24 a.m., Leo Yan wrote:
> On Mon, Dec 11, 2023 at 02:01:37PM -0500, Liang, Kan wrote:
>
> [...]
>
>>> I will hold on a bit for the test until this patch set addresses the
>>> concern for the breakage issues on Arm64. Please check my review in
>>> other replies.
>>
>> The reviews in the other replies don't look like break any current usage
>> on Arm64. I think the breakage issue is what you described in this
>> patch, right?
>
> I mentioned the breakage is in the patch 04, but I think the concern
> is dismissed.
>
>> If we move the check of "arm_spe_0" to arch/arm/util/pmu.c, it seems we
>> have to move the perf_mem_events_arm[] into arch/arm/util/mem-events.c
>> as well. Is it OK?
>
> No. For fixing Arm64 building, please refer:
>
> https://termbin.com/0dkn
That's great! Thanks a lot!
>
>> I'm not familiar with ARM and have no idea how those events are
>> organized under arm64 and arm. Could you please send a fix for the
>> building failure on aarch64? I will fold it into the V3.
>
> After apply the change in above link on the top of your patch set,
> it can build successfully at my side. Hope it's helpful.
>
Yes, that's help a lot. I will send the V3 shortly.
Thanks,
Kan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-13 16:19 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 19:23 [PATCH V2 0/5] Clean up perf mem kan.liang
2023-12-07 19:23 ` kan.liang
2023-12-07 19:23 ` [PATCH V2 1/5] perf mem: Add mem_events into the supported perf_pmu kan.liang
2023-12-07 19:23 ` kan.liang
2023-12-08 10:29 ` Leo Yan
2023-12-08 10:29 ` Leo Yan
2023-12-08 18:14 ` Liang, Kan
2023-12-08 18:14 ` Liang, Kan
2023-12-09 6:34 ` Leo Yan
2023-12-09 6:34 ` Leo Yan
2023-12-11 19:01 ` Liang, Kan
2023-12-11 19:01 ` Liang, Kan
2023-12-13 14:24 ` Leo Yan
2023-12-13 14:24 ` Leo Yan
2023-12-13 16:19 ` Liang, Kan [this message]
2023-12-13 16:19 ` Liang, Kan
2023-12-07 19:23 ` [PATCH V2 2/5] perf mem: Clean up perf_mem_events__ptr() kan.liang
2023-12-07 19:23 ` kan.liang
2023-12-09 4:31 ` Leo Yan
2023-12-09 4:31 ` Leo Yan
2023-12-11 18:09 ` Liang, Kan
2023-12-11 18:09 ` Liang, Kan
2023-12-07 19:23 ` [PATCH V2 3/5] perf mem: Clean up perf_mem_events__name() kan.liang
2023-12-07 19:23 ` kan.liang
2023-12-08 0:01 ` Ian Rogers
2023-12-08 0:01 ` Ian Rogers
2023-12-09 5:48 ` Leo Yan
2023-12-09 5:48 ` Leo Yan
2023-12-11 18:39 ` Liang, Kan
2023-12-11 18:39 ` Liang, Kan
2023-12-13 13:33 ` Leo Yan
2023-12-13 13:33 ` Leo Yan
2023-12-13 16:17 ` Liang, Kan
2023-12-13 16:17 ` Liang, Kan
2023-12-13 17:33 ` Ian Rogers
2023-12-13 17:33 ` Ian Rogers
2023-12-18 3:21 ` Leo Yan
2023-12-18 3:21 ` Leo Yan
2023-12-07 19:23 ` [PATCH V2 4/5] perf mem: Clean up perf_mem_event__supported() kan.liang
2023-12-07 19:23 ` kan.liang
2023-12-09 6:17 ` Leo Yan
2023-12-09 6:17 ` Leo Yan
2023-12-11 18:44 ` Liang, Kan
2023-12-11 18:44 ` Liang, Kan
2023-12-13 13:51 ` Leo Yan
2023-12-13 13:51 ` Leo Yan
2023-12-13 13:55 ` Ravi Bangoria
2023-12-13 13:55 ` Ravi Bangoria
2023-12-07 19:23 ` [PATCH V2 5/5] perf mem: Clean up is_mem_loads_aux_event() kan.liang
2023-12-07 19:23 ` kan.liang
2023-12-09 6:27 ` Leo Yan
2023-12-09 6:27 ` Leo Yan
2023-12-11 18:45 ` Liang, Kan
2023-12-11 18:45 ` Liang, Kan
2023-12-07 20:31 ` [PATCH V2 0/5] Clean up perf mem Arnaldo Carvalho de Melo
2023-12-07 20:31 ` Arnaldo Carvalho de Melo
2023-12-13 9:51 ` Athira Rajeev
2023-12-13 9:51 ` Athira Rajeev
2023-12-13 19:54 ` Liang, Kan
2023-12-13 19:54 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95fee418-27bc-4a0c-b438-8d6d770dbefc@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=renyu.zj@linux.alibaba.com \
--cc=tmricht@linux.ibm.com \
--cc=will@kernel.org \
--cc=yuhaixin.yhx@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.