From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Mauro Carvalho Chehab <m.chehab@samsung.com>,
Tony Lindgren <tony@atomide.com>
Cc: linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/5] ARM: omap2: cm-t35: Add regulators and clock for camera sensor
Date: Tue, 18 Feb 2014 13:47:04 +0100 [thread overview]
Message-ID: <9621770.WFqvfViqR7@avalon> (raw)
In-Reply-To: <1392069284-18024-2-git-send-email-laurent.pinchart@ideasonboard.com>
Mauro, Tony,
On Monday 10 February 2014 22:54:40 Laurent Pinchart wrote:
> The camera sensor will soon require regulators and clocks. Register
> fixed regulators for its VAA and VDD power supplies and a fixed rate
> clock for its master clock.
This patch is a prerequisite for a set of 4 patches that need to go through
the linux-media tree. It would simpler if it could go through the same tree as
well. Given that arch/arm/mach-omap2/board-cm-t35.c has seen very little
activity recently I believe the risk of conflict is pretty low. Tony, would
that be fine with you ?
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/mach-omap2/board-cm-t35.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/board-cm-t35.c
> b/arch/arm/mach-omap2/board-cm-t35.c index 8dd0ec8..018353d 100644
> --- a/arch/arm/mach-omap2/board-cm-t35.c
> +++ b/arch/arm/mach-omap2/board-cm-t35.c
> @@ -16,6 +16,8 @@
> *
> */
>
> +#include <linux/clk-provider.h>
> +#include <linux/clkdev.h>
> #include <linux/kernel.h>
> #include <linux/init.h>
> #include <linux/platform_device.h>
> @@ -542,8 +544,22 @@ static struct isp_platform_data cm_t35_isp_pdata = {
> .subdevs = cm_t35_isp_subdevs,
> };
>
> +static struct regulator_consumer_supply cm_t35_camera_supplies[] = {
> + REGULATOR_SUPPLY("vaa", "3-005d"),
> + REGULATOR_SUPPLY("vdd", "3-005d"),
> +};
> +
> static void __init cm_t35_init_camera(void)
> {
> + struct clk *clk;
> +
> + clk = clk_register_fixed_rate(NULL, "mt9t001-clkin", NULL, CLK_IS_ROOT,
> + 48000000);
> + clk_register_clkdev(clk, NULL, "3-005d");
> +
> + regulator_register_fixed(2, cm_t35_camera_supplies,
> + ARRAY_SIZE(cm_t35_camera_supplies));
> +
> if (omap3_init_camera(&cm_t35_isp_pdata) < 0)
> pr_warn("CM-T3x: Failed registering camera device!\n");
> }
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] ARM: omap2: cm-t35: Add regulators and clock for camera sensor
Date: Tue, 18 Feb 2014 13:47:04 +0100 [thread overview]
Message-ID: <9621770.WFqvfViqR7@avalon> (raw)
In-Reply-To: <1392069284-18024-2-git-send-email-laurent.pinchart@ideasonboard.com>
Mauro, Tony,
On Monday 10 February 2014 22:54:40 Laurent Pinchart wrote:
> The camera sensor will soon require regulators and clocks. Register
> fixed regulators for its VAA and VDD power supplies and a fixed rate
> clock for its master clock.
This patch is a prerequisite for a set of 4 patches that need to go through
the linux-media tree. It would simpler if it could go through the same tree as
well. Given that arch/arm/mach-omap2/board-cm-t35.c has seen very little
activity recently I believe the risk of conflict is pretty low. Tony, would
that be fine with you ?
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/mach-omap2/board-cm-t35.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/board-cm-t35.c
> b/arch/arm/mach-omap2/board-cm-t35.c index 8dd0ec8..018353d 100644
> --- a/arch/arm/mach-omap2/board-cm-t35.c
> +++ b/arch/arm/mach-omap2/board-cm-t35.c
> @@ -16,6 +16,8 @@
> *
> */
>
> +#include <linux/clk-provider.h>
> +#include <linux/clkdev.h>
> #include <linux/kernel.h>
> #include <linux/init.h>
> #include <linux/platform_device.h>
> @@ -542,8 +544,22 @@ static struct isp_platform_data cm_t35_isp_pdata = {
> .subdevs = cm_t35_isp_subdevs,
> };
>
> +static struct regulator_consumer_supply cm_t35_camera_supplies[] = {
> + REGULATOR_SUPPLY("vaa", "3-005d"),
> + REGULATOR_SUPPLY("vdd", "3-005d"),
> +};
> +
> static void __init cm_t35_init_camera(void)
> {
> + struct clk *clk;
> +
> + clk = clk_register_fixed_rate(NULL, "mt9t001-clkin", NULL, CLK_IS_ROOT,
> + 48000000);
> + clk_register_clkdev(clk, NULL, "3-005d");
> +
> + regulator_register_fixed(2, cm_t35_camera_supplies,
> + ARRAY_SIZE(cm_t35_camera_supplies));
> +
> if (omap3_init_camera(&cm_t35_isp_pdata) < 0)
> pr_warn("CM-T3x: Failed registering camera device!\n");
> }
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-02-18 12:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 21:54 [PATCH 0/5] mt9t001 and mt9p031 sensors drivers patches Laurent Pinchart
2014-02-10 21:54 ` Laurent Pinchart
2014-02-10 21:54 ` [PATCH 1/5] ARM: omap2: cm-t35: Add regulators and clock for camera sensor Laurent Pinchart
2014-02-10 21:54 ` Laurent Pinchart
2014-02-18 12:47 ` Laurent Pinchart [this message]
2014-02-18 12:47 ` Laurent Pinchart
2014-02-18 14:03 ` Igor Grinberg
2014-02-18 14:03 ` Igor Grinberg
2014-02-18 15:03 ` Laurent Pinchart
2014-02-18 15:03 ` Laurent Pinchart
2014-02-19 17:05 ` Tony Lindgren
2014-02-19 17:05 ` Tony Lindgren
2014-02-10 21:54 ` [PATCH 2/5] mt9t001: Add regulator support Laurent Pinchart
2014-02-10 21:54 ` Laurent Pinchart
2014-02-10 21:54 ` [PATCH 3/5] mt9t001: Add clock support Laurent Pinchart
2014-02-10 21:54 ` Laurent Pinchart
2014-02-10 21:54 ` [PATCH 4/5] mt9p031: Fix typo in comment Laurent Pinchart
2014-02-10 21:54 ` Laurent Pinchart
2014-02-10 21:54 ` [PATCH 5/5] mt9p031: Add support for PLL bypass Laurent Pinchart
2014-02-10 21:54 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9621770.WFqvfViqR7@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.