From: "Rafael J. Wysocki" <rafael@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
platform-driver-x86@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Hans de Goede <hansg@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Corentin Chary <corentin.chary@gmail.com>,
"Luke D. Jones" <luke@ljones.dev>,
Denis Benato <denis.benato@linux.dev>,
Jonathan Woithe <jwoithe@just42.net>,
Robert Gerlach <khnz@gmx.de>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Mark Pearson <mpearson-lenovo@squebb.ca>,
"Derek J. Clark" <derekjohn.clark@gmail.com>,
Kenneth Chan <kenneth.t.chan@gmail.com>,
Mattia Dongili <malattia@linux.it>,
Azael Avalos <coproscefalo@gmail.com>
Subject: [PATCH v1 07/10] platform/x86: sony-laptop: Stop setting acpi_device_class()
Date: Fri, 03 Jul 2026 13:32:31 +0200 [thread overview]
Message-ID: <9664323.CDJkKcVGEf@rafael.j.wysocki> (raw)
In-Reply-To: <5135166.31r3eYUQgx@rafael.j.wysocki>
From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Since acpi_device_class() set by the driver is only used for generating
ACPI netlink events and the "sony/hotkey" string literal may as well be
used directly for this purpose, make the driver do so and stop setting
acpi_device_class() in it.
No intentional functional impact.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/platform/x86/sony-laptop.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index 67370967df6f..0bf4d3054e37 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -1264,7 +1264,7 @@ static void sony_nc_notify(acpi_handle ah, u32 event, void *data)
ev_type = HOTKEY;
sony_laptop_report_input_event(real_ev);
}
- acpi_bus_generate_netlink_event(sony_nc_acpi_device->pnp.device_class,
+ acpi_bus_generate_netlink_event("sony/hotkey",
dev_name(&sony_nc_acpi_device->dev), ev_type, real_ev);
}
@@ -3157,8 +3157,6 @@ static int sony_nc_probe(struct platform_device *pdev)
return -ENODEV;
sony_nc_acpi_device = device;
- strscpy(acpi_device_class(device), "sony/hotkey");
-
sony_nc_acpi_handle = device->handle;
/* read device status */
@@ -4523,7 +4521,6 @@ static int sony_pic_probe(struct platform_device *pdev)
return -ENODEV;
spic_dev.acpi_dev = device;
- strscpy(acpi_device_class(device), "sony/hotkey");
sony_pic_detect_device_type(&spic_dev);
mutex_init(&spic_dev.lock);
--
2.51.0
next prev parent reply other threads:[~2026-07-03 11:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 11:15 [PATCH v1 00/10] platform/x86: Stop using acpi_device_name/class() Rafael J. Wysocki
2026-07-03 11:19 ` [PATCH v1 01/10] platform/x86: asus-laptop: Stop setting acpi_device_name/class() Rafael J. Wysocki
2026-07-03 11:21 ` [PATCH v1 02/10] platform/x86: eeepc-laptop: " Rafael J. Wysocki
2026-07-03 11:23 ` [PATCH v1 03/10] platform/x86: fujitsu-laptop: " Rafael J. Wysocki
2026-07-03 13:08 ` Jonathan Woithe
2026-07-03 11:28 ` [PATCH v1 04/10] platform/x86: fujitsu-tablet: " Rafael J. Wysocki
2026-07-03 11:30 ` [PATCH v1 05/10] platform/x86: thinkpad_acpi: Stop setting acpi_device_class() Rafael J. Wysocki
2026-07-03 12:18 ` Andy Shevchenko
2026-07-03 12:20 ` Rafael J. Wysocki (Intel)
2026-07-03 12:18 ` Mark Pearson
2026-07-03 11:30 ` [PATCH v1 06/10] platform/x86: panasonic-laptop: Stop setting acpi_device_name/class() Rafael J. Wysocki (Intel)
2026-07-03 11:32 ` Rafael J. Wysocki [this message]
2026-07-03 11:36 ` [PATCH v1 08/10] platform/x86: toshiba_acpi: Do not use uninitialized device_class Rafael J. Wysocki
2026-07-03 11:36 ` [PATCH v1 09/10] platform/x86: toshiba_haps: " Rafael J. Wysocki
2026-07-03 11:37 ` [PATCH v1 10/10] platform/x86: xo15-ebook: Stop setting acpi_device_name/class() Rafael J. Wysocki
2026-07-03 12:10 ` [PATCH v1 00/10] platform/x86: Stop using acpi_device_name/class() Andy Shevchenko
2026-07-03 12:15 ` Rafael J. Wysocki (Intel)
2026-07-03 12:41 ` Andy Shevchenko
2026-07-03 12:44 ` Rafael J. Wysocki (Intel)
2026-07-03 12:47 ` Andy Shevchenko
2026-07-03 12:19 ` Andy Shevchenko
2026-07-03 12:24 ` Rafael J. Wysocki (Intel)
2026-07-06 17:20 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9664323.CDJkKcVGEf@rafael.j.wysocki \
--to=rafael@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=coproscefalo@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=denis.benato@linux.dev \
--cc=derekjohn.clark@gmail.com \
--cc=hansg@kernel.org \
--cc=hmh@hmh.eng.br \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jwoithe@just42.net \
--cc=kenneth.t.chan@gmail.com \
--cc=khnz@gmx.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=malattia@linux.it \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.