From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
"Linux ACPI" <linux-acpi@vger.kernel.org>,
"Hans de Goede" <hansg@kernel.org>,
"Corentin Chary" <corentin.chary@gmail.com>,
"Luke D. Jones" <luke@ljones.dev>,
"Denis Benato" <denis.benato@linux.dev>,
"Jonathan Woithe" <jwoithe@just42.net>,
"Robert Gerlach" <khnz@gmx.de>,
"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
"Mark Pearson" <mpearson-lenovo@squebb.ca>,
"Derek J. Clark" <derekjohn.clark@gmail.com>,
"Kenneth Chan" <kenneth.t.chan@gmail.com>,
"Mattia Dongili" <malattia@linux.it>,
"Azael Avalos" <coproscefalo@gmail.com>
Subject: Re: [PATCH v1 00/10] platform/x86: Stop using acpi_device_name/class()
Date: Fri, 3 Jul 2026 15:19:32 +0300 [thread overview]
Message-ID: <akeo1CfX1ayQPPew@ashevche-desk.local> (raw)
In-Reply-To: <akemrOqzWtcDVqey@ashevche-desk.local>
On Fri, Jul 03, 2026 at 03:10:26PM +0300, Andy Shevchenko wrote:
> On Fri, Jul 03, 2026 at 01:15:01PM +0200, Rafael J. Wysocki wrote:
> > Hi All,
> >
> > There are two fields in struct acpi_device_pnp, device_name and device_class,
> > that were supposed to be populated and used by device drivers, but they have
> > never been used consistently and some drivers just populate them and don't
> > access them later, and some drivers use them uninitialized.
> >
> > All of that is confusing and messy, so the drivers for core ACPI devices
> > have been updated to stop using those fields which are now slated for
> > removal, but they are still accessed in some places.
> >
> > This series updates platform x86 drivers accessing those fields to stop
> > doing that.
>
> In most of the patches you have double space in your name in From. Can we have
> some consistency here? Or is it deliberate (in which case I'm wondering why)?
I looked into all patches and I see them good.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
(with preferably used same From field across the patches).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-07-03 12:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 11:15 [PATCH v1 00/10] platform/x86: Stop using acpi_device_name/class() Rafael J. Wysocki
2026-07-03 11:19 ` [PATCH v1 01/10] platform/x86: asus-laptop: Stop setting acpi_device_name/class() Rafael J. Wysocki
2026-07-03 11:21 ` [PATCH v1 02/10] platform/x86: eeepc-laptop: " Rafael J. Wysocki
2026-07-03 11:23 ` [PATCH v1 03/10] platform/x86: fujitsu-laptop: " Rafael J. Wysocki
2026-07-03 13:08 ` Jonathan Woithe
2026-07-03 11:28 ` [PATCH v1 04/10] platform/x86: fujitsu-tablet: " Rafael J. Wysocki
2026-07-03 11:30 ` [PATCH v1 05/10] platform/x86: thinkpad_acpi: Stop setting acpi_device_class() Rafael J. Wysocki
2026-07-03 12:18 ` Andy Shevchenko
2026-07-03 12:20 ` Rafael J. Wysocki (Intel)
2026-07-03 12:18 ` Mark Pearson
2026-07-03 11:30 ` [PATCH v1 06/10] platform/x86: panasonic-laptop: Stop setting acpi_device_name/class() Rafael J. Wysocki (Intel)
2026-07-03 11:32 ` [PATCH v1 07/10] platform/x86: sony-laptop: Stop setting acpi_device_class() Rafael J. Wysocki
2026-07-03 11:36 ` [PATCH v1 08/10] platform/x86: toshiba_acpi: Do not use uninitialized device_class Rafael J. Wysocki
2026-07-03 11:36 ` [PATCH v1 09/10] platform/x86: toshiba_haps: " Rafael J. Wysocki
2026-07-03 11:37 ` [PATCH v1 10/10] platform/x86: xo15-ebook: Stop setting acpi_device_name/class() Rafael J. Wysocki
2026-07-03 12:10 ` [PATCH v1 00/10] platform/x86: Stop using acpi_device_name/class() Andy Shevchenko
2026-07-03 12:15 ` Rafael J. Wysocki (Intel)
2026-07-03 12:41 ` Andy Shevchenko
2026-07-03 12:44 ` Rafael J. Wysocki (Intel)
2026-07-03 12:47 ` Andy Shevchenko
2026-07-03 12:19 ` Andy Shevchenko [this message]
2026-07-03 12:24 ` Rafael J. Wysocki (Intel)
2026-07-06 17:20 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akeo1CfX1ayQPPew@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=coproscefalo@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=denis.benato@linux.dev \
--cc=derekjohn.clark@gmail.com \
--cc=hansg@kernel.org \
--cc=hmh@hmh.eng.br \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jwoithe@just42.net \
--cc=kenneth.t.chan@gmail.com \
--cc=khnz@gmx.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=malattia@linux.it \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.