From: Jan Beulich <jbeulich@suse.com>
To: Mykyta Poturai <Mykyta_Poturai@epam.com>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger@xenproject.org>,
"Teddy Astie" <teddy.astie@vates.tech>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Michal Orzel" <michal.orzel@amd.com>,
"Julien Grall" <julien@xen.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Jason Andryuk" <jason.andryuk@amd.com>,
"Stewart Hildebrand" <stewart.hildebrand@amd.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v1 0/3] vpci/msix: separate out common MSI-X code
Date: Wed, 28 Oct 2026 09:58:56 +0100 [thread overview]
Message-ID: <96fdb610-65a7-451a-8d3b-600dfcd7ca8a@suse.com> (raw)
In-Reply-To: <a07250ac-263f-46d7-8037-7db2ee17f11f@epam.com>
On 28.10.2026 09:43, Mykyta Poturai wrote:
> On 10/27/26 12:21 PM, Jan Beulich wrote:
>> On 27.10.2026 10:39, Mykyta Poturai wrote:
>>> On 10/26/26 2:34 PM, Jan Beulich wrote:
>>>> On 26.10.2026 13:27, Mykyta Poturai wrote:
>>>>> This is preparatory work to make vPCI MSI-X functional on Arm. Split the
>>>>> vPCI MSI-X code so that intercepting the MSI-X table and PBA stays x86
>>>>> only,
>>>>
>>>> This likely is related to peculiarities of Arm's interrupt handling, yet
>>>> on the surface I can't see why not intercepting MSI-X table accesses
>>>> would be safe. Would it be possible to extend background here a little?
>>>
>>> On Arm most of the work is done by the ITS, so the only thing the device
>>> needs to write to the doorbell register is the EventID. Interrupt
>>> translation is fully configured in the ITS; it will reject invalid
>>> EventIDs and also has a sideband DeviceID, so misconfigured devices
>>> cannot trigger each other's interrupts. Memory-wise everything is gated
>>> by the IOMMU, so a wrong doorbell address would not pose any risk either.
>>
>> And a guest fiddling with the mask bits behind Xen's back isn't a problem
>> either?
>
> No. Masking/unmasking an interrupt the guest has already mapped is just
> the guest doing its own configuration. Unmasking an unmapped interrupt
> will result in it being discarded by the ITS. So I don't see a problem
> here either.
IOW unlike on x86, on Arm Xen never has a need to (transiently) mask an
interrupt that the guest wants / considers unmasked?
Jan
next prev parent reply other threads:[~2026-10-28 8:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 12:27 [PATCH v1 0/3] vpci/msix: separate out common MSI-X code Mykyta Poturai
2026-10-26 12:27 ` [PATCH v1 1/3] vpci/msix: move helpers to common Mykyta Poturai
2026-10-26 12:44 ` Andrew Cooper
2026-10-26 12:28 ` [PATCH v1 2/3] vpci/msix: move msix region removal to msix.c Mykyta Poturai
2026-10-26 12:28 ` [PATCH v1 3/3] vpci/msix: move common msix code to common file Mykyta Poturai
2026-10-26 12:49 ` Andrew Cooper
2026-10-26 12:34 ` [PATCH v1 0/3] vpci/msix: separate out common MSI-X code Jan Beulich
2026-10-27 9:39 ` Mykyta Poturai
2026-10-27 10:21 ` Jan Beulich
2026-10-28 8:43 ` Mykyta Poturai
2026-10-28 8:58 ` Jan Beulich [this message]
2026-10-28 9:25 ` Mykyta Poturai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96fdb610-65a7-451a-8d3b-600dfcd7ca8a@suse.com \
--to=jbeulich@suse.com \
--cc=Mykyta_Poturai@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=jason.andryuk@amd.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger@xenproject.org \
--cc=sstabellini@kernel.org \
--cc=stewart.hildebrand@amd.com \
--cc=teddy.astie@vates.tech \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.