From: Sergey Sorokin <afarallax@yandex.ru>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Eduardo Habkost <ehabkost@redhat.com>, Jia Liu <proljc@gmail.com>,
Anthony Green <green@moxielogic.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Michael Walle <michael@walle.cc>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>,
Leon Alrae <leon.alrae@imgtec.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-arm] [PATCH 1/2] Fix confusing argument names of do_unaligned_access() functions
Date: Tue, 14 Jun 2016 15:01:39 +0300 [thread overview]
Message-ID: <9704001465905699@web22o.yandex.ru> (raw)
In-Reply-To: <20160613070325.GA16232@aurel32.net>
Seems arm_cpu_do_unaligned_access() function could use it. It uses cpu_mmu_index() for now but I think use of mmu_idx is preferred. Anyway it's the subject for another patch.
13.06.2016, 10:47, "Aurelien Jarno" <aurelien@aurel32.net>:
> On 2016-06-10 19:26, Sergey Sorokin wrote:
>> There are functions cpu_unaligned_access() and do_unaligned_access() that
>> are called with access type and mmu index arguments. But these arguments
>> are named 'is_write' and 'is_user' in their declarations.
>> The patch fixes the names to avoid a confusion.
>
> Unless I missed something, it seems that the is_user/mmu_idx argument is
> never used. Should we maybe just drop it?
>
> Otherwise it looks fine.
>
> --
> Aurelien Jarno GPG: 4096R/1DDD8C9B
> aurelien@aurel32.net http://www.aurel32.net
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Sorokin <afarallax@yandex.ru>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Richard Henderson <rth@twiddle.net>,
Peter Maydell <peter.maydell@linaro.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Michael Walle <michael@walle.cc>,
Leon Alrae <leon.alrae@imgtec.com>,
Anthony Green <green@moxielogic.com>, Jia Liu <proljc@gmail.com>,
David Gibson <david@gibson.dropbear.id.au>,
Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Max Filippov <jcmvbkbc@gmail.com>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/2] Fix confusing argument names of do_unaligned_access() functions
Date: Tue, 14 Jun 2016 15:01:39 +0300 [thread overview]
Message-ID: <9704001465905699@web22o.yandex.ru> (raw)
In-Reply-To: <20160613070325.GA16232@aurel32.net>
Seems arm_cpu_do_unaligned_access() function could use it. It uses cpu_mmu_index() for now but I think use of mmu_idx is preferred. Anyway it's the subject for another patch.
13.06.2016, 10:47, "Aurelien Jarno" <aurelien@aurel32.net>:
> On 2016-06-10 19:26, Sergey Sorokin wrote:
>> There are functions cpu_unaligned_access() and do_unaligned_access() that
>> are called with access type and mmu index arguments. But these arguments
>> are named 'is_write' and 'is_user' in their declarations.
>> The patch fixes the names to avoid a confusion.
>
> Unless I missed something, it seems that the is_user/mmu_idx argument is
> never used. Should we maybe just drop it?
>
> Otherwise it looks fine.
>
> --
> Aurelien Jarno GPG: 4096R/1DDD8C9B
> aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2016-06-14 12:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 16:26 [Qemu-arm] [PATCH 0/2] Fix confusing argument names in some common functions Sergey Sorokin
2016-06-10 16:26 ` [Qemu-devel] " Sergey Sorokin
2016-06-10 16:26 ` [Qemu-arm] [PATCH 1/2] Fix confusing argument names of do_unaligned_access() functions Sergey Sorokin
2016-06-10 16:26 ` [Qemu-devel] " Sergey Sorokin
2016-06-10 16:33 ` Peter Maydell
2016-06-10 16:33 ` Peter Maydell
2016-06-10 16:36 ` [Qemu-arm] " Sergey Sorokin
2016-06-10 16:36 ` [Qemu-devel] " Sergey Sorokin
2016-06-10 16:42 ` [Qemu-arm] " Sergey Sorokin
2016-06-10 16:42 ` [Qemu-devel] " Sergey Sorokin
2016-06-10 16:43 ` [Qemu-arm] " Peter Maydell
2016-06-10 16:43 ` [Qemu-devel] " Peter Maydell
2016-06-10 17:26 ` [Qemu-arm] " Sergey Sorokin
2016-06-10 17:26 ` [Qemu-devel] " Sergey Sorokin
2016-06-13 8:23 ` [Qemu-arm] " Paolo Bonzini
2016-06-13 8:23 ` [Qemu-devel] " Paolo Bonzini
2016-06-13 7:03 ` Aurelien Jarno
2016-06-13 7:03 ` Aurelien Jarno
2016-06-14 12:01 ` Sergey Sorokin [this message]
2016-06-14 12:01 ` Sergey Sorokin
2016-06-10 16:26 ` [Qemu-arm] [PATCH 2/2] Fix a confusing argument name in tlb_fill() function Sergey Sorokin
2016-06-10 16:26 ` [Qemu-devel] " Sergey Sorokin
2016-06-11 10:28 ` [Qemu-arm] " David Gibson
2016-06-11 10:28 ` [Qemu-devel] " David Gibson
2016-06-14 18:40 ` [Qemu-arm] " Eduardo Habkost
2016-06-14 18:40 ` [Qemu-devel] " Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9704001465905699@web22o.yandex.ru \
--to=afarallax@yandex.ru \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=green@moxielogic.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=jcmvbkbc@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=leon.alrae@imgtec.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=michael@walle.cc \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=proljc@gmail.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.