From: icenowy@aosc.xyz (Icenowy Zheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board
Date: Thu, 25 Aug 2016 14:57:24 +0800 [thread overview]
Message-ID: <97321472108244@web8m.yandex.ru> (raw)
In-Reply-To: <CAGb2v66tFENk8QBw7D1+bwFN-zWaE2SGDrNyc-zdbJSRzENk4Q@mail.gmail.com>
25.08.2016, 12:41, "Chen-Yu Tsai" <wens@csie.org>:
> On Thu, Aug 25, 2016 at 7:58 AM, Icenowy Zheng <icenowy@aosc.xyz> wrote:
>> ?25.08.2016, 03:36, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
>>> ?Hi,
>>>
>>> ?On Tue, Aug 23, 2016 at 02:44:51PM +0800, Icenowy Zheng wrote:
>>>> ??UART1 is connected to the bluetooth part of RTL8723BS WiFi/BT combo card
>>>> ??on iNet D978 Rev2 board.
>>>>
>>>> ??Enable the UART1 to make it possible to use the modified hciattach by
>>>> ??Realtek to drive the BT part of RTL8723BS.
>>>>
>>>> ??Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
>>>
>>> ?I guess you could fold that patch into the previous one.
>>>
>>>> ??---
>>>> ???arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts | 11 +++++++++++
>>>> ???1 file changed, 11 insertions(+)
>>>>
>>>> ??diff --git a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
>>>> ??index 78823d8..3ac22d4 100644
>>>> ??--- a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
>>>> ??+++ b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
>>>> ??@@ -48,6 +48,10 @@
>>>> ???????????model = "INet-D978 Rev 02";
>>>> ???????????compatible = "primux,inet-d978-rev2", "allwinner,sun8i-a33";
>>>>
>>>> ??+ aliases {
>>>> ??+ serial1 = &uart1;
>>>> ??+ };
>>>> ??+
>>>
>>> ?Is there any other UART in the system?
>>
>> ?serial0 is defined in sun8i-reference-design-tablet.dtsi, as r_uart.
>
> If your board does not have r_uart pads, then the right thing to do
> would be to disable it. You can then have uart1 as serial0.
I don't know it. The RX/TX is wired on PF2/PF4 on the board (UART0 muxed with
MMC)
But many codes will require a ttyS0 as console... So I think the bluetooth should be
located at ttyS1...
>
> AFAIK Linux requires a console, but that console can be simplefb.
>
> ChenYu
>
>>> ?The alias is not supposed to be about the controller index, but the
>>> ?index in the board, meaning that if you only have a single UART, that
>>> ?would be serial0.
>>>
>>> ?Thanks!
>>> ?Maxime
>>>
>>> ?--
>>> ?Maxime Ripard, Free Electrons
>>> ?Embedded Linux and Kernel engineering
>>> ?http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Icenowy Zheng <icenowy@aosc.xyz>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Russell King <linux@armlinux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board
Date: Thu, 25 Aug 2016 14:57:24 +0800 [thread overview]
Message-ID: <97321472108244@web8m.yandex.ru> (raw)
In-Reply-To: <CAGb2v66tFENk8QBw7D1+bwFN-zWaE2SGDrNyc-zdbJSRzENk4Q@mail.gmail.com>
25.08.2016, 12:41, "Chen-Yu Tsai" <wens@csie.org>:
> On Thu, Aug 25, 2016 at 7:58 AM, Icenowy Zheng <icenowy@aosc.xyz> wrote:
>> 25.08.2016, 03:36, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
>>> Hi,
>>>
>>> On Tue, Aug 23, 2016 at 02:44:51PM +0800, Icenowy Zheng wrote:
>>>> UART1 is connected to the bluetooth part of RTL8723BS WiFi/BT combo card
>>>> on iNet D978 Rev2 board.
>>>>
>>>> Enable the UART1 to make it possible to use the modified hciattach by
>>>> Realtek to drive the BT part of RTL8723BS.
>>>>
>>>> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
>>>
>>> I guess you could fold that patch into the previous one.
>>>
>>>> ---
>>>> arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts | 11 +++++++++++
>>>> 1 file changed, 11 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
>>>> index 78823d8..3ac22d4 100644
>>>> --- a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
>>>> +++ b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
>>>> @@ -48,6 +48,10 @@
>>>> model = "INet-D978 Rev 02";
>>>> compatible = "primux,inet-d978-rev2", "allwinner,sun8i-a33";
>>>>
>>>> + aliases {
>>>> + serial1 = &uart1;
>>>> + };
>>>> +
>>>
>>> Is there any other UART in the system?
>>
>> serial0 is defined in sun8i-reference-design-tablet.dtsi, as r_uart.
>
> If your board does not have r_uart pads, then the right thing to do
> would be to disable it. You can then have uart1 as serial0.
I don't know it. The RX/TX is wired on PF2/PF4 on the board (UART0 muxed with
MMC)
But many codes will require a ttyS0 as console... So I think the bluetooth should be
located at ttyS1...
>
> AFAIK Linux requires a console, but that console can be simplefb.
>
> ChenYu
>
>>> The alias is not supposed to be about the controller index, but the
>>> index in the board, meaning that if you only have a single UART, that
>>> would be serial0.
>>>
>>> Thanks!
>>> Maxime
>>>
>>> --
>>> Maxime Ripard, Free Electrons
>>> Embedded Linux and Kernel engineering
>>> http://free-electrons.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2016-08-25 6:57 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 6:44 [PATCH 0/2] Add support for iNet D978 Rev2 board Icenowy Zheng
2016-08-23 6:44 ` Icenowy Zheng
2016-08-23 6:44 ` [PATCH 1/2] ARM: dts: sun8i: Add dts file for inet-d978_rev2 tablets Icenowy Zheng
2016-08-23 6:44 ` Icenowy Zheng
2016-08-24 19:32 ` Maxime Ripard
2016-08-24 19:32 ` Maxime Ripard
2016-08-24 19:32 ` Maxime Ripard
2016-08-24 23:57 ` Icenowy Zheng
2016-08-24 23:57 ` Icenowy Zheng
2016-08-25 7:35 ` Maxime Ripard
2016-08-25 7:35 ` Maxime Ripard
2016-08-25 7:35 ` Maxime Ripard
2016-08-23 6:44 ` [PATCH 2/2] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board Icenowy Zheng
2016-08-23 6:44 ` Icenowy Zheng
2016-08-24 19:36 ` Maxime Ripard
2016-08-24 19:36 ` Maxime Ripard
2016-08-24 19:36 ` Maxime Ripard
2016-08-24 23:58 ` Icenowy Zheng
2016-08-24 23:58 ` Icenowy Zheng
2016-08-25 4:40 ` Chen-Yu Tsai
2016-08-25 4:40 ` Chen-Yu Tsai
2016-08-25 4:40 ` Chen-Yu Tsai
2016-08-25 6:57 ` Icenowy Zheng [this message]
2016-08-25 6:57 ` Icenowy Zheng
2016-08-25 8:03 ` Maxime Ripard
2016-08-25 8:03 ` Maxime Ripard
2016-08-25 8:03 ` Maxime Ripard
2016-08-25 14:12 ` Icenowy Zheng
2016-08-25 14:12 ` Icenowy Zheng
2016-08-25 14:17 ` Hans de Goede
2016-08-25 14:17 ` Hans de Goede
2016-08-25 14:17 ` Hans de Goede
2016-08-25 14:53 ` Icenowy Zheng
2016-08-25 14:53 ` Icenowy Zheng
2016-08-25 15:13 ` Hans de Goede
2016-08-25 15:13 ` Hans de Goede
2016-08-25 15:13 ` Hans de Goede
2016-08-25 15:29 ` Icenowy Zheng
2016-08-25 15:29 ` Icenowy Zheng
2016-08-25 14:53 ` Icenowy Zheng
2016-08-25 14:53 ` Icenowy Zheng
2016-08-25 20:47 ` Maxime Ripard
2016-08-25 20:47 ` Maxime Ripard
2016-08-25 20:47 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97321472108244@web8m.yandex.ru \
--to=icenowy@aosc.xyz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.