All of lore.kernel.org
 help / color / mirror / Atom feed
* [scarthgap][PATCH] package.bbclass: fix execution order bug in emit_pkgdata
@ 2026-07-22 12:11 AshishKumar Mishra
  2026-07-22 12:15 ` AshishKumar Mishra
  0 siblings, 1 reply; 6+ messages in thread
From: AshishKumar Mishra @ 2026-07-22 12:11 UTC (permalink / raw)
  To: openembedded-core; +Cc: AshishKumar Mishra

emit_pkgdata was previously part of the PACKAGEFUNCS list.
Because other layers and recipes often append custom cleanup or processing
functions to PACKAGEFUNCS , those ended up running after
emit_pkgdata

To fix this, pull emit_pkgdata out of PACKAGEFUNCS and call it explicitly
at the very end of do_package() ensuring it always runs last.

(From OE-Core rev aa85baff9ebdd3f932811c3b43d1918c38373cb9)

Signed-off-by: AshishKumar Mishra <emailaddress.ashish@gmail.com>
---
 meta/classes-global/package.bbclass | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/meta/classes-global/package.bbclass b/meta/classes-global/package.bbclass
index aa1eb5e901..ffe3ed93ef 100644
--- a/meta/classes-global/package.bbclass
+++ b/meta/classes-global/package.bbclass
@@ -468,8 +468,7 @@ PACKAGEFUNCS += " \
                 package_do_shlibs \
                 package_do_pkgconfig \
                 read_shlibdeps \
-                package_depchains \
-                emit_pkgdata"
+                package_depchains"
 
 python do_package () {
     # Change the following version to cause sstate to invalidate the package
@@ -561,9 +560,13 @@ python do_package () {
             for file in files:
                 pkgfiles[pkg].append(walkroot + os.sep + file)
 
+
+    # We want emit_pkgdata to run last, after everything
     for f in (d.getVar('PACKAGEFUNCS') or '').split():
         bb.build.exec_func(f, d)
 
+    bb.build.exec_func("emit_pkgdata", d)
+
     oe.qa.exit_if_errors(d)
 }
 
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [scarthgap][PATCH] package.bbclass: fix execution order bug in emit_pkgdata
  2026-07-22 12:11 [scarthgap][PATCH] package.bbclass: fix execution order bug in emit_pkgdata AshishKumar Mishra
@ 2026-07-22 12:15 ` AshishKumar Mishra
  2026-07-22 12:20   ` [OE-core] " Yoann Congal
  0 siblings, 1 reply; 6+ messages in thread
From: AshishKumar Mishra @ 2026-07-22 12:15 UTC (permalink / raw)
  To: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

Hi Yoann ,

This is an bug fix patch which fixes the emit_pkgdata order
The same have been merged in master at https://git.openembedded.org/openembedded-core-contrib/commit/?h=ross/wip/nasm&id=aa85baff9ebdd3f932811c3b43d1918c38373cb9

Request to take this patch in scarthgap

Thanks ,
Ashish

[-- Attachment #2: Type: text/html, Size: 583 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [OE-core] [scarthgap][PATCH] package.bbclass: fix execution order bug in emit_pkgdata
  2026-07-22 12:15 ` AshishKumar Mishra
@ 2026-07-22 12:20   ` Yoann Congal
  2026-07-22 12:25     ` Ashish Mishra
  0 siblings, 1 reply; 6+ messages in thread
From: Yoann Congal @ 2026-07-22 12:20 UTC (permalink / raw)
  To: ashishkumar.mishra, openembedded-core

On Wed Jul 22, 2026 at 2:15 PM CEST, AshishKumar Mishra via lists.openembedded.org wrote:
> Hi Yoann ,
>
> This is an bug fix patch which fixes the emit_pkgdata order
> The same have been merged in master at https://git.openembedded.org/openembedded-core-contrib/commit/?h=ross/wip/nasm&id=aa85baff9ebdd3f932811c3b43d1918c38373cb9
>
> Request to take this patch in scarthgap

Hello,

This also need backporting to wrynose, right?
If that's the case, please send a cherry-pick request (if trivial) or a
backported patch.

Thanks!
-- 
Yoann Congal
Smile ECS



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [OE-core] [scarthgap][PATCH] package.bbclass: fix execution order bug in emit_pkgdata
  2026-07-22 12:20   ` [OE-core] " Yoann Congal
@ 2026-07-22 12:25     ` Ashish Mishra
  2026-07-22 12:32       ` Yoann Congal
  0 siblings, 1 reply; 6+ messages in thread
From: Ashish Mishra @ 2026-07-22 12:25 UTC (permalink / raw)
  To: Yoann Congal; +Cc: AshishKumar Mishra, openembedded-core

[-- Attachment #1: Type: text/plain, Size: 1547 bytes --]

Hi Yoann ,

I tested on Scarthgap today and hence shared for it

Will create an patch for Wrynose and share after testing it once.

In meantime, can you please take this in consideration for Scarthgap?
Or as an process i should send Wrynose.

So accordingly from next patch onwards, will follow the same.

Thanks ,
Ashish


On Wed, Jul 22, 2026, 5:50 PM Yoann Congal via lists.openembedded.org
<yoann.congal=smile.fr@lists.openembedded.org> wrote:

> On Wed Jul 22, 2026 at 2:15 PM CEST, AshishKumar Mishra via
> lists.openembedded.org wrote:
> > Hi Yoann ,
> >
> > This is an bug fix patch which fixes the emit_pkgdata order
> > The same have been merged in master at
> https://git.openembedded.org/openembedded-core-contrib/commit/?h=ross/wip/nasm&id=aa85baff9ebdd3f932811c3b43d1918c38373cb9
> >
> > Request to take this patch in scarthgap
>
> Hello,
>
> This also need backporting to wrynose, right?
> If that's the case, please send a cherry-pick request (if trivial) or a
> backported patch.
>
> Thanks!
> --
> Yoann Congal
> Smile ECS
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#241665):
> https://lists.openembedded.org/g/openembedded-core/message/241665
> Mute This Topic: https://lists.openembedded.org/mt/120392420/1334323
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> emailaddress.ashish@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

[-- Attachment #2: Type: text/html, Size: 3054 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [OE-core] [scarthgap][PATCH] package.bbclass: fix execution order bug in emit_pkgdata
  2026-07-22 12:25     ` Ashish Mishra
@ 2026-07-22 12:32       ` Yoann Congal
  2026-07-22 12:38         ` Ashish Mishra
  0 siblings, 1 reply; 6+ messages in thread
From: Yoann Congal @ 2026-07-22 12:32 UTC (permalink / raw)
  To: Ashish Mishra; +Cc: AshishKumar Mishra, openembedded-core

[-- Attachment #1: Type: text/plain, Size: 1937 bytes --]

Le mer. 22 juil. 2026 à 14:25, Ashish Mishra <emailaddress.ashish@gmail.com>
a écrit :

> Hi Yoann ,
>
> I tested on Scarthgap today and hence shared for it
>
> Will create an patch for Wrynose and share after testing it once.
>
> In meantime, can you please take this in consideration for Scarthgap?
> Or as an process i should send Wrynose.
>
> So accordingly from next patch onwards, will follow the same.
>

As a policy, I can't accept a patch for scarthgap if it does not have a
wrynose equivalent.
So yes, you should send the wrynose patch. Then, I'll consider this one for
scarthgap.

Regards,


>
> Thanks ,
> Ashish
>
>
> On Wed, Jul 22, 2026, 5:50 PM Yoann Congal via lists.openembedded.org
> <yoann.congal=smile.fr@lists.openembedded.org> wrote:
>
>> On Wed Jul 22, 2026 at 2:15 PM CEST, AshishKumar Mishra via
>> lists.openembedded.org wrote:
>> > Hi Yoann ,
>> >
>> > This is an bug fix patch which fixes the emit_pkgdata order
>> > The same have been merged in master at
>> https://git.openembedded.org/openembedded-core-contrib/commit/?h=ross/wip/nasm&id=aa85baff9ebdd3f932811c3b43d1918c38373cb9
>> >
>> > Request to take this patch in scarthgap
>>
>> Hello,
>>
>> This also need backporting to wrynose, right?
>> If that's the case, please send a cherry-pick request (if trivial) or a
>> backported patch.
>>
>> Thanks!
>> --
>> Yoann Congal
>> Smile ECS
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#241665):
>> https://lists.openembedded.org/g/openembedded-core/message/241665
>> Mute This Topic: https://lists.openembedded.org/mt/120392420/1334323
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
>> emailaddress.ashish@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
>>

-- 
Yoann Congal
Smile ECS

[-- Attachment #2: Type: text/html, Size: 4186 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [OE-core] [scarthgap][PATCH] package.bbclass: fix execution order bug in emit_pkgdata
  2026-07-22 12:32       ` Yoann Congal
@ 2026-07-22 12:38         ` Ashish Mishra
  0 siblings, 0 replies; 6+ messages in thread
From: Ashish Mishra @ 2026-07-22 12:38 UTC (permalink / raw)
  To: Yoann Congal; +Cc: AshishKumar Mishra, openembedded-core

[-- Attachment #1: Type: text/plain, Size: 2210 bytes --]

Ok , will work on Wrynose.

Thanks for sharing the details , will take care of this process going ahead



On Wed, Jul 22, 2026, 6:02 PM Yoann Congal <yoann.congal@smile.fr> wrote:

> Le mer. 22 juil. 2026 à 14:25, Ashish Mishra <
> emailaddress.ashish@gmail.com> a écrit :
>
>> Hi Yoann ,
>>
>> I tested on Scarthgap today and hence shared for it
>>
>> Will create an patch for Wrynose and share after testing it once.
>>
>> In meantime, can you please take this in consideration for Scarthgap?
>> Or as an process i should send Wrynose.
>>
>> So accordingly from next patch onwards, will follow the same.
>>
>
> As a policy, I can't accept a patch for scarthgap if it does not have a
> wrynose equivalent.
> So yes, you should send the wrynose patch. Then, I'll consider this one
> for scarthgap.
>
> Regards,
>
>
>>
>> Thanks ,
>> Ashish
>>
>>
>> On Wed, Jul 22, 2026, 5:50 PM Yoann Congal via lists.openembedded.org
>> <yoann.congal=smile.fr@lists.openembedded.org> wrote:
>>
>>> On Wed Jul 22, 2026 at 2:15 PM CEST, AshishKumar Mishra via
>>> lists.openembedded.org wrote:
>>> > Hi Yoann ,
>>> >
>>> > This is an bug fix patch which fixes the emit_pkgdata order
>>> > The same have been merged in master at
>>> https://git.openembedded.org/openembedded-core-contrib/commit/?h=ross/wip/nasm&id=aa85baff9ebdd3f932811c3b43d1918c38373cb9
>>> >
>>> > Request to take this patch in scarthgap
>>>
>>> Hello,
>>>
>>> This also need backporting to wrynose, right?
>>> If that's the case, please send a cherry-pick request (if trivial) or a
>>> backported patch.
>>>
>>> Thanks!
>>> --
>>> Yoann Congal
>>> Smile ECS
>>>
>>>
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>> Links: You receive all messages sent to this group.
>>> View/Reply Online (#241665):
>>> https://lists.openembedded.org/g/openembedded-core/message/241665
>>> Mute This Topic: https://lists.openembedded.org/mt/120392420/1334323
>>> Group Owner: openembedded-core+owner@lists.openembedded.org
>>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
>>> emailaddress.ashish@gmail.com]
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>>
>>>
>
> --
> Yoann Congal
> Smile ECS
>

[-- Attachment #2: Type: text/html, Size: 4874 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-07-22 12:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-22 12:11 [scarthgap][PATCH] package.bbclass: fix execution order bug in emit_pkgdata AshishKumar Mishra
2026-07-22 12:15 ` AshishKumar Mishra
2026-07-22 12:20   ` [OE-core] " Yoann Congal
2026-07-22 12:25     ` Ashish Mishra
2026-07-22 12:32       ` Yoann Congal
2026-07-22 12:38         ` Ashish Mishra

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.