[PATCH v3 0/5] selftests: gitignore and clean target file additions

[PATCH v3 0/5] selftests: gitignore and clean target file additions

[Javier Carrasco]

Trivial patches to update the gitignore files unders selftests, and a
little addition to EXTRA_CLEAN under net/rds to account for the
automatically generated include.sh.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
Changes in v3:
- Split new entries in core and net gitignore files into two patches.
- Link to v2: https://lore.kernel.org/r/20240925-selftests-gitignore-v2-0-bbbbdef21959@gmail.com

Changes in v2:
- [PATCH 4/4] add excepction for load_address.c (must be tracked).
- Link to v1: https://lore.kernel.org/r/20240924-selftests-gitignore-v1-0-9755ac883388@gmail.com

---
Javier Carrasco (5):
      selftests: core: add unshare_test to gitignore
      selftests: net: add msg_oob to gitignore
      selftests: rds: add include.sh to EXTRA_CLEAN
      selftests: rds: add gitignore file for include.sh
      selftests: exec: update gitignore for load_address

 tools/testing/selftests/core/.gitignore    | 1 +
 tools/testing/selftests/exec/.gitignore    | 3 ++-
 tools/testing/selftests/net/.gitignore     | 1 +
 tools/testing/selftests/net/rds/.gitignore | 1 +
 tools/testing/selftests/net/rds/Makefile   | 2 +-
 5 files changed, 6 insertions(+), 2 deletions(-)
---
base-commit: 4d0326b60bb753627437fff0f76bf1525bcda422
change-id: 20240924-selftests-gitignore-e41133e6c5bd

Best regards,
-- 
Javier Carrasco <javier.carrasco.cruz@gmail.com>

[PATCH v3 1/5] selftests: core: add unshare_test to gitignore

[Javier Carrasco]

This executable is missing from the corresponding gitignore file.
Add unshare_test to the core gitignore list.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 tools/testing/selftests/core/.gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/core/.gitignore b/tools/testing/selftests/core/.gitignore
index 6e6712ce5817..7999361992aa 100644
--- a/tools/testing/selftests/core/.gitignore
+++ b/tools/testing/selftests/core/.gitignore
@@ -1 +1,2 @@
 close_range_test
+unshare_test

-- 
2.43.0

[PATCH v3 2/5] selftests: net: add msg_oob to gitignore

[Javier Carrasco]

This executable is missing from the corresponding gitignore file.
Add msg_oob to the net gitignore list.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 tools/testing/selftests/net/.gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/net/.gitignore b/tools/testing/selftests/net/.gitignore
index 1c04c780db66..9dcdff533414 100644
--- a/tools/testing/selftests/net/.gitignore
+++ b/tools/testing/selftests/net/.gitignore
@@ -17,6 +17,7 @@ ipv6_flowlabel
 ipv6_flowlabel_mgr
 log.txt
 msg_zerocopy
+msg_oob
 ncdevmem
 nettest
 psock_fanout

-- 
2.43.0

[PATCH v3 3/5] selftests: rds: add include.sh to EXTRA_CLEAN

[Javier Carrasco]

The include.sh file is generated when building the net/rds selftests,
but there is no rule to delete it with the clean target. Add the file to
EXTRA_CLEAN in order to remove it when required.

Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 tools/testing/selftests/net/rds/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/rds/Makefile b/tools/testing/selftests/net/rds/Makefile
index da9714bc7aad..0b697669ea51 100644
--- a/tools/testing/selftests/net/rds/Makefile
+++ b/tools/testing/selftests/net/rds/Makefile
@@ -7,6 +7,6 @@ TEST_PROGS := run.sh \
 	include.sh \
 	test.py
 
-EXTRA_CLEAN := /tmp/rds_logs
+EXTRA_CLEAN := /tmp/rds_logs include.sh
 
 include ../../lib.mk

-- 
2.43.0

[PATCH v3 4/5] selftests: rds: add gitignore file for include.sh

[Javier Carrasco]

The generated include.sh should be ignored by git. Create a new
gitignore and add the file to the list.

Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 tools/testing/selftests/net/rds/.gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/net/rds/.gitignore b/tools/testing/selftests/net/rds/.gitignore
new file mode 100644
index 000000000000..1c6f04e2aa11
--- /dev/null
+++ b/tools/testing/selftests/net/rds/.gitignore
@@ -0,0 +1 @@
+include.sh

-- 
2.43.0

[PATCH v3 5/5] selftests: exec: update gitignore for load_address

[Javier Carrasco]

The name of the "load_address" objects has been modified, but the
corresponding entry in the gitignore file must be updated.

Update the load_address entry in the gitignore file to account for
the new names, adding an exception to keep on tracking load_address.c.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 tools/testing/selftests/exec/.gitignore | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/exec/.gitignore b/tools/testing/selftests/exec/.gitignore
index 90c238ba6a4b..a0dc5d4bf733 100644
--- a/tools/testing/selftests/exec/.gitignore
+++ b/tools/testing/selftests/exec/.gitignore
@@ -9,7 +9,8 @@ execveat.ephemeral
 execveat.denatured
 non-regular
 null-argv
-/load_address_*
+/load_address.*
+!load_address.c
 /recursion-depth
 xxxxxxxx*
 pipe

-- 
2.43.0

Re: [PATCH v3 0/5] selftests: gitignore and clean target file additions

[Javier Carrasco]

On 25/09/2024 23:55, Javier Carrasco wrote:
> Trivial patches to update the gitignore files unders selftests, and a
> little addition to EXTRA_CLEAN under net/rds to account for the
> automatically generated include.sh.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---
> Changes in v3:
> - Split new entries in core and net gitignore files into two patches.
> - Link to v2: https://lore.kernel.org/r/20240925-selftests-gitignore-v2-0-bbbbdef21959@gmail.com
> 
> Changes in v2:
> - [PATCH 4/4] add excepction for load_address.c (must be tracked).
> - Link to v1: https://lore.kernel.org/r/20240924-selftests-gitignore-v1-0-9755ac883388@gmail.com
> 
> ---
> Javier Carrasco (5):
>       selftests: core: add unshare_test to gitignore
>       selftests: net: add msg_oob to gitignore
>       selftests: rds: add include.sh to EXTRA_CLEAN
>       selftests: rds: add gitignore file for include.sh
>       selftests: exec: update gitignore for load_address
> 
>  tools/testing/selftests/core/.gitignore    | 1 +
>  tools/testing/selftests/exec/.gitignore    | 3 ++-
>  tools/testing/selftests/net/.gitignore     | 1 +
>  tools/testing/selftests/net/rds/.gitignore | 1 +
>  tools/testing/selftests/net/rds/Makefile   | 2 +-
>  5 files changed, 6 insertions(+), 2 deletions(-)
> ---
> base-commit: 4d0326b60bb753627437fff0f76bf1525bcda422
> change-id: 20240924-selftests-gitignore-e41133e6c5bd
> 
> Best regards,

I sent the net-related patches in a separate series:

- [PATCH v3 2/5] selftests: net: add msg_oob to gitignore
- [PATCH v3 3/5] selftests: rds: add include.sh to EXTRA_CLEAN
- [PATCH v3 4/5] selftests: rds: add gitignore file for include.sh

The rest of the patches belong to selftests too, and can be applied from
this series:

- [PATCH v3 1/5] selftests: core: add unshare_test to gitignore
- [PATCH v3 5/5] selftests: exec: update gitignore for load_address

Thanks and best regards,
Javier Carrasco

Re: [PATCH v3 1/5] selftests: core: add unshare_test to gitignore

[Shuah Khan]

On 9/25/24 15:55, Javier Carrasco wrote:
> This executable is missing from the corresponding gitignore file.
> Add unshare_test to the core gitignore list.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---
>   tools/testing/selftests/core/.gitignore | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/core/.gitignore b/tools/testing/selftests/core/.gitignore
> index 6e6712ce5817..7999361992aa 100644
> --- a/tools/testing/selftests/core/.gitignore
> +++ b/tools/testing/selftests/core/.gitignore
> @@ -1 +1,2 @@
>   close_range_test
> +unshare_test
> 

Applied to linux-kselftest fixes for next rc.

thanks,
-- Shuah

Re: [PATCH v3 5/5] selftests: exec: update gitignore for load_address

[Shuah Khan]

On 9/25/24 15:55, Javier Carrasco wrote:
> The name of the "load_address" objects has been modified, but the
> corresponding entry in the gitignore file must be updated.
> 
> Update the load_address entry in the gitignore file to account for
> the new names, adding an exception to keep on tracking load_address.c.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---
>   tools/testing/selftests/exec/.gitignore | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/exec/.gitignore b/tools/testing/selftests/exec/.gitignore
> index 90c238ba6a4b..a0dc5d4bf733 100644
> --- a/tools/testing/selftests/exec/.gitignore
> +++ b/tools/testing/selftests/exec/.gitignore
> @@ -9,7 +9,8 @@ execveat.ephemeral
>   execveat.denatured
>   non-regular
>   null-argv
> -/load_address_*
> +/load_address.*
> +!load_address.c
>   /recursion-depth
>   xxxxxxxx*
>   pipe
> 

Applied to linux-kselftest fixes for next rc.

thanks,
-- Shuah