Re: [oe-commits] org.oe.dev packages/glib-2.0/glib.inc : remove bogus ${PN}-dev from packages.

Re: [oe-commits] org.oe.dev packages/glib-2.0/glib.inc : remove bogus ${PN}-dev from packages.

[Paul Sokolovsky]

Hello xora,

Tuesday, July 10, 2007, 11:47:15 AM, you wrote:

> packages/glib-2.0/glib.inc : remove bogus ${PN}-dev from packages.

> Author: xora@openembedded.org
> Branch: org.openembedded.dev
> Revision: 2f67b52cb2be4988db873678ab4f354aea217a90
[]
> ============================================================
> --- packages/glib-2.0/glib.inc 
> 09c2d1615f7c249f8ab1c68778bafbc98293ff6b
> +++ packages/glib-2.0/glib.inc 
> 3b5260371e84b9c12db9a8cdc8c5809bab8d2ec5
> @@ -8,7 +8,7 @@ DEPENDS += "virtual/libiconv virtual/lib
>  PRIORITY = "optional"
>  DEPENDS += "glib-2.0-native gtk-doc"
>  DEPENDS += "virtual/libiconv virtual/libintl"
> -PACKAGES =+ "${PN}-dev glib-2.0-utils "
> +PACKAGES =+ " glib-2.0-utils "

  This is not bogus. For this package, -dev must be packaged before
the main package, or the latter will get *.h and *.m4 files. Putting
something in packages twice works after all, and we should either
accept its usage fro such cases, or find other solution to do proper
flexible packaging (and that would be a bit hard on syntax. Maybe add
UNFILES?)




-- 
Best regards,
 Paul                            mailto:pmiscml@gmail.com

Re: [oe-commits] org.oe.dev packages/glib-2.0/glib.inc : remove bogus ${PN}-dev from packages.

[Graeme Gregory]

On Tue, Jul 10, 2007 at 12:54:40PM +0300, Paul Sokolovsky wrote:
> > --- packages/glib-2.0/glib.inc 
> > 09c2d1615f7c249f8ab1c68778bafbc98293ff6b
> > +++ packages/glib-2.0/glib.inc 
> > 3b5260371e84b9c12db9a8cdc8c5809bab8d2ec5
> > @@ -8,7 +8,7 @@ DEPENDS += "virtual/libiconv virtual/lib
> >  PRIORITY = "optional"
> >  DEPENDS += "glib-2.0-native gtk-doc"
> >  DEPENDS += "virtual/libiconv virtual/libintl"
> > -PACKAGES =+ "${PN}-dev glib-2.0-utils "
> > +PACKAGES =+ " glib-2.0-utils "
> 
>   This is not bogus. For this package, -dev must be packaged before
> the main package, or the latter will get *.h and *.m4 files. Putting
> something in packages twice works after all, and we should either
> accept its usage fro such cases, or find other solution to do proper
> flexible packaging (and that would be a bit hard on syntax. Maybe add
> UNFILES?)
> 
It works, you just get a 5 line error from bitbake.

ERROR: -------------------
ERROR: glib-2.0-dev is listed in PACKAGES mutliple times, this leads to packaging errors.
ERROR: Please fix the metadata/report this as bug to OE bugtracker.
ERROR: -------------------

This means the change is wrong (tm) or bitbake is wrong (tm) but the initial
submitter should have fixed one or other or at least left a not in the commit
telling people what was going on. None of this was done.

As it was I accepted the instruction given by bitbake and fixed the metadata.

Graeme

Re: [oe-commits] org.oe.dev packages/glib-2.0/glib.inc : remove bogus ${PN}-dev from packages.

[Marcin Juszkiewicz]

Dnia wtorek, 10 lipca 2007, Paul Sokolovsky napisał:
> Hello xora,
> > packages/glib-2.0/glib.inc : remove bogus ${PN}-dev from packages.

> > -PACKAGES =+ "${PN}-dev glib-2.0-utils "
> > +PACKAGES =+ " glib-2.0-utils "

>   This is not bogus. For this package, -dev must be packaged before
> the main package, or the latter will get *.h and *.m4 files. 

fix FILES_${PN} then

> Putting something in packages twice works after all, and we should
> either accept its usage fro such cases,

-1 from me - we should not allow such things as they can hide bugs

> or find other solution to do proper flexible packaging (and that would
> be a bit hard on syntax.  

FILES adapting was fast job - I am testing fix in Poky now.

-- 
JID: hrw-jabber.org
OpenEmbedded developer/consultant

   Gdyby człowiek musiał zezwalać innym na to, co toleruje u siebie,
   życie byłoby nie do wytrzymania.             [Georges Courteline]

Re: [oe-commits] org.oe.dev packages/glib-2.0/glib.inc : remove bogus ${PN}-dev from packages.

[Richard Purdie]

On Tue, 2007-07-10 at 12:36 +0200, Marcin Juszkiewicz wrote:
> Dnia wtorek, 10 lipca 2007, Paul Sokolovsky napisał:
> > Hello xora,
> > > packages/glib-2.0/glib.inc : remove bogus ${PN}-dev from packages.
> 
> > > -PACKAGES =+ "${PN}-dev glib-2.0-utils "
> > > +PACKAGES =+ " glib-2.0-utils "
> 
> >   This is not bogus. For this package, -dev must be packaged before
> > the main package, or the latter will get *.h and *.m4 files. 
> 
> fix FILES_${PN} then
> 
> > Putting something in packages twice works after all, and we should
> > either accept its usage fro such cases,
> 
> -1 from me - we should not allow such things as they can hide bugs
> 
> > or find other solution to do proper flexible packaging (and that would
> > be a bit hard on syntax.  
> 
> FILES adapting was fast job - I am testing fix in Poky now.

Duplicate entries in PACKAGES cause all kinds of subtle problems as per
the error message. Please don't do it and set FILES correctly.

Cheers,

Richard

Re: [oe-commits] org.oe.dev packages/glib-2.0/glib.inc : remove bogus ${PN}-dev from packages.

[Justin Patrin]

On 7/10/07, Richard Purdie <rpurdie@rpsys.net> wrote:
> On Tue, 2007-07-10 at 12:36 +0200, Marcin Juszkiewicz wrote:
> > Dnia wtorek, 10 lipca 2007, Paul Sokolovsky napisał:
> > > Hello xora,
> > > > packages/glib-2.0/glib.inc : remove bogus ${PN}-dev from packages.
> >
> > > > -PACKAGES =+ "${PN}-dev glib-2.0-utils "
> > > > +PACKAGES =+ " glib-2.0-utils "
> >
> > >   This is not bogus. For this package, -dev must be packaged before
> > > the main package, or the latter will get *.h and *.m4 files.
> >
> > fix FILES_${PN} then
> >
> > > Putting something in packages twice works after all, and we should
> > > either accept its usage fro such cases,
> >
> > -1 from me - we should not allow such things as they can hide bugs
> >
> > > or find other solution to do proper flexible packaging (and that would
> > > be a bit hard on syntax.
> >
> > FILES adapting was fast job - I am testing fix in Poky now.
>
> Duplicate entries in PACKAGES cause all kinds of subtle problems as per
> the error message. Please don't do it and set FILES correctly.
>

There's no reason it should. If the first is used and any further ones
are ignored it works fine. I submitted a patch for this a long, long
time ago.

If you don't want to allow duplicate packages then the only way to get
around this is to do PACKAGES = instead of += to put things in the
right order. (Or "fix" FILES but which is the grossest hack? It could
be either....)


-- 
Justin Patrin