[PATCH] drm/i915/selftests: Touch the NMI watchdog inside a GTT pass

[PATCH] drm/i915/selftests: Touch the NMI watchdog inside a GTT pass

[Chris Wilson]

We want to do a complete pass before checking the timeout, but just in
case the pass is quite slow, touch the NMI watchdog to prevent a
false positive.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
index eefcf7b84054..71c0654b4b4d 100644
--- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
@@ -23,6 +23,7 @@
  */
 
 #include <linux/list_sort.h>
+#include <linux/nmi.h>
 #include <linux/prime_numbers.h>
 
 #include "../i915_selftest.h"
@@ -686,6 +687,13 @@ static int pot_hole(struct drm_i915_private *i915,
 			i915_vma_unpin(vma);
 			err = i915_vma_unbind(vma);
 			GEM_BUG_ON(err);
+
+			/*
+			 * Do a complete pass before timing out, but just
+			 * in case we are running too slow, ping the NMI
+			 * watchdog.
+			 */
+			touch_nmi_watchdog();
 		}
 
 		if (igt_timeout(end_time,
-- 
2.18.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/selftests: Touch the NMI watchdog inside a GTT pass

[Tvrtko Ursulin]

On 03/07/2018 11:25, Chris Wilson wrote:
> We want to do a complete pass before checking the timeout, but just in
> case the pass is quite slow, touch the NMI watchdog to prevent a
> false positive.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>   drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
> index eefcf7b84054..71c0654b4b4d 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
> @@ -23,6 +23,7 @@
>    */
>   
>   #include <linux/list_sort.h>
> +#include <linux/nmi.h>
>   #include <linux/prime_numbers.h>
>   
>   #include "../i915_selftest.h"
> @@ -686,6 +687,13 @@ static int pot_hole(struct drm_i915_private *i915,
>   			i915_vma_unpin(vma);
>   			err = i915_vma_unbind(vma);
>   			GEM_BUG_ON(err);
> +
> +			/*
> +			 * Do a complete pass before timing out, but just
> +			 * in case we are running too slow, ping the NMI
> +			 * watchdog.
> +			 */
> +			touch_nmi_watchdog();
>   		}
>   
>   		if (igt_timeout(end_time,
> 

Why only in pot_hole, is this the slowest test?

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/selftests: Touch the NMI watchdog inside a GTT pass

[Chris Wilson]

Quoting Tvrtko Ursulin (2018-07-03 12:00:13)
> 
> On 03/07/2018 11:25, Chris Wilson wrote:
> > We want to do a complete pass before checking the timeout, but just in
> > case the pass is quite slow, touch the NMI watchdog to prevent a
> > false positive.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > ---
> >   drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 8 ++++++++
> >   1 file changed, 8 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
> > index eefcf7b84054..71c0654b4b4d 100644
> > --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
> > +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
> > @@ -23,6 +23,7 @@
> >    */
> >   
> >   #include <linux/list_sort.h>
> > +#include <linux/nmi.h>
> >   #include <linux/prime_numbers.h>
> >   
> >   #include "../i915_selftest.h"
> > @@ -686,6 +687,13 @@ static int pot_hole(struct drm_i915_private *i915,
> >                       i915_vma_unpin(vma);
> >                       err = i915_vma_unbind(vma);
> >                       GEM_BUG_ON(err);
> > +
> > +                     /*
> > +                      * Do a complete pass before timing out, but just
> > +                      * in case we are running too slow, ping the NMI
> > +                      * watchdog.
> > +                      */
> > +                     touch_nmi_watchdog();
> >               }
> >   
> >               if (igt_timeout(end_time,
> > 
> 
> Why only in pot_hole, is this the slowest test?

It's the only test of this style where we don't have the igt_timeout
(cond_resched) inside the innermost loop.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915/selftests: Touch the NMI watchdog inside a GTT pass

[Patchwork]

== Series Details ==

Series: drm/i915/selftests: Touch the NMI watchdog inside a GTT pass
URL   : https://patchwork.freedesktop.org/series/45823/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4421 -> Patchwork_9508 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/45823/revisions/1/mbox/

== Known issues ==

  Here are the changes found in Patchwork_9508 that come from known issues:

  === IGT changes ===

    ==== Possible fixes ====

    igt@drv_module_reload@basic-reload-inject:
      fi-skl-guc:         DMESG-FAIL (fdo#106685) -> PASS

    
  fdo#106685 https://bugs.freedesktop.org/show_bug.cgi?id=106685


== Participating hosts (46 -> 40) ==

  Missing    (6): fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 


== Build changes ==

    * Linux: CI_DRM_4421 -> Patchwork_9508

  CI_DRM_4421: 91ca31bcf59d078fbddb0ac8d8e206dfd77a3d3e @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4533: 199220052af977598033d3810ffb4cc32d377522 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9508: 7417f9612e944b21d5179d7aa8fc34706f71931d @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

7417f9612e94 drm/i915/selftests: Touch the NMI watchdog inside a GTT pass

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9508/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/selftests: Touch the NMI watchdog inside a GTT pass

[Tvrtko Ursulin]

On 03/07/2018 12:07, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2018-07-03 12:00:13)
>>
>> On 03/07/2018 11:25, Chris Wilson wrote:
>>> We want to do a complete pass before checking the timeout, but just in
>>> case the pass is quite slow, touch the NMI watchdog to prevent a
>>> false positive.
>>>
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>> ---
>>>    drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 8 ++++++++
>>>    1 file changed, 8 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
>>> index eefcf7b84054..71c0654b4b4d 100644
>>> --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
>>> +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
>>> @@ -23,6 +23,7 @@
>>>     */
>>>    
>>>    #include <linux/list_sort.h>
>>> +#include <linux/nmi.h>
>>>    #include <linux/prime_numbers.h>
>>>    
>>>    #include "../i915_selftest.h"
>>> @@ -686,6 +687,13 @@ static int pot_hole(struct drm_i915_private *i915,
>>>                        i915_vma_unpin(vma);
>>>                        err = i915_vma_unbind(vma);
>>>                        GEM_BUG_ON(err);
>>> +
>>> +                     /*
>>> +                      * Do a complete pass before timing out, but just
>>> +                      * in case we are running too slow, ping the NMI
>>> +                      * watchdog.
>>> +                      */
>>> +                     touch_nmi_watchdog();
>>>                }
>>>    
>>>                if (igt_timeout(end_time,
>>>
>>
>> Why only in pot_hole, is this the slowest test?
> 
> It's the only test of this style where we don't have the igt_timeout
> (cond_resched) inside the innermost loop.

So.. the obvious question.. :) Why not move igt_timeout to the innermost 
loop and avoid low-level hackery?

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/selftests: Touch the NMI watchdog inside a GTT pass

[Chris Wilson]

Quoting Tvrtko Ursulin (2018-07-03 13:54:01)
> 
> On 03/07/2018 12:07, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2018-07-03 12:00:13)
> >>
> >> On 03/07/2018 11:25, Chris Wilson wrote:
> >>> We want to do a complete pass before checking the timeout, but just in
> >>> case the pass is quite slow, touch the NMI watchdog to prevent a
> >>> false positive.
> >>>
> >>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >>> ---
> >>>    drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 8 ++++++++
> >>>    1 file changed, 8 insertions(+)
> >>>
> >>> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
> >>> index eefcf7b84054..71c0654b4b4d 100644
> >>> --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
> >>> +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
> >>> @@ -23,6 +23,7 @@
> >>>     */
> >>>    
> >>>    #include <linux/list_sort.h>
> >>> +#include <linux/nmi.h>
> >>>    #include <linux/prime_numbers.h>
> >>>    
> >>>    #include "../i915_selftest.h"
> >>> @@ -686,6 +687,13 @@ static int pot_hole(struct drm_i915_private *i915,
> >>>                        i915_vma_unpin(vma);
> >>>                        err = i915_vma_unbind(vma);
> >>>                        GEM_BUG_ON(err);
> >>> +
> >>> +                     /*
> >>> +                      * Do a complete pass before timing out, but just
> >>> +                      * in case we are running too slow, ping the NMI
> >>> +                      * watchdog.
> >>> +                      */
> >>> +                     touch_nmi_watchdog();
> >>>                }
> >>>    
> >>>                if (igt_timeout(end_time,
> >>>
> >>
> >> Why only in pot_hole, is this the slowest test?
> > 
> > It's the only test of this style where we don't have the igt_timeout
> > (cond_resched) inside the innermost loop.
> 
> So.. the obvious question.. :) Why not move igt_timeout to the innermost 
> loop and avoid low-level hackery?

In looking at it, I felt this case it was more interesting^W important to
test each boundary before checking the timeout. I was concerned about
declaring the pass a success too early.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.IGT: success for drm/i915/selftests: Touch the NMI watchdog inside a GTT pass

[Patchwork]

== Series Details ==

Series: drm/i915/selftests: Touch the NMI watchdog inside a GTT pass
URL   : https://patchwork.freedesktop.org/series/45823/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4421_full -> Patchwork_9508_full =

== Summary - WARNING ==

  Minor unknown changes coming with Patchwork_9508_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_9508_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_9508_full:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_exec_schedule@deep-blt:
      shard-kbl:          SKIP -> PASS

    igt@gem_exec_schedule@deep-bsd1:
      shard-kbl:          PASS -> SKIP +1

    
== Known issues ==

  Here are the changes found in Patchwork_9508_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_gtt:
      shard-kbl:          PASS -> FAIL (fdo#105347)

    igt@drv_suspend@shrink:
      shard-snb:          PASS -> FAIL (fdo#106886)

    igt@kms_flip@flip-vs-expired-vblank:
      shard-glk:          PASS -> FAIL (fdo#102887)

    igt@kms_flip_tiling@flip-to-x-tiled:
      shard-glk:          PASS -> FAIL (fdo#104724)

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    igt@kms_flip@2x-modeset-vs-vblank-race:
      shard-glk:          FAIL (fdo#103060) -> PASS

    igt@kms_flip@2x-plain-flip-ts-check:
      shard-glk:          FAIL (fdo#100368) -> PASS

    igt@kms_setmode@basic:
      shard-kbl:          FAIL (fdo#99912) -> PASS

    igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
      shard-kbl:          INCOMPLETE (fdo#103665) -> PASS

    
    ==== Warnings ====

    igt@drv_selftest@live_gtt:
      shard-glk:          FAIL (fdo#105347) -> INCOMPLETE (k.org#198133, fdo#103359)

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
  fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
  fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * Linux: CI_DRM_4421 -> Patchwork_9508

  CI_DRM_4421: 91ca31bcf59d078fbddb0ac8d8e206dfd77a3d3e @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4533: 199220052af977598033d3810ffb4cc32d377522 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9508: 7417f9612e944b21d5179d7aa8fc34706f71931d @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9508/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx