From: Matthieu Baerts <matttbe@kernel.org>
To: Mat Martineau <martineau@kernel.org>
Cc: MPTCP Linux <mptcp@lists.linux.dev>
Subject: Re: [PATCH mptcp-net 0/2] mptcp: options: avoid printing uninit data
Date: Fri, 9 Oct 2026 12:31:18 +0200 [thread overview]
Message-ID: <98ff7eb0-a0d2-46ff-b689-4708a0cd7fe8@kernel.org> (raw)
In-Reply-To: <d4f8a020-8cce-d760-4625-adafb26d9ede@kernel.org>
Hi Mat,
On 09/09/2026 17:51, Mat Martineau wrote:
> On Tue, 8 Sep 2026, Matthieu Baerts (NGI0) wrote:
>
>> When parsing the MPTCP suboptions, some pr_debug() might read and print
>> uninit values.
>>
>> That's mostly harmless, but that's also confusing. Fixing that also
>> avoids some tools to complain about accessing unint data.
>>
>> So read these fields only if they have been set.
(...)
> Thanks Matthieu, series LGTM:
Thank you for the review! I'm lagging so much I even slow at applying my
own patches :)
New patches for t/upstream-net and t/upstream:
- e83426516ebe: mptcp: options: mpc: avoid printing uninit data
- 55dcf92c5ff9: mptcp: options: dss: avoid printing uninit csum
- Results: 7e92f912c44e..77cb3db4e666 (export-net)
- Results: 45035345367c..fbeaa40c1480 (export)
Tests are now in progress:
- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/984504faff7251d01755ff9d5077c95929788472/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/c320b1b2220752a879c853142d2ce128985a6012/checks
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2026-10-09 10:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 17:07 [PATCH mptcp-net 0/2] mptcp: options: avoid printing uninit data Matthieu Baerts (NGI0)
2026-09-08 17:07 ` [PATCH mptcp-net 1/2] mptcp: options: mpc: " Matthieu Baerts (NGI0)
2026-09-08 17:07 ` [PATCH mptcp-net 2/2] mptcp: options: dss: avoid printing uninit csum Matthieu Baerts (NGI0)
2026-09-08 18:00 ` [PATCH mptcp-net 0/2] mptcp: options: avoid printing uninit data MPTCP CI
2026-09-09 15:51 ` Mat Martineau
2026-10-09 10:31 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98ff7eb0-a0d2-46ff-b689-4708a0cd7fe8@kernel.org \
--to=matttbe@kernel.org \
--cc=martineau@kernel.org \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.