* [parisc-linux] Missing directories from CVS
@ 1999-09-23 3:13 Ryan Bradetich
1999-09-23 15:30 ` Grant Grundler
0 siblings, 1 reply; 6+ messages in thread
From: Ryan Bradetich @ 1999-09-23 3:13 UTC (permalink / raw)
To: Parisc Linux
Alex:
The following directories seem to be missing from the CVS repository:
drivers/isdn/eicon
drivers/isdn/divert
drivers/usb
fs/efs
net/irda
-Ryan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [parisc-linux] Missing directories from CVS
1999-09-23 3:13 [parisc-linux] Missing directories from CVS Ryan Bradetich
@ 1999-09-23 15:30 ` Grant Grundler
1999-09-23 16:59 ` Grant Grundler
0 siblings, 1 reply; 6+ messages in thread
From: Grant Grundler @ 1999-09-23 15:30 UTC (permalink / raw)
To: Ryan Bradetich; +Cc: Parisc Linux
Ryan Bradetich wrote:
> Alex:
>
> The following directories seem to be missing from the CVS repository:
>
> drivers/isdn/eicon
> drivers/isdn/divert
> drivers/usb
> fs/efs
> net/irda
Yeah...I complained to Alex about this yesterday already.
And guess what? He fixed it! (kudos!)
You should try again...
I did a checkout, make config (for 715), make dep.
(make vmlinux is still running)
gcc is used to build scripts/mkdep, scripts/split-include and bin2hex.
The only thing I'm missing is native "gcc". I don't have a native
"gcc" since I don't want to be confused about what's native and
what's cross-environment. So I built those items by hand with "cc".
Oh yeah...don't forget to ftp the ramdisk.bin if you start from
scratch like I did.
cheers,
grant
Grant Grundler
Communications Infrastructure Computer Operations
+1.408.447.7253
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [parisc-linux] Missing directories from CVS
1999-09-23 15:30 ` Grant Grundler
@ 1999-09-23 16:59 ` Grant Grundler
1999-09-23 18:58 ` LaMont Jones
0 siblings, 1 reply; 6+ messages in thread
From: Grant Grundler @ 1999-09-23 16:59 UTC (permalink / raw)
To: Parisc Linux
Grant Grundler wrote:
...
> I did a checkout, make config (for 715), make dep.
> (make vmlinux is still running)
vmlinux built shortly after I posted...
> gcc is used to build scripts/mkdep, scripts/split-include and bin2hex.
Add one more to the list: arch/parisc/boot/mkImage
And on this one "cc" gets picky about pointer math.
Here's my diff for mkImage.c:
118c118
< *entry_point = *(unsigned long*)(ptr + 6*sizeof(long));
---
> *entry_point = *(unsigned long*)((char *)ptr + 6*sizeof(long));
131,132c131,132
< short magic = *(short *)(ptr+sizeof(short));
< long *arr = (unsigned long *)ptr;
---
> short magic = *(short *)((char *)ptr+sizeof(short));
> long *arr = (long *)ptr;
Any objections to committing this change?
On second thought, both changes should be written as:
*entry_point = ((unsigned long *)ptr)[6];
and
short magic = ((short *)ptr)[1];
thanks,
grant
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [parisc-linux] Missing directories from CVS
1999-09-23 16:59 ` Grant Grundler
@ 1999-09-23 18:58 ` LaMont Jones
1999-09-24 8:13 ` Helge Deller
0 siblings, 1 reply; 6+ messages in thread
From: LaMont Jones @ 1999-09-23 18:58 UTC (permalink / raw)
To: Grant Grundler; +Cc: Parisc Linux, lamont
> And on this one "cc" gets picky about pointer math.
> Here's my diff for mkImage.c:
> < *entry_point = *(unsigned long*)(ptr + 6*sizeof(long));
> ---
> > *entry_point = *(unsigned long*)((char *)ptr + 6*sizeof(long));
OK, so I'm too lazy to go look... what type is ptr? I'd guess that
it's declared void*, since that's the only way the pointer math could
work in gcc and not in HP-cc.
> Any objections to committing this change?
> On second thought, both changes should be written as:
> *entry_point = ((unsigned long *)ptr)[6];
> and
> short magic = ((short *)ptr)[1];
How about just using filehdr.h, or copying struct header from it, and
using the real structure...? (I think we've released the format enough
that we could clone the structure, failing that:
struct header {
unsigned short magic;
short fill0;
long fill[5];
unsigned long entry_point;
};
will fit the bill quite nicely.
LaMont "I hate magic offsets" Jones
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [parisc-linux] Missing directories from CVS
1999-09-23 18:58 ` LaMont Jones
@ 1999-09-24 8:13 ` Helge Deller
1999-09-24 14:44 ` LaMont Jones
0 siblings, 1 reply; 6+ messages in thread
From: Helge Deller @ 1999-09-24 8:13 UTC (permalink / raw)
To: parisc-linux, LaMont Jones, Grant Grundler
Am Thu, 23 Sep 1999 schrieb LaMont Jones:
> > And on this one "cc" gets picky about pointer math.
> > Here's my diff for mkImage.c:
>
> > < *entry_point = *(unsigned long*)(ptr + 6*sizeof(long));
> > ---
> > > *entry_point = *(unsigned long*)((char *)ptr + 6*sizeof(long));
> OK, so I'm too lazy to go look... what type is ptr? I'd guess that
> it's declared void*, since that's the only way the pointer math could
> work in gcc and not in HP-cc.
Yes.
>
> > Any objections to committing this change?
> > On second thought, both changes should be written as:
> > *entry_point = ((unsigned long *)ptr)[6];
> > and
> > short magic = ((short *)ptr)[1];
> How about just using filehdr.h, or copying struct header from it, and
> using the real structure...? (I think we've released the format enough
> that we could clone the structure, failing that:
>
> struct header {
> unsigned short magic;
> short fill0;
> long fill[5];
> unsigned long entry_point;
> };
> will fit the bill quite nicely.
Yes, I think this would be the best solution. When I wrote the program, I tried
to include the header-files som.h and elf.h, but then I always got
different errors from every of the arch-compilers (iA32 or hpux). So maybe it
is best to use the structure as above and write the structure-layout directly
into the source.
Does someone want to fill it in and commit it ?
>
> LaMont "I hate magic offsets" Jones
Helge "master of bad pointer arithmetic" Deller :-)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [parisc-linux] Missing directories from CVS
1999-09-24 8:13 ` Helge Deller
@ 1999-09-24 14:44 ` LaMont Jones
0 siblings, 0 replies; 6+ messages in thread
From: LaMont Jones @ 1999-09-24 14:44 UTC (permalink / raw)
To: Helge Deller; +Cc: parisc-linux, LaMont Jones, Grant Grundler, lamont
> Yes, I think this would be the best solution. When I wrote the program, I tri
> to include the header-files som.h and elf.h, but then I always got
> different errors from every of the arch-compilers (iA32 or hpux). So maybe i
> is best to use the structure as above and write the structure-layout directly
> into the source.
> Does someone want to fill it in and commit it ?
I'm already working with Grant on doing just that, but it'll probably be this
weekend at the earliest...
lamont
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~1999-09-24 14:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
1999-09-23 3:13 [parisc-linux] Missing directories from CVS Ryan Bradetich
1999-09-23 15:30 ` Grant Grundler
1999-09-23 16:59 ` Grant Grundler
1999-09-23 18:58 ` LaMont Jones
1999-09-24 8:13 ` Helge Deller
1999-09-24 14:44 ` LaMont Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.