From: Madars Vitolins <m@silodev.com>
To: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Cc: Jason Baron <jbaron-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org>,
torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
viro-rfM+Q5joDG/XmaaqVzeoHQ@public.gmane.org,
normalperson-rMlxZR9MS24@public.gmane.org,
corbet-T1hC0tSOHrs@public.gmane.org,
luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org,
hagen-GvnIQ6b/HdU@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] epoll: restrict EPOLLEXCLUSIVE to POLLIN and POLLOUT
Date: Fri, 05 Feb 2016 11:49:47 +0200 [thread overview]
Message-ID: <994cbd84457a4986e03ad0c4369600fa@silodev.com> (raw)
In-Reply-To: <20160204145952.53f536f5d4cdef96844104b7-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Andrew Morton @ 2016-02-05 00:59 rakstīja:
> On Thu, 04 Feb 2016 23:44:05 +0200 Madars Vitolins <m@silodev.com>
> wrote:
>
>> Hi Jason,
>>
>>
>> Just run off the original tests with this patch (eventpoll.c from
>> 4.5-rc2 + patch bellow). Got the same good results, no regression.
>>
>> $ time ./bankcl
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 101528948.40 USD
>>
>> real 0m41.826s
>> user 0m29.513s
>> sys 0m6.490s
>>
>>
>> Test case:
>> https://mvitolin.wordpress.com/2015/12/05/endurox-testing-epollexclusive-flag/
>>
>> PS,
>>
>> Original cases 0m24.953s vs 0m41.826s now probably is related with my
>> pc
>> setup. As I just now re-run test with original patch, got the same ~41
>> sec.
>>
>> So I am fine with this patch!
>>
>
> Thanks, I shall add your Tested-by:
>
> One thing we're sorely missing is an epoll test suite, in
> tools/testing/selftests. If anyone has anything which we can use to
> kick things off, please hand it over ;)
Not bad idea, probably we need a "tools/testing/selftests/eventpoll"
folder under which we should have test cases for various epoll scenarios
with common "run.sh". In spare time I can try to build a case for
EXCLUSIVE flag (with queues & multiple processes :) ).
Thanks,
Madars
WARNING: multiple messages have this Message-ID (diff)
From: Madars Vitolins <m@silodev.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jason Baron <jbaron@akamai.com>,
torvalds@linux-foundation.org, mtk.manpages@gmail.com,
mingo@kernel.org, peterz@infradead.org, viro@ftp.linux.org.uk,
normalperson@yhbt.net, corbet@lwn.net, luto@amacapital.net,
hagen@jauu.net, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH] epoll: restrict EPOLLEXCLUSIVE to POLLIN and POLLOUT
Date: Fri, 05 Feb 2016 11:49:47 +0200 [thread overview]
Message-ID: <994cbd84457a4986e03ad0c4369600fa@silodev.com> (raw)
In-Reply-To: <20160204145952.53f536f5d4cdef96844104b7@linux-foundation.org>
Andrew Morton @ 2016-02-05 00:59 rakstīja:
> On Thu, 04 Feb 2016 23:44:05 +0200 Madars Vitolins <m@silodev.com>
> wrote:
>
>> Hi Jason,
>>
>>
>> Just run off the original tests with this patch (eventpoll.c from
>> 4.5-rc2 + patch bellow). Got the same good results, no regression.
>>
>> $ time ./bankcl
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 101528948.40 USD
>>
>> real 0m41.826s
>> user 0m29.513s
>> sys 0m6.490s
>>
>>
>> Test case:
>> https://mvitolin.wordpress.com/2015/12/05/endurox-testing-epollexclusive-flag/
>>
>> PS,
>>
>> Original cases 0m24.953s vs 0m41.826s now probably is related with my
>> pc
>> setup. As I just now re-run test with original patch, got the same ~41
>> sec.
>>
>> So I am fine with this patch!
>>
>
> Thanks, I shall add your Tested-by:
>
> One thing we're sorely missing is an epoll test suite, in
> tools/testing/selftests. If anyone has anything which we can use to
> kick things off, please hand it over ;)
Not bad idea, probably we need a "tools/testing/selftests/eventpoll"
folder under which we should have test cases for various epoll scenarios
with common "run.sh". In spare time I can try to build a case for
EXCLUSIVE flag (with queues & multiple processes :) ).
Thanks,
Madars
next prev parent reply other threads:[~2016-02-05 9:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 15:39 [PATCH] epoll: restrict EPOLLEXCLUSIVE to POLLIN and POLLOUT Jason Baron
2016-02-04 15:39 ` Jason Baron
[not found] ` <1454600344-23655-1-git-send-email-jbaron-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org>
2016-02-04 21:44 ` Madars Vitolins
2016-02-04 21:44 ` Madars Vitolins
2016-02-04 22:59 ` Andrew Morton
[not found] ` <20160204145952.53f536f5d4cdef96844104b7-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2016-02-05 9:49 ` Madars Vitolins [this message]
2016-02-05 9:49 ` Madars Vitolins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=994cbd84457a4986e03ad0c4369600fa@silodev.com \
--to=m@silodev.com \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=corbet-T1hC0tSOHrs@public.gmane.org \
--cc=hagen-GvnIQ6b/HdU@public.gmane.org \
--cc=jbaron-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=normalperson-rMlxZR9MS24@public.gmane.org \
--cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=viro-rfM+Q5joDG/XmaaqVzeoHQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.