* [PATCH 0/2] RK3588 GPIO Support
@ 2022-06-23 16:07 ` Sebastian Reichel
0 siblings, 0 replies; 14+ messages in thread
From: Sebastian Reichel @ 2022-06-23 16:07 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Rob Herring, Krzysztof Kozlowski, Linus Walleij,
Bartosz Golaszewski, linux-gpio, linux-rockchip, devicetree,
Sebastian Reichel, kernel
This has been part of a bigger patchset adding basic rk3588 support.
Since that gets more and more out of hand, I'm now sending patches
for each subsystem as individual patchset. Previou patchet:
https://lore.kernel.org/all/20220504213251.264819-1-sebastian.reichel@collabora.com/
Changes:
* None (except for collecting Acks)
-- Sebastian
Jianqun Xu (1):
gpio: rockchip: add support for rk3588
Sebastian Reichel (1):
dt-bindings: gpio: rockchip: add gpio-ranges
Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 2 ++
drivers/gpio/gpio-rockchip.c | 3 ++-
2 files changed, 4 insertions(+), 1 deletion(-)
--
2.35.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/2] dt-bindings: gpio: rockchip: add gpio-ranges
2022-06-23 16:07 ` Sebastian Reichel
@ 2022-06-23 16:08 ` Sebastian Reichel
-1 siblings, 0 replies; 14+ messages in thread
From: Sebastian Reichel @ 2022-06-23 16:08 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Rob Herring, Krzysztof Kozlowski, Linus Walleij,
Bartosz Golaszewski, linux-gpio, linux-rockchip, devicetree,
Sebastian Reichel, kernel, Rob Herring
Allow usage of gpio-ranges with the rockchip gpio controller. The driver
already had support for this since it has been added to the mainline kernel
in the first place.
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
index d4e42c2b995b..affd823c881d 100644
--- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
+++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
@@ -27,6 +27,8 @@ properties:
- description: APB interface clock source
- description: GPIO debounce reference clock source
+ gpio-ranges: true
+
gpio-controller: true
gpio-line-names: true
--
2.35.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 1/2] dt-bindings: gpio: rockchip: add gpio-ranges
@ 2022-06-23 16:08 ` Sebastian Reichel
0 siblings, 0 replies; 14+ messages in thread
From: Sebastian Reichel @ 2022-06-23 16:08 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Rob Herring, Krzysztof Kozlowski, Linus Walleij,
Bartosz Golaszewski, linux-gpio, linux-rockchip, devicetree,
Sebastian Reichel, kernel, Rob Herring
Allow usage of gpio-ranges with the rockchip gpio controller. The driver
already had support for this since it has been added to the mainline kernel
in the first place.
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
index d4e42c2b995b..affd823c881d 100644
--- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
+++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
@@ -27,6 +27,8 @@ properties:
- description: APB interface clock source
- description: GPIO debounce reference clock source
+ gpio-ranges: true
+
gpio-controller: true
gpio-line-names: true
--
2.35.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 1/2] dt-bindings: gpio: rockchip: add gpio-ranges
2022-06-23 16:08 ` Sebastian Reichel
@ 2022-06-24 16:34 ` Heiko Stuebner
-1 siblings, 0 replies; 14+ messages in thread
From: Heiko Stuebner @ 2022-06-24 16:34 UTC (permalink / raw)
To: Sebastian Reichel
Cc: Rob Herring, Krzysztof Kozlowski, Linus Walleij,
Bartosz Golaszewski, linux-gpio, linux-rockchip, devicetree,
Sebastian Reichel, kernel, Rob Herring
Am Donnerstag, 23. Juni 2022, 18:08:00 CEST schrieb Sebastian Reichel:
> Allow usage of gpio-ranges with the rockchip gpio controller. The driver
> already had support for this since it has been added to the mainline kernel
> in the first place.
>
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] dt-bindings: gpio: rockchip: add gpio-ranges
@ 2022-06-24 16:34 ` Heiko Stuebner
0 siblings, 0 replies; 14+ messages in thread
From: Heiko Stuebner @ 2022-06-24 16:34 UTC (permalink / raw)
To: Sebastian Reichel
Cc: Rob Herring, Krzysztof Kozlowski, Linus Walleij,
Bartosz Golaszewski, linux-gpio, linux-rockchip, devicetree,
Sebastian Reichel, kernel, Rob Herring
Am Donnerstag, 23. Juni 2022, 18:08:00 CEST schrieb Sebastian Reichel:
> Allow usage of gpio-ranges with the rockchip gpio controller. The driver
> already had support for this since it has been added to the mainline kernel
> in the first place.
>
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] dt-bindings: gpio: rockchip: add gpio-ranges
2022-06-23 16:08 ` Sebastian Reichel
@ 2022-06-28 13:58 ` Linus Walleij
-1 siblings, 0 replies; 14+ messages in thread
From: Linus Walleij @ 2022-06-28 13:58 UTC (permalink / raw)
To: Sebastian Reichel
Cc: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski,
Bartosz Golaszewski, linux-gpio, linux-rockchip, devicetree,
kernel, Rob Herring
On Thu, Jun 23, 2022 at 6:08 PM Sebastian Reichel
<sebastian.reichel@collabora.com> wrote:
> Allow usage of gpio-ranges with the rockchip gpio controller. The driver
> already had support for this since it has been added to the mainline kernel
> in the first place.
>
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] dt-bindings: gpio: rockchip: add gpio-ranges
@ 2022-06-28 13:58 ` Linus Walleij
0 siblings, 0 replies; 14+ messages in thread
From: Linus Walleij @ 2022-06-28 13:58 UTC (permalink / raw)
To: Sebastian Reichel
Cc: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski,
Bartosz Golaszewski, linux-gpio, linux-rockchip, devicetree,
kernel, Rob Herring
On Thu, Jun 23, 2022 at 6:08 PM Sebastian Reichel
<sebastian.reichel@collabora.com> wrote:
> Allow usage of gpio-ranges with the rockchip gpio controller. The driver
> already had support for this since it has been added to the mainline kernel
> in the first place.
>
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/2] gpio: rockchip: add support for rk3588
2022-06-23 16:07 ` Sebastian Reichel
@ 2022-06-23 16:08 ` Sebastian Reichel
-1 siblings, 0 replies; 14+ messages in thread
From: Sebastian Reichel @ 2022-06-23 16:08 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Rob Herring, Krzysztof Kozlowski, Linus Walleij,
Bartosz Golaszewski, linux-gpio, linux-rockchip, devicetree,
Jianqun Xu, kernel, Sebastian Reichel
From: Jianqun Xu <jay.xu@rock-chips.com>
Add V2.1 rockchip gpio controller type, which is part of the
RK3588 SoC.
Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
drivers/gpio/gpio-rockchip.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
index e342a6dc4c6c..f91e876fd969 100644
--- a/drivers/gpio/gpio-rockchip.c
+++ b/drivers/gpio/gpio-rockchip.c
@@ -27,6 +27,7 @@
#define GPIO_TYPE_V1 (0) /* GPIO Version ID reserved */
#define GPIO_TYPE_V2 (0x01000C2B) /* GPIO Version ID 0x01000C2B */
+#define GPIO_TYPE_V2_1 (0x0101157C) /* GPIO Version ID 0x0101157C */
static const struct rockchip_gpio_regs gpio_regs_v1 = {
.port_dr = 0x00,
@@ -664,7 +665,7 @@ static int rockchip_get_bank_data(struct rockchip_pin_bank *bank)
id = readl(bank->reg_base + gpio_regs_v2.version_id);
/* If not gpio v2, that is default to v1. */
- if (id == GPIO_TYPE_V2) {
+ if (id == GPIO_TYPE_V2 || id == GPIO_TYPE_V2_1) {
bank->gpio_regs = &gpio_regs_v2;
bank->gpio_type = GPIO_TYPE_V2;
bank->db_clk = of_clk_get(bank->of_node, 1);
--
2.35.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 2/2] gpio: rockchip: add support for rk3588
@ 2022-06-23 16:08 ` Sebastian Reichel
0 siblings, 0 replies; 14+ messages in thread
From: Sebastian Reichel @ 2022-06-23 16:08 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Rob Herring, Krzysztof Kozlowski, Linus Walleij,
Bartosz Golaszewski, linux-gpio, linux-rockchip, devicetree,
Jianqun Xu, kernel, Sebastian Reichel
From: Jianqun Xu <jay.xu@rock-chips.com>
Add V2.1 rockchip gpio controller type, which is part of the
RK3588 SoC.
Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
drivers/gpio/gpio-rockchip.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
index e342a6dc4c6c..f91e876fd969 100644
--- a/drivers/gpio/gpio-rockchip.c
+++ b/drivers/gpio/gpio-rockchip.c
@@ -27,6 +27,7 @@
#define GPIO_TYPE_V1 (0) /* GPIO Version ID reserved */
#define GPIO_TYPE_V2 (0x01000C2B) /* GPIO Version ID 0x01000C2B */
+#define GPIO_TYPE_V2_1 (0x0101157C) /* GPIO Version ID 0x0101157C */
static const struct rockchip_gpio_regs gpio_regs_v1 = {
.port_dr = 0x00,
@@ -664,7 +665,7 @@ static int rockchip_get_bank_data(struct rockchip_pin_bank *bank)
id = readl(bank->reg_base + gpio_regs_v2.version_id);
/* If not gpio v2, that is default to v1. */
- if (id == GPIO_TYPE_V2) {
+ if (id == GPIO_TYPE_V2 || id == GPIO_TYPE_V2_1) {
bank->gpio_regs = &gpio_regs_v2;
bank->gpio_type = GPIO_TYPE_V2;
bank->db_clk = of_clk_get(bank->of_node, 1);
--
2.35.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 2/2] gpio: rockchip: add support for rk3588
2022-06-23 16:08 ` Sebastian Reichel
@ 2022-06-24 16:34 ` Heiko Stuebner
-1 siblings, 0 replies; 14+ messages in thread
From: Heiko Stuebner @ 2022-06-24 16:34 UTC (permalink / raw)
To: Sebastian Reichel
Cc: Rob Herring, Krzysztof Kozlowski, Linus Walleij,
Bartosz Golaszewski, linux-gpio, linux-rockchip, devicetree,
Jianqun Xu, kernel, Sebastian Reichel
Am Donnerstag, 23. Juni 2022, 18:08:01 CEST schrieb Sebastian Reichel:
> From: Jianqun Xu <jay.xu@rock-chips.com>
>
> Add V2.1 rockchip gpio controller type, which is part of the
> RK3588 SoC.
>
> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/2] gpio: rockchip: add support for rk3588
@ 2022-06-24 16:34 ` Heiko Stuebner
0 siblings, 0 replies; 14+ messages in thread
From: Heiko Stuebner @ 2022-06-24 16:34 UTC (permalink / raw)
To: Sebastian Reichel
Cc: Rob Herring, Krzysztof Kozlowski, Linus Walleij,
Bartosz Golaszewski, linux-gpio, linux-rockchip, devicetree,
Jianqun Xu, kernel, Sebastian Reichel
Am Donnerstag, 23. Juni 2022, 18:08:01 CEST schrieb Sebastian Reichel:
> From: Jianqun Xu <jay.xu@rock-chips.com>
>
> Add V2.1 rockchip gpio controller type, which is part of the
> RK3588 SoC.
>
> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/2] RK3588 GPIO Support
2022-06-23 16:07 ` Sebastian Reichel
@ 2022-07-01 10:32 ` Bartosz Golaszewski
-1 siblings, 0 replies; 14+ messages in thread
From: Bartosz Golaszewski @ 2022-07-01 10:32 UTC (permalink / raw)
To: Sebastian Reichel
Cc: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Linus Walleij,
linux-gpio, linux-rockchip, devicetree, kernel
On Thu, Jun 23, 2022 at 6:08 PM Sebastian Reichel
<sebastian.reichel@collabora.com> wrote:
>
> This has been part of a bigger patchset adding basic rk3588 support.
> Since that gets more and more out of hand, I'm now sending patches
> for each subsystem as individual patchset. Previou patchet:
>
> https://lore.kernel.org/all/20220504213251.264819-1-sebastian.reichel@collabora.com/
>
> Changes:
> * None (except for collecting Acks)
>
> -- Sebastian
>
> Jianqun Xu (1):
> gpio: rockchip: add support for rk3588
>
> Sebastian Reichel (1):
> dt-bindings: gpio: rockchip: add gpio-ranges
>
> Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 2 ++
> drivers/gpio/gpio-rockchip.c | 3 ++-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> --
> 2.35.1
>
Both applied, thanks!
Bart
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/2] RK3588 GPIO Support
@ 2022-07-01 10:32 ` Bartosz Golaszewski
0 siblings, 0 replies; 14+ messages in thread
From: Bartosz Golaszewski @ 2022-07-01 10:32 UTC (permalink / raw)
To: Sebastian Reichel
Cc: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Linus Walleij,
linux-gpio, linux-rockchip, devicetree, kernel
On Thu, Jun 23, 2022 at 6:08 PM Sebastian Reichel
<sebastian.reichel@collabora.com> wrote:
>
> This has been part of a bigger patchset adding basic rk3588 support.
> Since that gets more and more out of hand, I'm now sending patches
> for each subsystem as individual patchset. Previou patchet:
>
> https://lore.kernel.org/all/20220504213251.264819-1-sebastian.reichel@collabora.com/
>
> Changes:
> * None (except for collecting Acks)
>
> -- Sebastian
>
> Jianqun Xu (1):
> gpio: rockchip: add support for rk3588
>
> Sebastian Reichel (1):
> dt-bindings: gpio: rockchip: add gpio-ranges
>
> Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 2 ++
> drivers/gpio/gpio-rockchip.c | 3 ++-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> --
> 2.35.1
>
Both applied, thanks!
Bart
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 14+ messages in thread