All of lore.kernel.org
 help / color / mirror / Atom feed
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Aaro Koskinen <aaro.koskinen@nokia.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	tony@atomide.com
Subject: RE: [PATCH 2/2] arm: mach-omap2: omap_l3_smx: fix irq handler setup
Date: Thu, 17 Mar 2011 11:24:03 +0530	[thread overview]
Message-ID: <997c0c456e24cd4bec71cb003fdce6f3@mail.gmail.com> (raw)
In-Reply-To: <1300295763-497-2-git-send-email-aaro.koskinen@nokia.com>

> -----Original Message-----
> From: linux-arm-kernel-bounces@lists.infradead.org [mailto:linux-
> arm-kernel-bounces@lists.infradead.org] On Behalf Of Aaro Koskinen
> Sent: Wednesday, March 16, 2011 10:46 PM
> To: linux-omap@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; tony@atomide.com
> Cc: Aaro Koskinen
> Subject: [PATCH 2/2] arm: mach-omap2: omap_l3_smx: fix irq handler
> setup
>
> The handler function may be called from the point it is registered.
> Since the handler inspects IRQ numbers, we must set them up before
> registration.
>
Right. Thanks.

> Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
> ---

Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>

>  arch/arm/mach-omap2/omap_l3_smx.c |   11 ++++-------
>  1 files changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_l3_smx.c b/arch/arm/mach-
> omap2/omap_l3_smx.c
> index 265bff3..5f2da75 100644
> --- a/arch/arm/mach-omap2/omap_l3_smx.c
> +++ b/arch/arm/mach-omap2/omap_l3_smx.c
> @@ -226,7 +226,6 @@ static int __init omap3_l3_probe(struct
> platform_device *pdev)
>  	struct omap3_l3         *l3;
>  	struct resource         *res;
>  	int                     ret;
> -	int                     irq;
>
>  	l3 = kzalloc(sizeof(*l3), GFP_KERNEL);
>  	if (!l3) {
> @@ -249,18 +248,17 @@ static int __init omap3_l3_probe(struct
> platform_device *pdev)
>  		goto err2;
>  	}
>
> -	irq = platform_get_irq(pdev, 0);
> -	ret = request_irq(irq, omap3_l3_app_irq,
> +	l3->debug_irq = platform_get_irq(pdev, 0);
> +	ret = request_irq(l3->debug_irq, omap3_l3_app_irq,
>  		IRQF_DISABLED | IRQF_TRIGGER_RISING,
>  		"l3-debug-irq", l3);
>  	if (ret) {
>  		dev_err(&pdev->dev, "couldn't request debug irq\n");
>  		goto err3;
>  	}
> -	l3->debug_irq = irq;
>
> -	irq = platform_get_irq(pdev, 1);
> -	ret = request_irq(irq, omap3_l3_app_irq,
> +	l3->app_irq = platform_get_irq(pdev, 1);
> +	ret = request_irq(l3->app_irq, omap3_l3_app_irq,
>  		IRQF_DISABLED | IRQF_TRIGGER_RISING,
>  		"l3-app-irq", l3);
>
> @@ -269,7 +267,6 @@ static int __init omap3_l3_probe(struct
> platform_device *pdev)
>  		goto err4;
>  	}
>
> -	l3->app_irq = irq;
>  	goto err0;
>
>  err4:
> --
> 1.5.6.5
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm: mach-omap2: omap_l3_smx: fix irq handler setup
Date: Thu, 17 Mar 2011 11:24:03 +0530	[thread overview]
Message-ID: <997c0c456e24cd4bec71cb003fdce6f3@mail.gmail.com> (raw)
In-Reply-To: <1300295763-497-2-git-send-email-aaro.koskinen@nokia.com>

> -----Original Message-----
> From: linux-arm-kernel-bounces at lists.infradead.org [mailto:linux-
> arm-kernel-bounces at lists.infradead.org] On Behalf Of Aaro Koskinen
> Sent: Wednesday, March 16, 2011 10:46 PM
> To: linux-omap at vger.kernel.org; linux-arm-
> kernel at lists.infradead.org; tony at atomide.com
> Cc: Aaro Koskinen
> Subject: [PATCH 2/2] arm: mach-omap2: omap_l3_smx: fix irq handler
> setup
>
> The handler function may be called from the point it is registered.
> Since the handler inspects IRQ numbers, we must set them up before
> registration.
>
Right. Thanks.

> Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
> ---

Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>

>  arch/arm/mach-omap2/omap_l3_smx.c |   11 ++++-------
>  1 files changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_l3_smx.c b/arch/arm/mach-
> omap2/omap_l3_smx.c
> index 265bff3..5f2da75 100644
> --- a/arch/arm/mach-omap2/omap_l3_smx.c
> +++ b/arch/arm/mach-omap2/omap_l3_smx.c
> @@ -226,7 +226,6 @@ static int __init omap3_l3_probe(struct
> platform_device *pdev)
>  	struct omap3_l3         *l3;
>  	struct resource         *res;
>  	int                     ret;
> -	int                     irq;
>
>  	l3 = kzalloc(sizeof(*l3), GFP_KERNEL);
>  	if (!l3) {
> @@ -249,18 +248,17 @@ static int __init omap3_l3_probe(struct
> platform_device *pdev)
>  		goto err2;
>  	}
>
> -	irq = platform_get_irq(pdev, 0);
> -	ret = request_irq(irq, omap3_l3_app_irq,
> +	l3->debug_irq = platform_get_irq(pdev, 0);
> +	ret = request_irq(l3->debug_irq, omap3_l3_app_irq,
>  		IRQF_DISABLED | IRQF_TRIGGER_RISING,
>  		"l3-debug-irq", l3);
>  	if (ret) {
>  		dev_err(&pdev->dev, "couldn't request debug irq\n");
>  		goto err3;
>  	}
> -	l3->debug_irq = irq;
>
> -	irq = platform_get_irq(pdev, 1);
> -	ret = request_irq(irq, omap3_l3_app_irq,
> +	l3->app_irq = platform_get_irq(pdev, 1);
> +	ret = request_irq(l3->app_irq, omap3_l3_app_irq,
>  		IRQF_DISABLED | IRQF_TRIGGER_RISING,
>  		"l3-app-irq", l3);
>
> @@ -269,7 +267,6 @@ static int __init omap3_l3_probe(struct
> platform_device *pdev)
>  		goto err4;
>  	}
>
> -	l3->app_irq = irq;
>  	goto err0;
>
>  err4:
> --
> 1.5.6.5
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2011-03-17  5:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-16 17:16 [PATCH 1/2] arm: mach-omap2: devices: fix omap3_l3_init() return value Aaro Koskinen
2011-03-16 17:16 ` Aaro Koskinen
2011-03-16 17:16 ` [PATCH 2/2] arm: mach-omap2: omap_l3_smx: fix irq handler setup Aaro Koskinen
2011-03-16 17:16   ` Aaro Koskinen
2011-03-17  5:54   ` Santosh Shilimkar [this message]
2011-03-17  5:54     ` Santosh Shilimkar
2011-03-17  5:52 ` [PATCH 1/2] arm: mach-omap2: devices: fix omap3_l3_init() return value Santosh Shilimkar
2011-03-17  5:52   ` Santosh Shilimkar
2011-03-17  8:19   ` Cousson, Benoit
2011-03-17  8:19     ` Cousson, Benoit
2011-03-17 10:06     ` Santosh Shilimkar
2011-03-17 10:06       ` Santosh Shilimkar
2011-03-18 23:43       ` Tony Lindgren
2011-03-18 23:43         ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=997c0c456e24cd4bec71cb003fdce6f3@mail.gmail.com \
    --to=santosh.shilimkar@ti.com \
    --cc=aaro.koskinen@nokia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.