All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars Persson <lars.persson@axis.com>
To: "Stephan Müller" <smueller@chronox.de>, "Lars Persson" <larper@axis.com>
Cc: <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
	<robh+dt@kernel.org>, <mark.rutland@arm.com>,
	<linux-crypto@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH 3/4] crypto: axis: add ARTPEC-6/7 crypto accelerator driver
Date: Fri, 21 Jul 2017 08:29:27 +0200	[thread overview]
Message-ID: <9a3e69da-bfa2-e47a-49a0-aeb50837308b@axis.com> (raw)
In-Reply-To: <9168085.KJckqYBggK@tauon.chronox.de>



On 07/20/2017 04:51 PM, Stephan Müller wrote:
> Am Donnerstag, 20. Juli 2017, 15:44:31 CEST schrieb Lars Persson:
>
> Hi Lars,
>
>> +static int
>> +artpec6_crypto_cipher_set_key(struct crypto_skcipher *cipher, const u8
>> *key, +			      unsigned int keylen)
>> +{
>> +	struct artpec6_cryptotfm_context *ctx =
>> +		crypto_skcipher_ctx(cipher);
>> +
>> +	if (ctx->crypto_type == ARTPEC6_CRYPTO_CIPHER_NULL)
>> +		return 0;
>> +
>> +	switch (keylen) {
>> +	case 16:
>> +	case 24:
>> +	case 32:
>> +		break;
>> +	case 48:
>> +	case 64:
>> +		if (ctx->crypto_type == ARTPEC6_CRYPTO_CIPHER_AES_XTS)
>
> Could you please add xts_check_key for XTS keys?
>
Sure, I will add this in v2.

Thanks,
  Lars

WARNING: multiple messages have this Message-ID (diff)
From: Lars Persson <lars.persson@axis.com>
To: "Stephan Müller" <smueller@chronox.de>, "Lars Persson" <larper@axis.com>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
	robh+dt@kernel.org, mark.rutland@arm.com,
	linux-crypto@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/4] crypto: axis: add ARTPEC-6/7 crypto accelerator driver
Date: Fri, 21 Jul 2017 08:29:27 +0200	[thread overview]
Message-ID: <9a3e69da-bfa2-e47a-49a0-aeb50837308b@axis.com> (raw)
In-Reply-To: <9168085.KJckqYBggK@tauon.chronox.de>



On 07/20/2017 04:51 PM, Stephan Müller wrote:
> Am Donnerstag, 20. Juli 2017, 15:44:31 CEST schrieb Lars Persson:
>
> Hi Lars,
>
>> +static int
>> +artpec6_crypto_cipher_set_key(struct crypto_skcipher *cipher, const u8
>> *key, +			      unsigned int keylen)
>> +{
>> +	struct artpec6_cryptotfm_context *ctx =
>> +		crypto_skcipher_ctx(cipher);
>> +
>> +	if (ctx->crypto_type == ARTPEC6_CRYPTO_CIPHER_NULL)
>> +		return 0;
>> +
>> +	switch (keylen) {
>> +	case 16:
>> +	case 24:
>> +	case 32:
>> +		break;
>> +	case 48:
>> +	case 64:
>> +		if (ctx->crypto_type == ARTPEC6_CRYPTO_CIPHER_AES_XTS)
>
> Could you please add xts_check_key for XTS keys?
>
Sure, I will add this in v2.

Thanks,
  Lars

  reply	other threads:[~2017-07-21  6:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-20 13:44 [PATCH 0/4] crypto: add driver for Axis ARTPEC crypto accelerator Lars Persson
2017-07-20 13:44 ` [PATCH 3/4] crypto: axis: add ARTPEC-6/7 crypto accelerator driver Lars Persson
     [not found]   ` <b2d7ce4b0fecc4e811c12573f44bd7c45f0147e2.1500557664.git.larper-VrBV9hrLPhE@public.gmane.org>
2017-07-20 14:51     ` Stephan Müller
2017-07-21  6:29       ` Lars Persson [this message]
2017-07-21  6:29         ` Lars Persson
     [not found] ` <cover.1500557664.git.larper-VrBV9hrLPhE@public.gmane.org>
2017-07-20 13:44   ` [PATCH 1/4] dt-bindings: crypto: add ARTPEC crypto Lars Persson
2017-07-20 13:44   ` [PATCH 2/4] crypto: add crypto_(un)register_ahashes() Lars Persson
2017-07-20 13:44   ` [PATCH 4/4] MAINTAINERS: Add ARTPEC crypto maintainer Lars Persson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a3e69da-bfa2-e47a-49a0-aeb50837308b@axis.com \
    --to=lars.persson@axis.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=larper@axis.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=smueller@chronox.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.