All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 1/1] Documentation: hyperv: Update documentation for sending VMBus packets
@ 2026-10-09 18:40 Michael Kelley
  2026-10-09 18:44 ` sashiko-bot
  2026-10-12  5:39 ` Naman Jain
  0 siblings, 2 replies; 3+ messages in thread
From: Michael Kelley @ 2026-10-09 18:40 UTC (permalink / raw)
  To: haiyangz, wei.liu, decui, corbet, skhan, rdunlap, linux-kernel,
	linux-hyperv, linux-doc

The functions for sending VMBus packets have changed.
vmbus_sendpacket_mpb_desc() can target multiple ranges, and
vmbus_sendpacket_pagebuffer() has been removed. vmbus_sendpacket_getid()
has been added. Update the documentation accordingly.

Fixes: 45a442fe369e ("Drivers: hv: vmbus: Remove vmbus_sendpacket_pagebuffer()")
Cc: stable@vger.kernel.org
Signed-off-by: Michael Kelley <mhklinux@outlook.com>
---
Changes in v2:
* Add vmbus_sendpacket_getid() to the documentation. [Naman Jain]

 Documentation/virt/hyperv/vmbus.rst | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/Documentation/virt/hyperv/vmbus.rst b/Documentation/virt/hyperv/vmbus.rst
index 654bb4849972..9c5b712c6e39 100644
--- a/Documentation/virt/hyperv/vmbus.rst
+++ b/Documentation/virt/hyperv/vmbus.rst
@@ -141,14 +141,15 @@ Three functions exist to send VMBus channel messages:
 
 1. vmbus_sendpacket():  Control-only messages and messages with
    embedded data -- no GPAs
-2. vmbus_sendpacket_pagebuffer(): Message with list of GPAs
-   identifying data to transfer.  An offset and length is
-   associated with each GPA so that multiple discontinuous areas
-   of guest memory can be targeted.
-3. vmbus_sendpacket_mpb_desc(): Message with list of GPAs
-   identifying data to transfer.  A single offset and length is
-   associated with a list of GPAs.  The GPAs must describe a
-   single logical area of guest memory to be targeted.
+2. vmbus_sendpacket_getid(): Similar to vmbus_sendpacket() but returns
+   a transaction ID that is matched against a reply from the Hyper-V
+   host. Useful when the struct completion (or other rendezvous data)
+   must reside on the caller's stack. By invalidating the transaction
+   ID before exiting the function due to a timeout or other error, a
+   late arrving interrupt is assured to not trash the stack.
+3. vmbus_sendpacket_mpb_desc(): Message with one or more data ranges
+   to target. Each range consists of a single offset and length plus
+   a list of GPAs that describe a logical area of guest memory.
 
 Historically, Linux guests have trusted Hyper-V to send well-formed
 and valid messages, and Linux drivers for synthetic devices did not
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/1] Documentation: hyperv: Update documentation for sending VMBus packets
  2026-10-09 18:40 [PATCH v2 1/1] Documentation: hyperv: Update documentation for sending VMBus packets Michael Kelley
@ 2026-10-09 18:44 ` sashiko-bot
  2026-10-12  5:39 ` Naman Jain
  1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-10-09 18:44 UTC (permalink / raw)
  To: Michael Kelley; +Cc: linux-hyperv

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] docs: hyperv: typo in vmbus.rst 'arrving' instead of 'arriving'
--

commit 3fd30f16ff2564a1edce678567a65e19e411e062
Author: Michael Kelley <mhkelley58@gmail.com>

Documentation: hyperv: Update documentation for sending VMBus packets

The commit updates the VMBus documentation to reflect changes in the sending
functions, specifically the removal of vmbus_sendpacket_pagebuffer(), the
addition of vmbus_sendpacket_getid(), and the updated capability of
vmbus_sendpacket_mpb_desc().

> diff --git a/Documentation/virt/hyperv/vmbus.rst b/Documentation/virt/hyperv/vmbus.rst
> index 654bb48499724..9c5b712c6e397 100644
> --- a/Documentation/virt/hyperv/vmbus.rst
> +++ b/Documentation/virt/hyperv/vmbus.rst
> @@ -141,14 +141,15 @@ Three functions exist to send VMBus channel messages:

[ ... ]

> +2. vmbus_sendpacket_getid(): Similar to vmbus_sendpacket() but returns
> +   a transaction ID that is matched against a reply from the Hyper-V
> +   host. Useful when the struct completion (or other rendezvous data)
> +   must reside on the caller's stack. By invalidating the transaction
> +   ID before exiting the function due to a timeout or other error, a
> +   late arrving interrupt is assured to not trash the stack.

[Severity: Low]
This isn't a bug, but there is a typo here: "arrving" instead of "arriving".

> +3. vmbus_sendpacket_mpb_desc(): Message with one or more data ranges
> +   to target. Each range consists of a single offset and length plus
> +   a list of GPAs that describe a logical area of guest memory.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009184056.7382-1-mhklinux@outlook.com?part=1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/1] Documentation: hyperv: Update documentation for sending VMBus packets
  2026-10-09 18:40 [PATCH v2 1/1] Documentation: hyperv: Update documentation for sending VMBus packets Michael Kelley
  2026-10-09 18:44 ` sashiko-bot
@ 2026-10-12  5:39 ` Naman Jain
  1 sibling, 0 replies; 3+ messages in thread
From: Naman Jain @ 2026-10-12  5:39 UTC (permalink / raw)
  To: mhklinux, haiyangz, wei.liu, decui, corbet, skhan, rdunlap,
	linux-kernel, linux-hyperv, linux-doc



On 10/10/2026 12:10 AM, Michael Kelley wrote:
> The functions for sending VMBus packets have changed.
> vmbus_sendpacket_mpb_desc() can target multiple ranges, and
> vmbus_sendpacket_pagebuffer() has been removed. vmbus_sendpacket_getid()
> has been added. Update the documentation accordingly.
> 
> Fixes: 45a442fe369e ("Drivers: hv: vmbus: Remove vmbus_sendpacket_pagebuffer()")
> Cc: stable@vger.kernel.org
> Signed-off-by: Michael Kelley <mhklinux@outlook.com>
> ---
> Changes in v2:
> * Add vmbus_sendpacket_getid() to the documentation. [Naman Jain]

Reviewed-by: Naman Jain <namjain@linux.microsoft.com>

Regards,
Naman

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-10-12  5:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-09 18:40 [PATCH v2 1/1] Documentation: hyperv: Update documentation for sending VMBus packets Michael Kelley
2026-10-09 18:44 ` sashiko-bot
2026-10-12  5:39 ` Naman Jain

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.