* [PATCH v1 1/3] drm/amdgpu: update the fw version for gfx11 userqueues
@ 2026-08-31 15:02 Sunil Khatri
2026-08-31 15:02 ` [PATCH v1 2/3] drm/amdgpu: update the fw version for gfx12 userqueues Sunil Khatri
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Sunil Khatri @ 2026-08-31 15:02 UTC (permalink / raw)
To: Alex Deucher, Christian König; +Cc: amd-gfx, Sunil Khatri
Update to the latest stable fw versions where userqueues
is working as it is expected with major fixes.
Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
---
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
index d704ce328e6e..2c160ec9dc57 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
@@ -1655,10 +1655,10 @@ static int gfx_v11_0_sw_init(struct amdgpu_ip_block *ip_block)
case IP_VERSION(11, 0, 2):
case IP_VERSION(11, 0, 3):
if (!adev->gfx.disable_uq &&
- adev->gfx.me_fw_version >= 2420 &&
- adev->gfx.pfp_fw_version >= 2580 &&
- adev->gfx.mec_fw_version >= 2650 &&
- adev->mes.fw_version[0] >= 120) {
+ adev->gfx.me_fw_version >= 3090 &&
+ adev->gfx.pfp_fw_version >= 3190 &&
+ adev->gfx.mec_fw_version >= 3450 &&
+ adev->mes.fw_version[0] >= 147) {
adev->userq_funcs[AMDGPU_HW_IP_GFX] = &userq_mes_funcs;
adev->userq_funcs[AMDGPU_HW_IP_COMPUTE] = &userq_mes_funcs;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v1 2/3] drm/amdgpu: update the fw version for gfx12 userqueues
2026-08-31 15:02 [PATCH v1 1/3] drm/amdgpu: update the fw version for gfx11 userqueues Sunil Khatri
@ 2026-08-31 15:02 ` Sunil Khatri
2026-08-31 15:02 ` [PATCH v1 3/3] drm/amdgpu: add the fw check for gfx11 missing ips for uq Sunil Khatri
2026-08-31 15:12 ` [PATCH v1 1/3] drm/amdgpu: update the fw version for gfx11 userqueues Alex Deucher
2 siblings, 0 replies; 6+ messages in thread
From: Sunil Khatri @ 2026-08-31 15:02 UTC (permalink / raw)
To: Alex Deucher, Christian König; +Cc: amd-gfx, Sunil Khatri
Update to the latest stable fw versions where userqueues
is working as it is expected with major fixes.
Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
---
drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c
index df8d36be613a..4d5f14a37be3 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c
@@ -1440,10 +1440,10 @@ static int gfx_v12_0_sw_init(struct amdgpu_ip_block *ip_block)
case IP_VERSION(12, 0, 0):
case IP_VERSION(12, 0, 1):
if (!adev->gfx.disable_uq &&
- adev->gfx.me_fw_version >= 2780 &&
- adev->gfx.pfp_fw_version >= 2840 &&
- adev->gfx.mec_fw_version >= 3050 &&
- adev->mes.fw_version[0] >= 123) {
+ adev->gfx.me_fw_version >= 3090 &&
+ adev->gfx.pfp_fw_version >= 3190 &&
+ adev->gfx.mec_fw_version >= 3450 &&
+ adev->mes.fw_version[0] >= 147) {
adev->userq_funcs[AMDGPU_HW_IP_GFX] = &userq_mes_funcs;
adev->userq_funcs[AMDGPU_HW_IP_COMPUTE] = &userq_mes_funcs;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v1 3/3] drm/amdgpu: add the fw check for gfx11 missing ips for uq
2026-08-31 15:02 [PATCH v1 1/3] drm/amdgpu: update the fw version for gfx11 userqueues Sunil Khatri
2026-08-31 15:02 ` [PATCH v1 2/3] drm/amdgpu: update the fw version for gfx12 userqueues Sunil Khatri
@ 2026-08-31 15:02 ` Sunil Khatri
2026-08-31 15:11 ` Alex Deucher
2026-08-31 15:12 ` [PATCH v1 1/3] drm/amdgpu: update the fw version for gfx11 userqueues Alex Deucher
2 siblings, 1 reply; 6+ messages in thread
From: Sunil Khatri @ 2026-08-31 15:02 UTC (permalink / raw)
To: Alex Deucher, Christian König; +Cc: amd-gfx, Sunil Khatri
Add the proper checks for some of the gfx11 variant IP's
for firmware support of userqueues.
Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
---
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
index 2c160ec9dc57..ca142c69cc28 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
@@ -1670,7 +1670,11 @@ static int gfx_v11_0_sw_init(struct amdgpu_ip_block *ip_block)
case IP_VERSION(11, 5, 2):
case IP_VERSION(11, 5, 3):
/* add firmware version checks here */
- if (0 && !adev->gfx.disable_uq) {
+ if (!adev->gfx.disable_uq &&
+ adev->gfx.me_fw_version >= 3090 &&
+ adev->gfx.pfp_fw_version >= 3190 &&
+ adev->gfx.mec_fw_version >= 3450 &&
+ adev->mes.fw_version[0] >= 147) {
adev->userq_funcs[AMDGPU_HW_IP_GFX] = &userq_mes_funcs;
adev->userq_funcs[AMDGPU_HW_IP_COMPUTE] = &userq_mes_funcs;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v1 3/3] drm/amdgpu: add the fw check for gfx11 missing ips for uq
2026-08-31 15:02 ` [PATCH v1 3/3] drm/amdgpu: add the fw check for gfx11 missing ips for uq Sunil Khatri
@ 2026-08-31 15:11 ` Alex Deucher
2026-08-31 15:15 ` Khatri, Sunil
0 siblings, 1 reply; 6+ messages in thread
From: Alex Deucher @ 2026-08-31 15:11 UTC (permalink / raw)
To: Sunil Khatri; +Cc: Alex Deucher, Christian König, amd-gfx
On Mon, Aug 31, 2026 at 11:02 AM Sunil Khatri <sunil.khatri@amd.com> wrote:
>
> Add the proper checks for some of the gfx11 variant IP's
> for firmware support of userqueues.
>
> Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> index 2c160ec9dc57..ca142c69cc28 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> @@ -1670,7 +1670,11 @@ static int gfx_v11_0_sw_init(struct amdgpu_ip_block *ip_block)
> case IP_VERSION(11, 5, 2):
> case IP_VERSION(11, 5, 3):
> /* add firmware version checks here */
> - if (0 && !adev->gfx.disable_uq) {
> + if (!adev->gfx.disable_uq &&
> + adev->gfx.me_fw_version >= 3090 &&
> + adev->gfx.pfp_fw_version >= 3190 &&
> + adev->gfx.mec_fw_version >= 3450 &&
> + adev->mes.fw_version[0] >= 147) {
We should verify this on all of these APUs first. I'm not sure if the
fixes have landed for phoenix parts yet. We may need to split the
checks for stix vs phx depending on the firmware versions.
Alex
> adev->userq_funcs[AMDGPU_HW_IP_GFX] = &userq_mes_funcs;
> adev->userq_funcs[AMDGPU_HW_IP_COMPUTE] = &userq_mes_funcs;
> }
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v1 3/3] drm/amdgpu: add the fw check for gfx11 missing ips for uq
2026-08-31 15:11 ` Alex Deucher
@ 2026-08-31 15:15 ` Khatri, Sunil
0 siblings, 0 replies; 6+ messages in thread
From: Khatri, Sunil @ 2026-08-31 15:15 UTC (permalink / raw)
To: Alex Deucher, Sunil Khatri; +Cc: Alex Deucher, Christian König, amd-gfx
On 31-08-2026 08:41 pm, Alex Deucher wrote:
> On Mon, Aug 31, 2026 at 11:02 AM Sunil Khatri <sunil.khatri@amd.com> wrote:
>> Add the proper checks for some of the gfx11 variant IP's
>> for firmware support of userqueues.
>>
>> Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
>> ---
>> drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
>> index 2c160ec9dc57..ca142c69cc28 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
>> @@ -1670,7 +1670,11 @@ static int gfx_v11_0_sw_init(struct amdgpu_ip_block *ip_block)
>> case IP_VERSION(11, 5, 2):
>> case IP_VERSION(11, 5, 3):
>> /* add firmware version checks here */
>> - if (0 && !adev->gfx.disable_uq) {
>> + if (!adev->gfx.disable_uq &&
>> + adev->gfx.me_fw_version >= 3090 &&
>> + adev->gfx.pfp_fw_version >= 3190 &&
>> + adev->gfx.mec_fw_version >= 3450 &&
>> + adev->mes.fw_version[0] >= 147) {
> We should verify this on all of these APUs first. I'm not sure if the
> fixes have landed for phoenix parts yet. We may need to split the
> checks for stix vs phx depending on the firmware versions.
ok, so for now i will drop this patch and will pick up later when APUs
will be tested... My understanding was to use the latest version which
should work for those APUs too, but yes its possible the fw does not
support these yet and hard to validate with device availability and
support as open questions...
Regards
Sunil Khatri
>
> Alex
>
>> adev->userq_funcs[AMDGPU_HW_IP_GFX] = &userq_mes_funcs;
>> adev->userq_funcs[AMDGPU_HW_IP_COMPUTE] = &userq_mes_funcs;
>> }
>> --
>> 2.34.1
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/3] drm/amdgpu: update the fw version for gfx11 userqueues
2026-08-31 15:02 [PATCH v1 1/3] drm/amdgpu: update the fw version for gfx11 userqueues Sunil Khatri
2026-08-31 15:02 ` [PATCH v1 2/3] drm/amdgpu: update the fw version for gfx12 userqueues Sunil Khatri
2026-08-31 15:02 ` [PATCH v1 3/3] drm/amdgpu: add the fw check for gfx11 missing ips for uq Sunil Khatri
@ 2026-08-31 15:12 ` Alex Deucher
2 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2026-08-31 15:12 UTC (permalink / raw)
To: Sunil Khatri; +Cc: Alex Deucher, Christian König, amd-gfx
Patches 1 and 2:
Acked-by: Alex Deucher <alexander.deucher@amd.com>
On Mon, Aug 31, 2026 at 11:02 AM Sunil Khatri <sunil.khatri@amd.com> wrote:
>
> Update to the latest stable fw versions where userqueues
> is working as it is expected with major fixes.
>
> Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> index d704ce328e6e..2c160ec9dc57 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> @@ -1655,10 +1655,10 @@ static int gfx_v11_0_sw_init(struct amdgpu_ip_block *ip_block)
> case IP_VERSION(11, 0, 2):
> case IP_VERSION(11, 0, 3):
> if (!adev->gfx.disable_uq &&
> - adev->gfx.me_fw_version >= 2420 &&
> - adev->gfx.pfp_fw_version >= 2580 &&
> - adev->gfx.mec_fw_version >= 2650 &&
> - adev->mes.fw_version[0] >= 120) {
> + adev->gfx.me_fw_version >= 3090 &&
> + adev->gfx.pfp_fw_version >= 3190 &&
> + adev->gfx.mec_fw_version >= 3450 &&
> + adev->mes.fw_version[0] >= 147) {
> adev->userq_funcs[AMDGPU_HW_IP_GFX] = &userq_mes_funcs;
> adev->userq_funcs[AMDGPU_HW_IP_COMPUTE] = &userq_mes_funcs;
> }
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-08-31 15:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-31 15:02 [PATCH v1 1/3] drm/amdgpu: update the fw version for gfx11 userqueues Sunil Khatri
2026-08-31 15:02 ` [PATCH v1 2/3] drm/amdgpu: update the fw version for gfx12 userqueues Sunil Khatri
2026-08-31 15:02 ` [PATCH v1 3/3] drm/amdgpu: add the fw check for gfx11 missing ips for uq Sunil Khatri
2026-08-31 15:11 ` Alex Deucher
2026-08-31 15:15 ` Khatri, Sunil
2026-08-31 15:12 ` [PATCH v1 1/3] drm/amdgpu: update the fw version for gfx11 userqueues Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.