All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: Simon Richter <Simon.Richter@hogyros.de>, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v2 3/3] drm/xe: skip p2p for suspected display buffers
Date: Thu, 8 Oct 2026 17:22:16 +0100	[thread overview]
Message-ID: <9ca279c6-dcfa-4caf-a00f-d3af0a2ddf1d@intel.com> (raw)
In-Reply-To: <9d0c9f3c-acb8-4566-b313-a9eb8f17f332@hogyros.de>

Hi,

On 08/10/2026 15:40, Simon Richter wrote:
> Hi,
> 
> On 10/8/26 18:46, Matthew Auld wrote:
> 
>> From the user bug report it sounds like the dgpu linear window buffer 
>> exported to the compositor (igpu) is dual placement VRAM + TT, and so 
>> this now attempts to keep that memory in VRAM instead of moving it. 
>> Compositor then uses p2p to access it. It works but performance falls 
>> off a massive cliff here.
> 
> Is that because it is using external memory as a texture source, or 
> because copy operations are slow for some reason?

Not sure tbh.

> 
> If it is for a texture, the client should say so explicitly during the 
> import, e.g. a Vulkan[1] client would give a 
> VkExternalMemoryImageCreateInfo pointer in pNext, and fill out usage as 
> VK_IMAGE_USAGE_SAMPLED_BIT.
> 
> I think this would be the ideal point to either make sure the image ends 
> up in host memory, or reject it so the compositor can detect that this 
> is not a good texture source, and insert an extra transfer.

I think user reported that Vulkan was unaffected, it's just OpenGL. From 
kernel pov, we don't really know if we are actually meant to use p2p, or 
move to system memory, since we are lacking any kind of hint. This is 
maybe a miss. We just end up with a valid looking buffer with a dual 
placement that gets exported to amdgpu. On amd CPUs they allow p2p, even 
for igpu. So when user updated their kernel version, where the 
MOVE_NOTIFY config got removed and enabled by default this suddenly gave 
them the p2p path with buffer staying in VRAM, whereas before the buffer 
would have been correctly moved to system memory by the kernel.

> 
>     Simon
> 
> [1] Presumably, other graphics APIs have something similar.


  reply	other threads:[~2026-10-08 16:22 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07 15:36 [PATCH v2 0/3] sticky TT Matthew Auld
2026-10-07 15:36 ` [PATCH v2 1/3] drm/xe/dma-buf: keep non-p2p imported buffers in system memory Matthew Auld
2026-10-07 15:36 ` [PATCH v2 2/3] drm/xe/vm: make PREFETCH to TT sticky Matthew Auld
2026-10-07 15:36 ` [PATCH v2 3/3] drm/xe: skip p2p for suspected display buffers Matthew Auld
2026-10-07 18:11   ` Thomas Hellström
2026-10-08  9:46     ` Matthew Auld
2026-10-08  9:55       ` Christian König
2026-10-08 11:17         ` Matthew Auld
2026-10-09  9:16           ` Matthew Auld
2026-10-09  9:26             ` Christian König
2026-10-09 10:29               ` Matthew Auld
2026-10-09 11:38                 ` Christian König
2026-10-09 13:02                   ` Matthew Auld
2026-10-13  8:51                     ` Matthew Auld
2026-10-13  9:10                       ` Christian König
2026-10-13  9:18                         ` Thomas Hellström
2026-10-13  9:55                           ` Christian König
2026-10-13 10:16                             ` Thomas Hellström
2026-10-13 11:45                               ` Christian König
2026-10-13 12:36                                 ` Matthew Auld
2026-10-13  9:40                         ` Matthew Auld
2026-10-13 11:50                           ` Christian König
2026-10-13 13:15                             ` Matthew Auld
2026-10-09 13:06                   ` Thomas Hellström
2026-10-08 14:40       ` Simon Richter
2026-10-08 16:22         ` Matthew Auld [this message]
2026-10-07 15:42 ` ✗ CI.checkpatch: warning for sticky TT (rev2) Patchwork
2026-10-07 15:45 ` ✓ CI.KUnit: success " Patchwork
2026-10-07 16:46 ` ✓ Xe.CI.BAT: " Patchwork
2026-10-07 20:16 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ca279c6-dcfa-4caf-a00f-d3af0a2ddf1d@intel.com \
    --to=matthew.auld@intel.com \
    --cc=Simon.Richter@hogyros.de \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.