From: Jeff Law <jeffreyalaw@gmail.com>
To: Stafford Horne <shorne@gmail.com>, GCC patches <gcc-patches@gcc.gnu.org>
Cc: Linux OpenRISC <linux-openrisc@vger.kernel.org>
Subject: Re: [PATCH] or1k: Fix struct return test
Date: Sun, 1 Jun 2025 21:17:45 -0600 [thread overview]
Message-ID: <9cbd6d7f-c5d0-4825-9b06-e694d32cdecd@gmail.com> (raw)
In-Reply-To: <20250531060321.3687859-1-shorne@gmail.com>
On 5/31/25 12:03 AM, Stafford Horne wrote:
> In or1k structs are returned from functions using the memory address
> passed in r3. In the current version of GCC the struct stores changed
> from r11 (the return value) to r3 the incoming memory address. Both of
> are valid.
>
> Adjust the test to match what GCC is producing now.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/or1k/return-2.c: Fix test.
Given you're the maintainer of this port it seems like you can
self-approve and commit this and the long jump offset patch.
Jeff
next prev parent reply other threads:[~2025-06-02 3:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-31 6:03 [PATCH] or1k: Fix struct return test Stafford Horne
2025-06-02 3:17 ` Jeff Law [this message]
2025-06-02 10:06 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cbd6d7f-c5d0-4825-9b06-e694d32cdecd@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.