From: Stafford Horne <shorne@gmail.com>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: GCC patches <gcc-patches@gcc.gnu.org>,
Linux OpenRISC <linux-openrisc@vger.kernel.org>
Subject: Re: [PATCH] or1k: Fix struct return test
Date: Mon, 2 Jun 2025 11:06:19 +0100 [thread overview]
Message-ID: <aD13mzN_61fC4p_0@antec> (raw)
In-Reply-To: <9cbd6d7f-c5d0-4825-9b06-e694d32cdecd@gmail.com>
On Sun, Jun 01, 2025 at 09:17:45PM -0600, Jeff Law wrote:
>
>
> On 5/31/25 12:03 AM, Stafford Horne wrote:
> > In or1k structs are returned from functions using the memory address
> > passed in r3. In the current version of GCC the struct stores changed
> > from r11 (the return value) to r3 the incoming memory address. Both of
> > are valid.
> >
> > Adjust the test to match what GCC is producing now.
> >
> > gcc/testsuite/ChangeLog:
> >
> > * gcc.target/or1k/return-2.c: Fix test.
> Given you're the maintainer of this port it seems like you can self-approve
> and commit this and the long jump offset patch.
Hi Jeff,
Thanks for checking, I usually just like to send out patches to give myself a
bit of a cooling off period and allow anyone to spot obvious issues.
I have pushed these now.
-Stafford
prev parent reply other threads:[~2025-06-02 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-31 6:03 [PATCH] or1k: Fix struct return test Stafford Horne
2025-06-02 3:17 ` Jeff Law
2025-06-02 10:06 ` Stafford Horne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aD13mzN_61fC4p_0@antec \
--to=shorne@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=linux-openrisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.