Re: [PATCH] xen bootloader

[aq <aquynh@gmail.com>]

On 4/29/05, Jeremy Katz <katzj@redhat.com> wrote:
> On Wed, 2005-04-27 at 18:21 +0900, aq wrote:
> > Here is a patch to fix few problems in Xen bootloader you sent to the
> > list yesterday.
> 
> Thanks.  Sorry for the delay in responding, I've been underwater with
> stuff for FC4 test3.
> 
> > list of changes:
> > - make a dummy tools/pygrub/src/__init__.py
> 
> I still don't know why this didn't work, but thanks.
> 
> > - extend filesystem abstraction by adding file_exist() method. this
> > method is used to check for existent of a file given its name. now
> > ext2fs implements this method.
> 
> Great, thanks.  My only comment about the ext2fs code for this is that
> you might as well inline the contents of ext2_file_exist in
> ext2fs_file_exist... you don't gain anything by having that for reuse
> that I can see.

I agree.

By the way, I am working on xfs/jfs/reiserfs module for this code.
Hopefully I will finish soon.

regards,
aq