RE: [PATCH] Makefile uninstall not to remove libxutil

RE: [PATCH] Makefile uninstall not to remove libxutil

[Ian Pratt]

> libxutil is not build and installed by default, so "Makefile 
> uninstall" will not try to remove it. This patch is against -unstable,
> ChangeSet@1.1575

I'd rather we continued to remove it -- the purpose of make uninstall is
to clean up the droppings of even old installs.

Thanks,
Ian
 
> Signed-off-by: Nguyen Anh Quynh <aquynh@gmail.com>
> 
> ===== Makefile 1.94 vs edited =====
> --- 1.94/Makefile       2005-05-25 03:54:03 +09:00
> +++ edited/Makefile     2005-05-28 02:09:46 +09:00
> @@ -160,7 +160,7 @@
>  uninstall:
>         [ -d $(D)/etc/xen ] && mv -f $(D)/etc/xen 
> $(D)/etc/xen.old-$(date +%s)
>         rm -rf $(D)/etc/init.d/xend*
> -       rm -rf $(D)/usr/$(LIBDIR)/libxc* $(D)/usr/$(LIBDIR)/libxutil*
> +       rm -rf $(D)/usr/$(LIBDIR)/libxc*
>         rm -rf $(D)/usr/$(LIBDIR)/python/xen $(D)/usr/include/xen
>         rm -rf $(D)/usr/include/xcs_proto.h $(D)/usr/include/xc.h
>         rm -rf $(D)/usr/sbin/xcs $(D)/usr/sbin/xcsdump 
> $(D)/usr/sbin/xen*
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
> 

Re: [PATCH] Makefile uninstall not to remove libxutil

[aq]

On 5/30/05, Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk> wrote:
> > libxutil is not build and installed by default, so "Makefile
> > uninstall" will not try to remove it. This patch is against -unstable,
> > ChangeSet@1.1575
> 
> I'd rather we continued to remove it -- the purpose of make uninstall is
> to clean up the droppings of even old installs.

Ian, I imagine that you will keep it until 4.0 and even later? That is
odd keep removing something not existent.

If this makes sense, i believe that there are still some cleanups in
"make uninstall" which removes other droppings in older version? Or
this is the only exception?

"make uninstal"l is to remove what "make instal"l do, nothing more.
That is the fact, so please dont change its behaviour.

regards,
aq

[PATCH] Makefile uninstall not to remove libxutil

[aq]

libxutil is not build and installed by default, so "Makefile
uninstall" will not try to remove it. This patch is against -unstable,
ChangeSet@1.1575

Signed-off-by: Nguyen Anh Quynh <aquynh@gmail.com>

===== Makefile 1.94 vs edited =====
--- 1.94/Makefile       2005-05-25 03:54:03 +09:00
+++ edited/Makefile     2005-05-28 02:09:46 +09:00
@@ -160,7 +160,7 @@
 uninstall:
        [ -d $(D)/etc/xen ] && mv -f $(D)/etc/xen $(D)/etc/xen.old-$(date +%s)
        rm -rf $(D)/etc/init.d/xend*
-       rm -rf $(D)/usr/$(LIBDIR)/libxc* $(D)/usr/$(LIBDIR)/libxutil*
+       rm -rf $(D)/usr/$(LIBDIR)/libxc*
        rm -rf $(D)/usr/$(LIBDIR)/python/xen $(D)/usr/include/xen
        rm -rf $(D)/usr/include/xcs_proto.h $(D)/usr/include/xc.h
        rm -rf $(D)/usr/sbin/xcs $(D)/usr/sbin/xcsdump $(D)/usr/sbin/xen*