From: aq <aquynh@gmail.com>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] fix broken ACM
Date: Thu, 23 Jun 2005 17:19:58 +0900 [thread overview]
Message-ID: <9cde8bff050623011933b990e9@mail.gmail.com> (raw)
In-Reply-To: <fcae06f78d0ae10d819b69c26a661955@cl.cam.ac.uk>
On 6/23/05, Keir Fraser <Keir.Fraser@cl.cam.ac.uk> wrote:
>
> On 23 Jun 2005, at 09:04, aq wrote:
>
> > i see, but the problem occurs if we want to compile it. the reason is
> > because you grouped null ops together, but you accidentally hide some
> > structures and variables. also we must enclose the declare of
> > acm_init() in #if (ACM_USE_SECURITY_POLICY = ACM_NULL_POLICY). please
> > see my second patch.
>
> If we build non-NULL security policy then the struct definitions and so
> on are compiled in, because they are in the else clause of the acm
> header file.
yes, that is true. but the default policy is NULL, and we get the
problem compiling the code at the moment. my patch does nothing, just
tries to fix the compiling problem (in default state).
regards,
aq
next prev parent reply other threads:[~2005-06-23 8:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-22 17:40 [PATCH] fix broken ACM aq
2005-06-22 17:51 ` Keir Fraser
2005-06-22 17:52 ` aq
2005-06-23 7:48 ` Keir Fraser
2005-06-23 8:04 ` aq
2005-06-23 8:14 ` Keir Fraser
2005-06-23 8:19 ` aq [this message]
2005-06-22 18:22 ` aq
2005-06-23 3:42 ` Stefan Berger
2005-06-23 3:56 ` aq
2005-06-23 4:18 ` Stefan Berger
2005-06-23 7:56 ` aq
2005-06-23 14:57 ` Stefan Berger
2005-06-23 15:16 ` Keir Fraser
2005-06-23 15:22 ` aq
2005-06-23 15:52 ` Keir Fraser
2005-06-23 22:06 ` aq
2005-06-23 15:56 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cde8bff050623011933b990e9@mail.gmail.com \
--to=aquynh@gmail.com \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.