All of lore.kernel.org
 help / color / mirror / Atom feed
From: aq <aquynh@gmail.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Dan Smith <danms@us.ibm.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	xen-devel@lists.xensource.com
Subject: Re: [PATCH] Convert balloon driver to xenstore
Date: Wed, 3 Aug 2005 12:45:50 +0900	[thread overview]
Message-ID: <9cde8bff05080220456cf22b3b@mail.gmail.com> (raw)
In-Reply-To: <42F02851.4050905@us.ibm.com>

On 8/3/05, Anthony Liguori <aliguori@us.ibm.com> wrote:
> Rusty Russell wrote:
> 
> >On Tue, 2005-08-02 at 06:51 -0700, Dan Smith wrote:
> >
> >
> >Generally, you will want to do a module_init() and initialize your
> >driver.  If it's in domain 0, it needs to be initialized later (the
> >store isn't up yet): the standard way of doing this is a notifier chain.
> >
> >Something like the following:
> >
> >static struct notifier_block store_notify =
> >{
> >       .notifier_call = balloon_setup,
> >};
> >
> >static int balloon_init()
> >{
> >       if (!xen_start_info.store_evtchn)
> >               register_xenstore_notifier(&store_notify);
> >       else
> >               balloon_setup(&store_notify, 0, NULL);
> >       return 0;
> >}
> >
> >
> How does this look?
> 

looks nice to me. why didnt you provice also the patch for balloon ;-)
 
regards,
aq

  reply	other threads:[~2005-08-03  3:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-01 17:19 [PATCH] Convert balloon driver to xenstore Dan Smith
2005-08-02 10:11 ` aq
2005-08-02 13:51   ` Dan Smith
2005-08-03  1:11     ` Rusty Russell
2005-08-03  2:13       ` Anthony Liguori
2005-08-03  3:45         ` aq [this message]
2005-08-03  5:18           ` Anthony Liguori
2005-08-03  8:02 ` aq
2005-08-03 13:47   ` Dan Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9cde8bff05080220456cf22b3b@mail.gmail.com \
    --to=aquynh@gmail.com \
    --cc=aliguori@us.ibm.com \
    --cc=danms@us.ibm.com \
    --cc=rusty@rustcorp.com.au \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.