From: Paolo Abeni <pabeni at redhat.com>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH net-next v2] mptcp: be careful on MPTCP-level ack.
Date: Wed, 02 Dec 2020 18:08:11 +0100 [thread overview]
Message-ID: <9d40955d2d33dd36f8bc38067868c19dd8cb5173.camel@redhat.com> (raw)
In-Reply-To: 0c400986125dfdd42990ee4203a60d9b309d29c8.camel@redhat.com
[-- Attachment #1: Type: text/plain, Size: 681 bytes --]
On Wed, 2020-12-02 at 17:51 +0100, Paolo Abeni wrote:
> On Wed, 2020-12-02 at 17:45 +0100, Eric Dumazet wrote:
> > Packetdrill recvmsg syntax would be something like
> >
> > +0 recvmsg(3, {msg_name(...)=...,
> > msg_iov(1)=[{..., 0}],
> > msg_flags=0
> > }, 0) = 0
>
> Thank you very much for all the effort!
>
> Yes, with recvmsg() the packet drill hangs. I agree your proposed fix
> is correct.
>
> I can test it explicitly later today.
The proposed fix passes successfully the pktdrill test and there are no
regressions in the other self-tests.
Feel free to add:
Tested-by: Paolo Abeni <pabeni(a)redhat.com>
thanks!
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Abeni <pabeni@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>, netdev@vger.kernel.org
Cc: Jakub Kicinski <kuba@kernel.org>, mptcp@lists.01.org
Subject: Re: [MPTCP] Re: [PATCH net-next v2] mptcp: be careful on MPTCP-level ack.
Date: Wed, 02 Dec 2020 18:08:11 +0100 [thread overview]
Message-ID: <9d40955d2d33dd36f8bc38067868c19dd8cb5173.camel@redhat.com> (raw)
In-Reply-To: <0c400986125dfdd42990ee4203a60d9b309d29c8.camel@redhat.com>
On Wed, 2020-12-02 at 17:51 +0100, Paolo Abeni wrote:
> On Wed, 2020-12-02 at 17:45 +0100, Eric Dumazet wrote:
> > Packetdrill recvmsg syntax would be something like
> >
> > +0 recvmsg(3, {msg_name(...)=...,
> > msg_iov(1)=[{..., 0}],
> > msg_flags=0
> > }, 0) = 0
>
> Thank you very much for all the effort!
>
> Yes, with recvmsg() the packet drill hangs. I agree your proposed fix
> is correct.
>
> I can test it explicitly later today.
The proposed fix passes successfully the pktdrill test and there are no
regressions in the other self-tests.
Feel free to add:
Tested-by: Paolo Abeni <pabeni@redhat.com>
thanks!
Paolo
next reply other threads:[~2020-12-02 17:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 17:08 Paolo Abeni [this message]
2020-12-02 17:08 ` [MPTCP] Re: [PATCH net-next v2] mptcp: be careful on MPTCP-level ack Paolo Abeni
-- strict thread matches above, loose matches on Subject: below --
2020-12-02 16:51 Paolo Abeni
2020-12-02 16:51 ` Paolo Abeni
2020-12-02 16:45 [MPTCP] " Eric Dumazet
2020-12-02 16:45 ` Eric Dumazet
2020-12-02 16:32 [MPTCP] " Eric Dumazet
2020-12-02 16:32 ` Eric Dumazet
2020-12-02 16:30 [MPTCP] " Eric Dumazet
2020-12-02 16:30 ` Eric Dumazet
2020-12-02 16:10 [MPTCP] " Eric Dumazet
2020-12-02 16:10 ` Eric Dumazet
2020-12-02 15:37 [MPTCP] " Paolo Abeni
2020-12-02 15:37 ` Paolo Abeni
2020-12-02 13:18 [MPTCP] " Eric Dumazet
2020-12-02 13:18 ` Eric Dumazet
2020-11-25 21:37 [MPTCP] " Jakub Kicinski
2020-11-25 21:37 ` Jakub Kicinski
2020-11-24 21:51 [MPTCP] " Paolo Abeni
2020-11-24 21:51 ` Paolo Abeni
2020-11-24 15:03 [MPTCP] " Paolo Abeni
2020-11-24 14:25 Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d40955d2d33dd36f8bc38067868c19dd8cb5173.camel@redhat.com \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.