From: Martin KaFai Lau <martin.lau@linux.dev>
To: Hoyeon Lee <hoyeon.lee@suse.com>
Cc: Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [bpf-next v1 1/5] selftests/bpf: use sockaddr_storage instead of addr_port in cls_redirect test
Date: Tue, 18 Nov 2025 15:12:13 -0800 [thread overview]
Message-ID: <9ed9de08-9a5b-4fc9-9213-ca918dafea0b@linux.dev> (raw)
In-Reply-To: <20251115225550.1086693-2-hoyeon.lee@suse.com>
On 11/15/25 2:55 PM, Hoyeon Lee wrote:
> struct tuple {
> int family;
The "family" is not needed either. Just use the ss_family from src or
dst. The 'struct tuple' can be removed also?
I'm on the fence about whether this "struct sockaddr_storage" change is
worth the code churn. Are patch 1 and 2 the only tests that need this
change?
Patch 3 and 4 make sense. Patch 3 and 4 are applied.
Please post patch 5 as a separate patch on its own.
> - struct addr_port src;
> - struct addr_port dst;
> + struct sockaddr_storage src;
> + struct sockaddr_storage dst;
> };
next prev parent reply other threads:[~2025-11-18 23:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-15 22:55 [bpf-next v1 0/5] selftests/bpf: networking test cleanups and build fix Hoyeon Lee
2025-11-15 22:55 ` [bpf-next v1 1/5] selftests/bpf: use sockaddr_storage instead of addr_port in cls_redirect test Hoyeon Lee
2025-11-18 23:12 ` Martin KaFai Lau [this message]
2025-11-19 3:09 ` Hoyeon Lee
2025-11-19 16:57 ` Martin KaFai Lau
2025-11-15 22:55 ` [bpf-next v1 2/5] selftests/bpf: use sockaddr_storage instead of sa46 in select_reuseport test Hoyeon Lee
2025-11-15 22:55 ` [bpf-next v1 3/5] selftests/bpf: move common TCP helpers into bpf_tracing_net.h Hoyeon Lee
2025-11-15 22:55 ` [bpf-next v1 4/5] selftests/bpf: replace TCP CC string comparisons with bpf_strncmp Hoyeon Lee
2025-11-15 22:55 ` [bpf-next v1 5/5] selftests/bpf: propagate LLVM toolchain to runqslower build Hoyeon Lee
2025-11-17 6:04 ` Yonghong Song
2025-11-17 6:37 ` Hoyeon Lee
2025-11-17 23:16 ` [bpf-next v1 0/5] selftests/bpf: networking test cleanups and build fix Amery Hung
2025-11-18 23:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ed9de08-9a5b-4fc9-9213-ca918dafea0b@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=hoyeon.lee@suse.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.