Re: [PATCH 4/8] mm/slab: introduce kfree_rcu_nolock()

["Vlastimil Babka (SUSE)" <vbabka@kernel.org>]

On 4/16/26 11:10, Harry Yoo (Oracle) wrote:
> +#ifndef CONFIG_KVFREE_RCU_BATCHED
> +void kvfree_call_rcu_head(struct rcu_head *head, void *ptr, bool allow_spin)
> +{
> +	if (!allow_spin) {
> +		struct kfree_rcu_cpu *krcp;
> +
> +		guard(preempt)();
> +
> +		krcp = this_cpu_ptr(&krc);
> +		if (llist_add((struct llist_node *)head, &krcp->defer_head))
> +			irq_work_queue(&krcp->defer_free);
> +		return;
> +	}
> +

Given "allow_spin" is compile-time constant, it would make more sense to
have different functions for each variant rather than calling a common one
with the extra param?

>  	if (head) {
>  		kasan_record_aux_stack(ptr);
>  		call_rcu(head, kvfree_rcu_cb);