[PATCH mptcp-net] MAINTAINERS: add Geliang as reviewer for MPTCP

[PATCH mptcp-net] MAINTAINERS: add Geliang as reviewer for MPTCP

[Matthieu Baerts]

For a long time now, Geliang has contributed to a lot of code and
reviews related to MPTCP. So let's reflect that in the MAINTAINERS file.

This should also encourage patch submitters to add him to the CC list.

Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
---

@Geliang: do you mind publicly acking this patch if you are still OK
with that?
Cc: Geliang Tang <geliang.tang@linux.dev>

@Mat: can I also add your Acked-by as discussed this week?
Cc: Mat Martineau <martineau@kernel.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 49c1caad5d99..b7e51b7b8760 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15076,6 +15076,7 @@ K:	\bmdo_
 NETWORKING [MPTCP]
 M:	Matthieu Baerts <matttbe@kernel.org>
 M:	Mat Martineau <martineau@kernel.org>
+R:	Geliang Tang <geliang.tang@linux.dev>
 L:	netdev@vger.kernel.org
 L:	mptcp@lists.linux.dev
 S:	Maintained

---
base-commit: 84d8fb414b2a78b32e97b1e4888688bca82aecf5
change-id: 20231215-mptcp-reviewers-geliang-4d826ebffd8c

Best regards,
-- 
Matthieu Baerts <matttbe@kernel.org>

Re: [PATCH mptcp-net] MAINTAINERS: add Geliang as reviewer for MPTCP

[Geliang Tang]

On Fri, 2023-12-15 at 15:45 +0100, Matthieu Baerts wrote:
> For a long time now, Geliang has contributed to a lot of code and
> reviews related to MPTCP. So let's reflect that in the MAINTAINERS
> file.
> 
> This should also encourage patch submitters to add him to the CC
> list.
> 
> Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
> ---
> 
> @Geliang: do you mind publicly acking this patch if you are still OK
> with that?
> Cc: Geliang Tang <geliang.tang@linux.dev>

Thanks Matt.

Acked-by: Geliang Tang <geliang.tang@linux.dev>

> 
> @Mat: can I also add your Acked-by as discussed this week?
> Cc: Mat Martineau <martineau@kernel.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 49c1caad5d99..b7e51b7b8760 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15076,6 +15076,7 @@ K:      \bmdo_
>  NETWORKING [MPTCP]
>  M:     Matthieu Baerts <matttbe@kernel.org>
>  M:     Mat Martineau <martineau@kernel.org>
> +R:     Geliang Tang <geliang.tang@linux.dev>
>  L:     netdev@vger.kernel.org
>  L:     mptcp@lists.linux.dev
>  S:     Maintained
> 
> ---
> base-commit: 84d8fb414b2a78b32e97b1e4888688bca82aecf5
> change-id: 20231215-mptcp-reviewers-geliang-4d826ebffd8c
> 
> Best regards,

Re: MAINTAINERS: add Geliang as reviewer for MPTCP: Tests Results

[MPTCP CI]

Hi Matthieu,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal (except selftest_mptcp_join):
  - Success! ✅:
  - Task: https://cirrus-ci.com/task/5056554173464576
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5056554173464576/summary/summary.txt

- KVM Validation: debug (except selftest_mptcp_join):
  - Success! ✅:
  - Task: https://cirrus-ci.com/task/5102919788265472
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5102919788265472/summary/summary.txt

- KVM Validation: normal (only selftest_mptcp_join):
  - Success! ✅:
  - Task: https://cirrus-ci.com/task/6182454080307200
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/6182454080307200/summary/summary.txt

- KVM Validation: debug (only selftest_mptcp_join):
  - Unstable: 1 failed test(s): selftest_mptcp_join 🔴:
  - Task: https://cirrus-ci.com/task/6745404033728512
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/6745404033728512/summary/summary.txt

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/7573d23cb3e5


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-debug

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)

Re: [PATCH mptcp-net] MAINTAINERS: add Geliang as reviewer for MPTCP

[Mat Martineau]

On Fri, 15 Dec 2023, Matthieu Baerts wrote:

> For a long time now, Geliang has contributed to a lot of code and
> reviews related to MPTCP. So let's reflect that in the MAINTAINERS file.
>
> This should also encourage patch submitters to add him to the CC list.
>
> Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
> ---
>
> @Geliang: do you mind publicly acking this patch if you are still OK
> with that?
> Cc: Geliang Tang <geliang.tang@linux.dev>
>
> @Mat: can I also add your Acked-by as discussed this week?
> Cc: Mat Martineau <martineau@kernel.org>

Certainly!

Acked-by: Mat Martineau <martineau@kernel.org>

> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 49c1caad5d99..b7e51b7b8760 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15076,6 +15076,7 @@ K:	\bmdo_
> NETWORKING [MPTCP]
> M:	Matthieu Baerts <matttbe@kernel.org>
> M:	Mat Martineau <martineau@kernel.org>
> +R:	Geliang Tang <geliang.tang@linux.dev>
> L:	netdev@vger.kernel.org
> L:	mptcp@lists.linux.dev
> S:	Maintained
>
> ---
> base-commit: 84d8fb414b2a78b32e97b1e4888688bca82aecf5
> change-id: 20231215-mptcp-reviewers-geliang-4d826ebffd8c
>
> Best regards,
> -- 
> Matthieu Baerts <matttbe@kernel.org>
>
>

Re: MAINTAINERS: add Geliang as reviewer for MPTCP: Tests Results

[MPTCP CI]

Hi Matthieu,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal (except selftest_mptcp_join):
  - Success! ✅:
  - Task: https://cirrus-ci.com/task/5636453443567616
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5636453443567616/summary/summary.txt

- KVM Validation: debug (only selftest_mptcp_join):
  - Unstable: 1 failed test(s): selftest_mptcp_join 🔴:
  - Task: https://cirrus-ci.com/task/4792028513435648
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/4792028513435648/summary/summary.txt

- KVM Validation: debug (except selftest_mptcp_join):
  - Success! ✅:
  - Task: https://cirrus-ci.com/task/6199403396988928
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/6199403396988928/summary/summary.txt

- KVM Validation: normal (only selftest_mptcp_join):
  - Success! ✅:
  - Task: https://cirrus-ci.com/task/5073503490146304
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5073503490146304/summary/summary.txt

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/006888d29030


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-debug

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)

Re: [PATCH mptcp-net] MAINTAINERS: add Geliang as reviewer for MPTCP

[Matthieu Baerts]

Hi Geliang, Mat,

On 15/12/2023 15:45, Matthieu Baerts wrote:
> For a long time now, Geliang has contributed to a lot of code and
> reviews related to MPTCP. So let's reflect that in the MAINTAINERS file.
> 
> This should also encourage patch submitters to add him to the CC list.

Thank you for your ACK!

Now in our tree ("fixes" for -net):

New patches for t/upstream-net and t/upstream:
- 6f7b2f2a1d67: MAINTAINERS: add Geliang as reviewer for MPTCP
- Results: e16ff7eaad4e..c09cb0246e41 (export-net)
- Results: 79ba5831f60e..9adfb88a4930 (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export-net/20231219T122647
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20231219T122647

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.