From: Keir Fraser <keir@xensource.com>
To: Jan Beulich <jbeulich@novell.com>, xen-devel@lists.xensource.com
Subject: Re: hvm_decode() questions
Date: Fri, 24 Nov 2006 14:08:16 +0000 [thread overview]
Message-ID: <C18CAD50.4FCB%keir@xensource.com> (raw)
In-Reply-To: <456709DE.76E4.0078.0@novell.com>
On 24/11/06 14:03, "Jan Beulich" <jbeulich@novell.com> wrote:
> 1) single-byte opcode 0x87 (xchg): What is this strange conditional
>
> if ( ((*(opcode+1)) & 0xc7) == 5 )
>
> supposed to address? xchg has absolutely symmetric operands.
>
> 2) two-byte opcode 0xB7 (movzx): What is this dependency on rex
> bit 3 doing here? Apparently this was based on Intel's (broken)
> documentation - the source operand is always 16 bits.
>
> Unless someone can explain these, I'll send a patch to remove them.
Yes, these can both be removed.
-- Keir
next prev parent reply other threads:[~2006-11-24 14:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-24 14:03 hvm_decode() questions Jan Beulich
2006-11-24 14:08 ` Keir Fraser [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-11-24 14:07 Li, Xin B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C18CAD50.4FCB%keir@xensource.com \
--to=keir@xensource.com \
--cc=jbeulich@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.