All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir@xensource.com>
To: "Stephen C. Tweedie" <sct@redhat.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: Re: [Patch] Constrain DMADOM/swiotlb allocations to 1G phys to fix b44 NIC driver
Date: Tue, 28 Nov 2006 16:01:20 +0000	[thread overview]
Message-ID: <C1920DD0.52C1%keir@xensource.com> (raw)
In-Reply-To: <1164728964.10380.19.camel@sisko.scot.redhat.com>




On 28/11/06 15:49, "Stephen C. Tweedie" <sct@redhat.com> wrote:

>> It turns out that this 2GB / 31-bit constraint is magically hardcoded in
>> a couple of places rather than being read correctly from config.h.  So
>> this patch fixes that; changes config.h to specify a 1GB / 30-bit
>> constraint for the DMADOM heap; and changes the x86/x86_64 swiotlb to
>> request a 30-bit constraint for allocations of the swiotlb memory.
> 
> The 30 bit constraint is enough to let b44 work.  But there are a number
> of sound cards which require a 28-bit DMA mask (256MB max physical
> addressable memory).  1GB seems reasonably safe, but I'm much less
> comfortable with restricting DMADOM to 256MB by default.  Does anyone
> have any strong feelings about shifting this?  What other users of
> DMADOM are there that might overflow if we restrict it even further?

We could make bit-width of the DMA allocator in Xen a boot parameter. And we
could make the bit-width of the SWIOTLB allocations a Linux boot parameter.
Then those that care can do the necessary cmdline hacking.

I'd be tempted to recommend this for b44 users too, and leave the default
bit-width as 31. I'm not convinced there can be that many who are using Xen.
But maybe the chipset is more common than I think.

 -- Keir

  reply	other threads:[~2006-11-28 16:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-28 15:46 [Patch] Constrain DMADOM/swiotlb allocations to 1G phys to fix b44 NIC driver Stephen C. Tweedie
2006-11-28 15:49 ` Stephen C. Tweedie
2006-11-28 16:01   ` Keir Fraser [this message]
2006-11-28 16:31   ` Alan
2006-11-28 16:29     ` Muli Ben-Yehuda
2006-11-29  0:26       ` Re: [Patch] Constrain DMADOM/swiotlb allocations to1G " Ian Pratt
2006-11-28 16:33     ` Re: [Patch] Constrain DMADOM/swiotlb allocations to 1G " Keir Fraser
2006-11-28 15:54 ` Keir Fraser
2006-11-28 16:28   ` Alan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C1920DD0.52C1%keir@xensource.com \
    --to=keir@xensource.com \
    --cc=sct@redhat.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.