From: Keir Fraser <keir@xensource.com>
To: "Santos, Jose Renato G" <joserenato.santos@hp.com>,
Keir Fraser <keir@xensource.com>,
"Apparao, Padmashree K" <padmashree.k.apparao@intel.com>,
xen-devel@lists.xensource.com
Cc: "Turner, Yoshio" <yoshio_turner@hp.com>,
Jose Renato Santos <jsantos@hpl.hp.com>,
G John Janakiraman <john@arivalai.hpl.hp.com>
Subject: Re: [PATCH] Reduce overhead in find_domain_by_id() [0/2]
Date: Thu, 07 Dec 2006 12:01:46 +0000 [thread overview]
Message-ID: <C19DB32A.5AAE%keir@xensource.com> (raw)
In-Reply-To: <08CA2245AFCF444DB3AC415E47CC40AF5086EA@G3W0072.americas.hpqcorp.net>
On 7/12/06 03:49, "Santos, Jose Renato G" <joserenato.santos@hp.com> wrote:
> Can't think of anything else. If you want I can remove these and submit
> a revised patch.
> It seems that there is not much more we could remove. Not sure if you
> have something else in mind...
I suppose the patch isn't actually as big as I first imagined. I'll review
it and probably apply it pretty much as is. It's just that RCU has always
seemed rather over complicated to me (lots of different queues, for example)
for what should be a rather simple concept to implement. This is possibly
just ignorance on my part. :-)
As for per-cpu refcounts, I suspect a better scheme would be
find_domain_by_id_noref(). Idea being that often we take a reference for a
short period of time (in particular, scope of one function) and with delayed
destruction we can now safely use a found domain pointer with no refcnt
increment.
-- Keir
next prev parent reply other threads:[~2006-12-07 12:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-06 11:52 [PATCH] Reduce overhead in find_domain_by_id() [0/2] Apparao, Padmashree K
2006-12-06 12:12 ` Keir Fraser
2006-12-07 3:49 ` Santos, Jose Renato G
2006-12-07 12:01 ` Keir Fraser [this message]
2006-12-08 4:17 ` Santos, Jose Renato G
-- strict thread matches above, loose matches on Subject: below --
2006-12-06 1:35 Santos, Jose Renato G
2006-12-06 8:43 ` Keir Fraser
2006-12-06 10:41 ` Emmanuel Ackaouy
2006-12-07 4:07 ` Santos, Jose Renato G
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C19DB32A.5AAE%keir@xensource.com \
--to=keir@xensource.com \
--cc=john@arivalai.hpl.hp.com \
--cc=joserenato.santos@hp.com \
--cc=jsantos@hpl.hp.com \
--cc=padmashree.k.apparao@intel.com \
--cc=xen-devel@lists.xensource.com \
--cc=yoshio_turner@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.