From: Keir Fraser <keir@xensource.com>
To: Akio Takebe <takebe_akio@jp.fujitsu.com>, xen-devel@lists.xensource.com
Subject: Re: [Patch] cleanup pciback_reset_device
Date: Mon, 18 Dec 2006 09:33:33 +0000 [thread overview]
Message-ID: <C1AC10ED.5FF5%keir@xensource.com> (raw)
In-Reply-To: <2AC72285D84C8Dtakebe_akio@jp.fujitsu.com>
On 18/12/06 9:21 am, "Akio Takebe" <takebe_akio@jp.fujitsu.com> wrote:
> This patch is for cleanup of pciback_reset_device.
> is_enabled=0 and is_busmaster=0 are not necessary
> because pci_disable_device() do them.
If you are zapping the command register then doesn't it makes sense to zap
the software flags relating to that at the same time, even if that sometimes
happens to be redundant? It certainly means we can be sure they won't get
out of sync.
-- Keir
next prev parent reply other threads:[~2006-12-18 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-18 9:21 [Patch] cleanup pciback_reset_device Akio Takebe
2006-12-18 9:33 ` Keir Fraser [this message]
2006-12-18 13:26 ` Akio Takebe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C1AC10ED.5FF5%keir@xensource.com \
--to=keir@xensource.com \
--cc=takebe_akio@jp.fujitsu.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.