From: Keir Fraser <keir@xensource.com>
To: Christoph Egger <Christoph.Egger@amd.com>, xen-devel@lists.xensource.com
Subject: Re: RFC: vaddr_t and vsize_t
Date: Wed, 17 Jan 2007 16:51:58 +0000 [thread overview]
Message-ID: <C1D404AE.7C3D%keir@xensource.com> (raw)
In-Reply-To: <200701171721.27064.Christoph.Egger@amd.com>
On 17/1/07 16:21, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
> This stuff is about removing a place where programmers can make mistakes.
> vaddr_t also avoids void * arithmetics. It should be possible then to use
> -Wpointer-arith.
A bunch of our void* arithmetic comes from files we keep in sync with Linux.
So we'd really need Linux to clean this up before we use -Wpointer-arith, or
we have to do extra porting effort to keep files in sync.
I suppose I don't mind vaddr_t being defined and people using it if they
want to. At least it is probably clearer that translation to/from char* or
long to do pointer arithmetic. However, I'm less sure about a wholesale
conversion of Xen away from use of 'unsigned long'.
-- Keir
next prev parent reply other threads:[~2007-01-17 16:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-17 15:17 RFC: vaddr_t and vsize_t Christoph Egger
2007-01-17 15:49 ` Keir Fraser
2007-01-17 16:21 ` Christoph Egger
2007-01-17 16:51 ` Keir Fraser [this message]
2007-01-18 7:13 ` Christoph Egger
2007-01-18 7:31 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C1D404AE.7C3D%keir@xensource.com \
--to=keir@xensource.com \
--cc=Christoph.Egger@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.