From: Keir Fraser <keir@xensource.com>
To: Gerd Hoffmann <kraxel@suse.de>, Keir Fraser <keir@xensource.com>
Cc: Xen devel list <xen-devel@lists.xensource.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: 32-on-64: pvfb issue
Date: Fri, 19 Jan 2007 15:22:01 +0000 [thread overview]
Message-ID: <C1D69299.7E50%keir@xensource.com> (raw)
In-Reply-To: <45B0DEFF.3060607@suse.de>
On 19/1/07 15:08, "Gerd Hoffmann" <kraxel@suse.de> wrote:
>> And magic numbers
>> suck compared with intelligible strings for this kind of thing imo.
>
> We'll need both then. Strings are certainly nice for human-visible
> stuff, but you don't want to strcmp() all the time in the backend.
> Wouldn't be a problem for pvfb, but for blkfront/back where the ring
> protocol is abi-dependent and thus the backend has to check often.
You missed out the patch. I'm sure however that I'll argue you should make
the enumeration local to the backend. It will always support his native
architecture. Where it supports cross-architecture (i386-on-x64) he can
*privately* have a numeric assignment for that situation which it uses on
data paths. Then we don't have redundant info in xenstore and we don't get
tied to particular magic numbers.
But I definitely agree that a private enumeration, or sets of accessor hook
functions, makes sense. We'll certainly need one or the other for
efficiency.
-- Keir
next prev parent reply other threads:[~2007-01-19 15:22 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-18 13:57 32-on-64: pvfb issue Gerd Hoffmann
2007-01-18 14:07 ` Keir Fraser
2007-01-18 15:00 ` Markus Armbruster
2007-01-18 15:35 ` Gerd Hoffmann
2007-01-18 15:53 ` Daniel P. Berrange
2007-01-18 16:34 ` Gerd Hoffmann
2007-01-18 16:55 ` Gerd Hoffmann
2007-01-18 17:05 ` Daniel P. Berrange
2007-01-18 18:31 ` Keir Fraser
2007-01-19 9:46 ` Gerd Hoffmann
2007-01-19 9:54 ` Gerd Hoffmann
2007-01-19 10:31 ` Markus Armbruster
2007-01-19 10:46 ` Gerd Hoffmann
2007-01-19 11:53 ` Markus Armbruster
2007-01-19 11:10 ` Keir Fraser
2007-01-19 11:43 ` Gerd Hoffmann
2007-01-19 12:01 ` Keir Fraser
2007-01-19 12:59 ` Gerd Hoffmann
2007-01-19 13:45 ` Keir Fraser
2007-01-19 15:08 ` Gerd Hoffmann
2007-01-19 15:22 ` Keir Fraser [this message]
2007-01-19 15:31 ` Gerd Hoffmann
2007-01-19 16:05 ` Keir Fraser
2007-01-20 0:09 ` [Patch] [VTPM_TOOLS] Add HVM support to vtpm_manager Scarlata, Vincent R
2007-01-22 7:50 ` 32-on-64: pvfb issue Gerd Hoffmann
2007-01-22 14:01 ` Gerd Hoffmann
2007-01-22 14:48 ` Keir Fraser
2007-01-23 12:53 ` Gerd Hoffmann
2007-01-23 15:07 ` Keir Fraser
2007-01-23 15:56 ` Gerd Hoffmann
2007-01-24 11:23 ` Gerd Hoffmann
2007-01-24 12:02 ` Keir Fraser
2007-01-24 12:24 ` Markus Armbruster
2007-01-24 12:38 ` Gerd Hoffmann
2007-01-24 14:24 ` Markus Armbruster
2007-01-24 15:25 ` Gerd Hoffmann
2007-01-25 13:16 ` 32-on-64 broken in unstable Gerd Hoffmann
2007-01-25 13:25 ` Keir Fraser
2007-01-25 13:34 ` Gerd Hoffmann
2007-01-22 15:22 ` 32-on-64: pvfb issue Markus Armbruster
2007-01-22 15:33 ` Gerd Hoffmann
2007-01-22 15:40 ` Keir Fraser
2007-01-19 16:06 ` Markus Armbruster
2007-01-22 7:56 ` Gerd Hoffmann
2007-01-19 10:43 ` Ian Campbell
2007-01-19 12:03 ` Markus Armbruster
2007-01-22 18:32 ` Does vt-x itself have perf. impact on Hypervisor w/o considering HVM? Liang Yang
2007-01-23 10:05 ` [Xen-users] " Petersson, Mats
2007-01-23 16:15 ` Liang Yang
2007-01-23 16:33 ` Petersson, Mats
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C1D69299.7E50%keir@xensource.com \
--to=keir@xensource.com \
--cc=armbru@redhat.com \
--cc=kraxel@suse.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.