From: Keir Fraser <keir@xensource.com>
To: Jan Beulich <jbeulich@novell.com>, xen-devel@lists.xensource.com
Subject: Re: page ownership
Date: Thu, 08 Mar 2007 10:23:15 +0000 [thread overview]
Message-ID: <C2159493.B068%keir@xensource.com> (raw)
In-Reply-To: <45EFEF3B.76E4.0078.0@novell.com>
On 8/3/07 10:10, "Jan Beulich" <jbeulich@novell.com> wrote:
> Is there a particular reason why page_set_owner(pg, NULL) is
> - not used in free_domheap_pages()?
It's done in __alloc_domheap_pages() instead. Arguably moving it would be
cleaner.
> - only used on pages 1 ... ((1 << order) - 1) in __alloc_domheap_pages()?
Page 0 is done outside the loop, and writes directly to _domain for no
particularly good reason. I guess I implemented the first iteration outside
the loop to special-case initialisation of the tlbflush cpumask. Which
probably isn't a very worthwhile optimisation, to be honest.
I'll do a little cleanup here. It would certainly be sane to not have random
domain pointers hanging around in freed pages.
-- Keir
prev parent reply other threads:[~2007-03-08 10:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-08 10:10 page ownership Jan Beulich
2007-03-08 10:23 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C2159493.B068%keir@xensource.com \
--to=keir@xensource.com \
--cc=jbeulich@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.