Re: [PATCH][HVM] fix VNIF restore failure on HVM guest with heavy workload

[Keir Fraser <keir@xensource.com>]

On 10/4/07 17:47, "Zhai, Edwin" <edwin.zhai@intel.com> wrote:

> [PATCH][HVM] fix VNIF restore failure on HVM guest with heavy workload
> 
> Signed-off-by: Zhai Edwin <edwin.zhai@intel.com>
> 
> VNIF has many intrs when save/restore with net workload, so need keep handler
> from intrs

What happens if an interrupt is being processed during save/restore? It
would be nice to know what the underlying bug is!

That said, it may well make sense to somehow disable interrupt handling
across save/restore. Unfortunately your patch is insufficient since we could
handle event-channel interrupts on any VCPU (the irq's affinity can be
changed outside our control if it is routed through the virtual IOAPIC, and
if e.g. the userspace irqbalance daemon is running).

I wanted to use stop_machine_run() but unfortunately it isn't exported to
modules. :-( irq_disable() may do the right thing for us though.

 -- Keir