c/s 14921

All of lore.kernel.org
 help / color / mirror / Atom feed

* c/s 14921
@ 2007-04-25  7:29 Jan Beulich
  2007-04-25  8:46 ` Keir Fraser
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2007-04-25  7:29 UTC (permalink / raw)
  To: Ian Campbell; +Cc: xen-devel

Ian,

the change from testb to cmp in this patch is incorrect - suffix-less cmp with no register operands defaults to 32-bit operand size (and I consider it a flaw of gas to not warn about this), this needs to be cmpb.

Jan

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: c/s 14921
  2007-04-25  7:29 c/s 14921 Jan Beulich
@ 2007-04-25  8:46 ` Keir Fraser
  0 siblings, 0 replies; 2+ messages in thread
From: Keir Fraser @ 2007-04-25  8:46 UTC (permalink / raw)
  To: Jan Beulich, Ian Campbell; +Cc: xen-devel

Fixed, thanks.

On 25/4/07 08:29, "Jan Beulich" <jbeulich@novell.com> wrote:

> Ian,
> 
> the change from testb to cmp in this patch is incorrect - suffix-less cmp with
> no register operands defaults to 32-bit operand size (and I consider it a flaw
> of gas to not warn about this), this needs to be cmpb.
> 
> Jan
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-04-25  8:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-25  7:29 c/s 14921 Jan Beulich
2007-04-25  8:46 ` Keir Fraser

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.