Re: Re: [PATCH] [ACM] Comilation fix for 32 bit

[Keir Fraser <keir@xensource.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1084 bytes --]

On 26/4/07 11:49, "Stefan Berger" <stefanb@us.ibm.com> wrote:

>> > You're better off keeping the GUEST_HANDLE_64() and getting rid of the
>> > compat acm stuff. As far as I can see, all your interfaces are *currently*
>> > 32/64-bit invariant. So the compat stuff can safely be removed and then you
>> > don't need to continually keep it sync.
> 
> I was going to ask you about this. I am writing on a patch that puts all the
> ACM hypercall structures into a union. I am wondering what the compat stuff is
> for (xen/common/compat) and what the criterion is for needing this compat
> code. 
> 
If you have structures that differ in layout in 32-bit mode vs. 64-bit mode
then you need a compat shim when running 32-bit dom0 on 64-bit Xen (which we
support doing nowadays). Currently you have no such issues that I¹m aware
of. You should be able to delete the compat stuff that is there currently
with no problems.

Is the build failure in Xen itself or in tools? I¹m sure it¹s easily fixed
without needing to throw away the GUEST_HANDLE_64() usage.

 -- Keir


[-- Attachment #1.2: Type: text/html, Size: 1647 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel