From: Keir Fraser <keir@xensource.com>
To: Jake Wires <Jake.Wires@xensource.com>,
Mark McLoughlin <markmc@redhat.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] Segments can span multiple clusters withtap:qcow
Date: Thu, 03 May 2007 18:40:39 +0100 [thread overview]
Message-ID: <C25FDD27.E5EB%keir@xensource.com> (raw)
In-Reply-To: <A9AD3C3BCF83FD4182B7D4D99E37FAD819F840@exchrdm.ad.xensource.com>
On 3/5/07 02:06, "Jake Wires" <Jake.Wires@xensource.com> wrote:
> This patch is back to only allocating enough requests for one segment:
>
> + /* A segment (i.e. a page) can span multiple clusters */
> + s->max_aio_reqs = (getpagesize() / s->cluster_size) + 1;
>
> In fact, this code allocates exactly two AIO requests for QCoW images
> created by qcow-create, which have a default cluster size of 4K.
What shall we do -- revert the whole patch or fix this line?
-- Keir
next prev parent reply other threads:[~2007-05-03 17:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-25 20:41 [PATCH] Segments can span multiple clusters with tap:qcow Mark McLoughlin
2007-04-26 9:09 ` Keir Fraser
2007-04-26 9:18 ` Mark McLoughlin
2007-04-26 10:00 ` Keir Fraser
2007-04-26 10:21 ` Mark McLoughlin
2007-05-03 1:06 ` [PATCH] Segments can span multiple clusters withtap:qcow Jake Wires
2007-05-03 17:40 ` Keir Fraser [this message]
2007-05-03 17:47 ` Mark McLoughlin
2007-05-03 17:54 ` Mark McLoughlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C25FDD27.E5EB%keir@xensource.com \
--to=keir@xensource.com \
--cc=Jake.Wires@xensource.com \
--cc=markmc@redhat.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.