From: Keir Fraser <keir@xensource.com>
To: Mark McLoughlin <markmc@redhat.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] Segments can span multiple clusters with tap:qcow
Date: Thu, 26 Apr 2007 11:00:54 +0100 [thread overview]
Message-ID: <C25636E6.DF42%keir@xensource.com> (raw)
In-Reply-To: <1177579115.3487.27.camel@blaa>
On 26/4/07 10:18, "Mark McLoughlin" <markmc@redhat.com> wrote:
>> The current code allocates aio-request info for every segment in a request
>> ring (MAX_AIO_REQUESTS == BLK_RING_SIZE * MAX_SEGMENTS_PER_REQUEST). This
>> patch seems to take into account that each segment (part-of-page) can itself
>> be split into clusters, hence the page_size/cluster_size calculation, but
>> shouldn't this be multiplied by the existing MAX_AIO_REQUESTS? Otherwise you
>> provide only enough aio requests for one segment at a time, rather than a
>> request ring's worth of segments?
>
> Absolutely, well spotted. I fixed that typo after testing, but
> obviously forgot to run "quilt refresh" before sending ...
>
> Fixed version attached.
This one doesn't build (free_aio_state: line 164: structure has no member
named 'private'). Perhaps free_aio_state() should take a 'struct
disk_driver' rather than a 'struct td_state'?
-- Keir
next prev parent reply other threads:[~2007-04-26 10:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-25 20:41 [PATCH] Segments can span multiple clusters with tap:qcow Mark McLoughlin
2007-04-26 9:09 ` Keir Fraser
2007-04-26 9:18 ` Mark McLoughlin
2007-04-26 10:00 ` Keir Fraser [this message]
2007-04-26 10:21 ` Mark McLoughlin
2007-05-03 1:06 ` [PATCH] Segments can span multiple clusters withtap:qcow Jake Wires
2007-05-03 17:40 ` Keir Fraser
2007-05-03 17:47 ` Mark McLoughlin
2007-05-03 17:54 ` Mark McLoughlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C25636E6.DF42%keir@xensource.com \
--to=keir@xensource.com \
--cc=markmc@redhat.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.