From: Keir Fraser <keir@xensource.com>
To: Paul Samon <paul.samon@gmail.com>, xen-devel@lists.xensource.com
Subject: Re: Re: A wrong assert in get_ioreq()?
Date: Wed, 04 Jul 2007 14:22:23 +0100 [thread overview]
Message-ID: <C2B15D9F.11DBF%keir@xensource.com> (raw)
In-Reply-To: <34cec8c90707040412s4aa16fcdlbdd252e42a05f76e@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 638 bytes --]
The lock is taken in, for example, hvm_vcpu_initialise(), which calles
get_ioreq(v) with v!=current. So the assertion is correct as-is.
-- Keir
On 4/7/07 12:12, "Paul Samon" <paul.samon@gmail.com> wrote:
> Sorry, I meant the assert should "ASSERT(v == current)."
>
> On 7/4/07, Paul Samon <paul.samon@gmail.com> wrote:
>> I don't think it should be
>> ASSERT(v == current).
>> we don't get the lock first, and I think we needn't it.
>>
>> Am I missing something?
>>
>>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
[-- Attachment #1.2: Type: text/html, Size: 1584 bytes --]
[-- Attachment #2: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2007-07-04 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-04 11:05 A wrong assert in get_ioreq()? Paul Samon
2007-07-04 11:12 ` Paul Samon
2007-07-04 13:22 ` Keir Fraser [this message]
2007-07-05 1:08 ` Paul Samon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C2B15D9F.11DBF%keir@xensource.com \
--to=keir@xensource.com \
--cc=paul.samon@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.