From: Keir Fraser <keir@xensource.com>
To: Jan Beulich <jbeulich@novell.com>, Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: xen-devel@lists.xensource.com
Subject: Re: early_cpu_init() and identify_cpu()
Date: Tue, 17 Jul 2007 11:15:32 +0100 [thread overview]
Message-ID: <C2C25554.128FF%keir@xensource.com> (raw)
In-Reply-To: <469CAF43.76E4.0078.0@novell.com>
On 17/7/07 11:00, "Jan Beulich" <jbeulich@novell.com> wrote:
>> Does this mean that defaulting to setting up WC on a power-of-two-sized
>> region starting at the framebuffer address is not really safe on a fair
>> number of systems?
>
> So I suppose, also based on the fact that Linux is defensive here too in
> defaulting to not touching the MTRRs at all. I implemented this in a similar
> fashion for Xen now.
How about remapping the framebuffer specifying WC in the PAT bits, if the
CPU is detected to support PAT? This might work more safely because we can
map at 4kB granularity rather than merely power-of-two. It depends on how
close the command queues actually are to the lfb in the VRAM map.
If we just mapped the 4kB-rounded region specified by lfb_base to
lfb_base+lfb_size (as determined via the VBE Get Mode Info call) as WC,
would that be safe?
If so we could use that unconditionally and avoid any MTRR-poking code. PAT
has been around for ages now.
-- Keir
next prev parent reply other threads:[~2007-07-17 10:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 16:16 early_cpu_init() and identify_cpu() Jan Beulich
2007-07-13 16:26 ` Keir Fraser
2007-07-16 6:14 ` Jan Beulich
2007-07-16 6:25 ` Keir Fraser
2007-07-16 6:41 ` Jan Beulich
2007-07-16 6:57 ` Keir Fraser
2007-07-16 7:01 ` Keir Fraser
2007-07-16 7:31 ` Jan Beulich
2007-07-16 7:30 ` Jan Beulich
2007-07-16 9:23 ` Alan Cox
2007-07-17 7:55 ` Keir Fraser
2007-07-17 10:00 ` Jan Beulich
2007-07-17 10:15 ` Keir Fraser [this message]
2007-07-17 10:23 ` Keir Fraser
-- strict thread matches above, loose matches on Subject: below --
2007-07-16 8:18 Jan Beulich
2007-07-17 7:50 ` Keir Fraser
2007-07-17 9:58 ` Jan Beulich
2007-07-17 10:05 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C2C25554.128FF%keir@xensource.com \
--to=keir@xensource.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jbeulich@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.