All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir@xensource.com>
To: "Woller, Thomas" <thomas.woller@amd.com>, xen-devel@lists.xensource.com
Subject: Re: [PATCH][SVM] HVM fix for SWINT event injection
Date: Tue, 31 Jul 2007 19:02:53 +0100	[thread overview]
Message-ID: <C2D537DD.135CE%keir@xensource.com> (raw)
In-Reply-To: <683860AD674C7348A0BF0DE3918482F605801BE9@SAUSEXMB1.amd.com>

On 31/7/07 16:30, "Woller, Thomas" <thomas.woller@amd.com> wrote:

>> What I'll do is reorder SVM's intr.c core code to be the same
>> as for VMX (it's currently bogusly different) but with the
>> added constraint that we do not propagate exitintinfo.swint
>> into eventinj. I'll add a comment to explain why.
> Ok. Shoot me the patch first if you have time, I'll test with all the
> HVM guests I have on hand.

http://xenbits.xensource.com/staging/xen-unstable.hg, changeset 15662. It's
rather large, and only run-tested on VT. :-) I'll try and do some SVM
testing at home, but it'd be great if you can give it a spin.

My only question is whether vmcb->exitintinfo is written on every vmexit,
even those where no event was being delivered. I assumed so, and hence do
not bother to zap the field before vmentry, but that'll need adding back in
if I'm wrong.

> Re: 15652
> 15658 looks good initially, appreciate the quick fixes.

Yes, that was an embarrassing bug and not in Eric Liu's original patch!

 -- Keir

      reply	other threads:[~2007-07-31 18:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-27 15:31 [PATCH][SVM] HVM fix for SWINT event injection Woller, Thomas
2007-07-27 15:57 ` Keir Fraser
2007-07-30 19:06   ` Woller, Thomas
2007-07-30 21:17     ` Keir Fraser
2007-07-31 15:30       ` Woller, Thomas
2007-07-31 18:02         ` Keir Fraser [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C2D537DD.135CE%keir@xensource.com \
    --to=keir@xensource.com \
    --cc=thomas.woller@amd.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.